(tomcat) branch 9.0.x updated: Fix comment (thanks to Chuck)
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 22190db22c Fix comment (thanks to Chuck)
22190db22c is described below
commit 22190db22c67fd4bfb5537c4bc7f4a1f4091aa01
Author: Mark Thomas
AuthorDate: Tue Apr 16 14:20:04 2024 +0100
Fix comment (thanks to Chuck)
---
java/org/apache/catalina/authenticator/BasicAuthenticator.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/java/org/apache/catalina/authenticator/BasicAuthenticator.java
b/java/org/apache/catalina/authenticator/BasicAuthenticator.java
index 63ac050f69..c293af288c 100644
--- a/java/org/apache/catalina/authenticator/BasicAuthenticator.java
+++ b/java/org/apache/catalina/authenticator/BasicAuthenticator.java
@@ -226,8 +226,7 @@ public class BasicAuthenticator extends AuthenticatorBase {
}
/*
- * The authorization method string is case-insensitive and must have
at exactly one space character as a
- * delimiter.
+ * The authorization method string is case-insensitive and must have
exactly one space character as a delimiter.
*/
private void parseMethod() throws IllegalArgumentException {
if (authorization.startsWithIgnoreCase(METHOD, 0)) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat) branch 9.0.x updated: Fix comment typo.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new ca7988244d Fix comment typo.
ca7988244d is described below
commit ca7988244d7896df128f198a126432cee7808bb6
Author: Mark Thomas
AuthorDate: Thu Feb 22 12:46:04 2024 +
Fix comment typo.
---
java/org/apache/catalina/webresources/CachedResource.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/webresources/CachedResource.java
b/java/org/apache/catalina/webresources/CachedResource.java
index 6bb2f3cb58..f82b368851 100644
--- a/java/org/apache/catalina/webresources/CachedResource.java
+++ b/java/org/apache/catalina/webresources/CachedResource.java
@@ -326,7 +326,7 @@ public class CachedResource implements WebResource {
*
* One option to resolve this issue is to use a custom URL scheme for
resource URLs. This would allow us, via
* registration of a URLStreamHandlerFactory, to control how the
resources are accessed and ensure that all
- * access go via the cache We took this approach for war: URLs so we
can use jar:war:file: URLs to reference
+ * access go via the cache. We took this approach for war: URLs so we
can use jar:war:file: URLs to reference
* resources in unpacked WAR files. However, because
URL.setURLStreamHandlerFactory() may only be called once,
* this can cause problems when using other libraries that also want
to use a custom URL scheme.
*
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix comment typo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 079b2ea443 Fix comment typo
079b2ea443 is described below
commit 079b2ea443daab5454f7ea2c9f8f3cb1fb73dc16
Author: Mark Thomas
AuthorDate: Mon Jul 24 14:16:58 2023 +0100
Fix comment typo
---
test/org/apache/tomcat/websocket/TestPerMessageDeflate.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/org/apache/tomcat/websocket/TestPerMessageDeflate.java
b/test/org/apache/tomcat/websocket/TestPerMessageDeflate.java
index d1676b6c96..2f01440186 100644
--- a/test/org/apache/tomcat/websocket/TestPerMessageDeflate.java
+++ b/test/org/apache/tomcat/websocket/TestPerMessageDeflate.java
@@ -87,7 +87,7 @@ public class TestPerMessageDeflate {
MessagePart compressedPart = compressedParts.get(0);
-// Set up the decompression and process the received messafe
+// Set up the decompression and process the received message
PerMessageDeflate perMessageDeflateRx =
PerMessageDeflate.negotiate(preferences, true);
perMessageDeflateRx.setNext(new
TesterTransformation(compressedPart.getPayload()));
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix comment typo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 117c362047 Fix comment typo
117c362047 is described below
commit 117c3620470f742852692ae47b6904c8003cca61
Author: Mark Thomas
AuthorDate: Wed Jul 5 16:50:27 2023 +0100
Fix comment typo
---
java/org/apache/catalina/Manager.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/Manager.java
b/java/org/apache/catalina/Manager.java
index 589392b974..6ade69155d 100644
--- a/java/org/apache/catalina/Manager.java
+++ b/java/org/apache/catalina/Manager.java
@@ -232,7 +232,7 @@ public interface Manager {
*/
default String rotateSessionId(Session session) {
String newSessionId = null;
-// Assume there new Id is a duplicate until we prove it isn't. The
+// Assume the new Id is a duplicate until we prove it isn't. The
// chances of a duplicate are extremely low but the current ManagerBase
// code protects against duplicates so this default method does too.
boolean duplicate = true;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix comment
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new bf9451d81d Fix comment
bf9451d81d is described below
commit bf9451d81d84b8dca3d975e8d732b0673850cbda
Author: Mark Thomas
AuthorDate: Tue Jul 4 21:57:49 2023 +0100
Fix comment
---
java/org/apache/tomcat/util/net/AbstractEndpoint.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/tomcat/util/net/AbstractEndpoint.java
b/java/org/apache/tomcat/util/net/AbstractEndpoint.java
index 44a288ad79..9c203afd44 100644
--- a/java/org/apache/tomcat/util/net/AbstractEndpoint.java
+++ b/java/org/apache/tomcat/util/net/AbstractEndpoint.java
@@ -429,7 +429,7 @@ public abstract class AbstractEndpoint {
MessageDigest sha512Digest = MessageDigest.getInstance("SHA-256");
sha512Digest.update(certBytes);
sb.append(HexUtils.toHexString(sha512Digest.digest()));
-// SHA-256 fingerprint
+// SHA-1 fingerprint
sb.append("\nSHA-1 fingerprint: ");
MessageDigest sha1Digest = MessageDigest.getInstance("SHA-1");
sha1Digest.update(certBytes);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix comment typo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 3578c93597 Fix comment typo
3578c93597 is described below
commit 3578c93597bf91f4cd49579ec807e5a38221de66
Author: Mark Thomas
AuthorDate: Mon Mar 27 16:52:58 2023 +0100
Fix comment typo
---
java/org/apache/catalina/webresources/CachedResource.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/webresources/CachedResource.java
b/java/org/apache/catalina/webresources/CachedResource.java
index d512abca93..b2b4d62693 100644
--- a/java/org/apache/catalina/webresources/CachedResource.java
+++ b/java/org/apache/catalina/webresources/CachedResource.java
@@ -328,7 +328,7 @@ public class CachedResource implements WebResource {
* One option to resolve this issue is to use a custom URL scheme for
resource URLs. This would allow us, via
* registration of a URLStreamHandlerFactory, to control how the
resources are accessed and ensure that all
* access go via the cache We took this approach for war: URLs so we
can use jar:war:file: URLs to reference
- * resources in unpacked WAR files. However, because
URL.setURLStreamHandlerFactory() may only be caused once,
+ * resources in unpacked WAR files. However, because
URL.setURLStreamHandlerFactory() may only be called once,
* this can cause problems when using other libraries that also want
to use a custom URL scheme.
*
* The approach below allows us to insert a custom URLStreamHandler
without registering a custom protocol. The
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix comment typo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new f3b9e719bb Fix comment typo
f3b9e719bb is described below
commit f3b9e719bb92dd95247878f8d623ff99daa03fd3
Author: Mark Thomas
AuthorDate: Wed Jan 18 12:34:02 2023 +
Fix comment typo
---
java/org/apache/catalina/connector/Request.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/connector/Request.java
b/java/org/apache/catalina/connector/Request.java
index 949f4353e1..6cb200f8ef 100644
--- a/java/org/apache/catalina/connector/Request.java
+++ b/java/org/apache/catalina/connector/Request.java
@@ -1243,7 +1243,7 @@ public class Request implements HttpServletRequest {
// here. Need to do this before setting usingReader.
if (coyoteRequest.getCharacterEncoding() == null) {
// Nothing currently set explicitly.
-// Check the content
+// Check the context
Context context = getContext();
if (context != null) {
String enc = context.getRequestCharacterEncoding();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix comment typo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 7c7795fdba Fix comment typo
7c7795fdba is described below
commit 7c7795fdba30a56cef2d92bc8f8bb8be1d2eb2b5
Author: Mark Thomas
AuthorDate: Tue Aug 16 18:04:14 2022 +0100
Fix comment typo
---
java/org/apache/coyote/http2/Stream.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/coyote/http2/Stream.java
b/java/org/apache/coyote/http2/Stream.java
index 8cb4ff0087..4b776cd0a0 100644
--- a/java/org/apache/coyote/http2/Stream.java
+++ b/java/org/apache/coyote/http2/Stream.java
@@ -152,7 +152,7 @@ class Stream extends AbstractNonZeroStream implements
HeaderEmitter {
throw new IllegalArgumentException();
}
// This processing expects bytes. Server push will have used a String
-// to trigger a conversion if required.
+// so trigger a conversion if required.
hostValueMB.toBytes();
ByteChunk valueBC = hostValueMB.getByteChunk();
byte[] valueB = valueBC.getBytes();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix comment TODO
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new db90e53 Fix comment TODO
db90e53 is described below
commit db90e53e3289f8ca19273f20f6ef85e7ca116bea
Author: Mark Thomas
AuthorDate: Fri Nov 5 10:31:44 2021 +
Fix comment TODO
While this needed fixing, this commit has primarily been made to trigger
a CI build to
---
java/javax/servlet/ServletContext.java | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/java/javax/servlet/ServletContext.java
b/java/javax/servlet/ServletContext.java
index 590dce1..4785810 100644
--- a/java/javax/servlet/ServletContext.java
+++ b/java/javax/servlet/ServletContext.java
@@ -116,7 +116,11 @@ public interface ServletContext {
public int getMinorVersion();
/**
- * @return TODO
+ * Obtain the major version of the servlet specification for which this web
+ * application is implemented.
+ *
+ * @return The major version declared in web.xml
+ *
* @throws UnsupportedOperationExceptionIf called from a
*{@link
ServletContextListener#contextInitialized(ServletContextEvent)}
*method of a {@link ServletContextListener} that was not defined in a
@@ -125,7 +129,7 @@ public interface ServletContext {
*{@link ServletContextListener} defined in a TLD would not be able to
*use this method.
*
- * @since Servlet 3.0 TODO SERVLET3 - Add comments
+ * @since Servlet 3.0
*/
public int getEffectiveMajorVersion();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix comment typo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 31e4a08 Fix comment typo
31e4a08 is described below
commit 31e4a08bc0622f15d1ad409d13294a703c23439e
Author: Mark Thomas
AuthorDate: Mon Feb 1 10:19:32 2021 +
Fix comment typo
---
java/org/apache/coyote/http2/Http2UpgradeHandler.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
index 3da15af..7d0ecc5 100644
--- a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
@@ -1227,7 +1227,7 @@ class Http2UpgradeHandler extends AbstractStream
implements InternalHttpUpgradeH
if (stream.isClosedFinal()) {
// This stream went from IDLE to CLOSED and is likely to have
// been created by the client as part of the priority tree.
-// Candidate for steo 3.
+// Candidate for step 3.
candidatesStepThree.add(stream.getIdentifier());
} else if (stream.getChildStreams().size() == 0) {
// Prune it
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix comment
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new bb83129 Fix comment
bb83129 is described below
commit bb8312958b661218bf18b50eda7fef71642693db
Author: Mark Thomas
AuthorDate: Tue May 5 09:32:24 2020 +0100
Fix comment
---
test/org/apache/coyote/http2/TestStreamProcessor.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/org/apache/coyote/http2/TestStreamProcessor.java
b/test/org/apache/coyote/http2/TestStreamProcessor.java
index cfa0863..d660638 100644
--- a/test/org/apache/coyote/http2/TestStreamProcessor.java
+++ b/test/org/apache/coyote/http2/TestStreamProcessor.java
@@ -240,7 +240,7 @@ public class TestStreamProcessor extends Http2TestBase {
Tomcat.addServlet(ctxt, "compression", new CompressionServlet());
ctxt.addServletMappingDecoded("/compression", "compression");
-// Enable compression for the LargeServlet
+// Enable compression
Connector connector = tomcat.getConnector();
tomcat.start();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix comment
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 9a2eec7 Fix comment
9a2eec7 is described below
commit 9a2eec733ca9c2f3957255b15fa33c2786adc7d9
Author: Mark Thomas
AuthorDate: Tue Jan 21 11:47:26 2020 +
Fix comment
---
java/org/apache/coyote/http11/upgrade/UpgradeProcessorExternal.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/java/org/apache/coyote/http11/upgrade/UpgradeProcessorExternal.java
b/java/org/apache/coyote/http11/upgrade/UpgradeProcessorExternal.java
index 75d074e..b73f4e7 100644
--- a/java/org/apache/coyote/http11/upgrade/UpgradeProcessorExternal.java
+++ b/java/org/apache/coyote/http11/upgrade/UpgradeProcessorExternal.java
@@ -134,6 +134,6 @@ public class UpgradeProcessorExternal extends
UpgradeProcessorBase {
@Override
public void pause() {
-// NOOP for AJP
+// NOOP
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
