Re: [tomcat] branch main updated: Keep SNAPSHOT version aligned with current dev version

2022-09-23 Thread Mark Thomas

On 23/09/2022 11:37, Rémy Maucherat wrote:

On Fri, Sep 23, 2022 at 11:34 AM  wrote:


This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
  new e32d013f29 Keep SNAPSHOT version aligned with current dev version
e32d013f29 is described below

commit e32d013f29a61e826c9a3a09318cc896e53569ac
Author: Mark Thomas 
AuthorDate: Fri Sep 23 10:33:22 2022 +0100

 Keep SNAPSHOT version aligned with current dev version


I'm only half convinced. Overall, snapshots are not supposed to be
used except during dev activities or casual testing of maven, so
overwriting older ones may be kinda good. Not sure though.


My understanding of Maven versions (which may be wrong) is that we 
should have:


10.1.0-SNAPSHOT
10.1.1-SNAPSHOT
10.1.2-SNAPSHOT
etc
rather than
10.1-SNAPSHOT

I wasn't 100% sure myself so I only updated 10.1.x and 10.0.x

Happy for someone with more Maven expertise to advise on what we should 
be doing here.


If given a free choice, I think I prefer the 10.1-SNAPSHOT approach.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [tomcat] branch main updated: Keep SNAPSHOT version aligned with current dev version

2022-09-23 Thread Rémy Maucherat
On Fri, Sep 23, 2022 at 11:34 AM  wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/main by this push:
>  new e32d013f29 Keep SNAPSHOT version aligned with current dev version
> e32d013f29 is described below
>
> commit e32d013f29a61e826c9a3a09318cc896e53569ac
> Author: Mark Thomas 
> AuthorDate: Fri Sep 23 10:33:22 2022 +0100
>
> Keep SNAPSHOT version aligned with current dev version

I'm only half convinced. Overall, snapshots are not supposed to be
used except during dev activities or casual testing of maven, so
overwriting older ones may be kinda good. Not sure though.

Rémy

> ---
>  res/maven/mvn-pub.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/res/maven/mvn-pub.xml b/res/maven/mvn-pub.xml
> index 8327636e95..924a64352f 100644
> --- a/res/maven/mvn-pub.xml
> +++ b/res/maven/mvn-pub.xml
> @@ -504,7 +504,7 @@
>   value="${maven.snapshot.repo.repositoryId}"/>
>
> -  
> +   value="${maven.asf.release.deploy.version}-SNAPSHOT"/>
>   value="${maven.asf.release.deploy.version}-dev"/>
>  
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch main updated: Keep SNAPSHOT version aligned with current dev version

2022-09-23 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new e32d013f29 Keep SNAPSHOT version aligned with current dev version
e32d013f29 is described below

commit e32d013f29a61e826c9a3a09318cc896e53569ac
Author: Mark Thomas 
AuthorDate: Fri Sep 23 10:33:22 2022 +0100

Keep SNAPSHOT version aligned with current dev version
---
 res/maven/mvn-pub.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/res/maven/mvn-pub.xml b/res/maven/mvn-pub.xml
index 8327636e95..924a64352f 100644
--- a/res/maven/mvn-pub.xml
+++ b/res/maven/mvn-pub.xml
@@ -504,7 +504,7 @@
   
   
-  
+  
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org