Re: [tomcat] branch master updated: Fixed false positives in unit tests on Windows

2019-04-12 Thread Mark Thomas
On 12/04/2019 13:13, Mark Thomas wrote: > On 12/04/2019 09:56, Mark Thomas wrote: >> On 12/04/2019 01:32, Igal Sapir wrote: >>> Mark, >>> >>> I just realized that you refactored my fix for the false positive unit test >>> [1] a while ago. Unfortunately your refactoring still shows false >>> positi

Re: [tomcat] branch master updated: Fixed false positives in unit tests on Windows

2019-04-12 Thread Mark Thomas
On 12/04/2019 09:56, Mark Thomas wrote: > On 12/04/2019 01:32, Igal Sapir wrote: >> Mark, >> >> I just realized that you refactored my fix for the false positive unit test >> [1] a while ago. Unfortunately your refactoring still shows false >> positives if the path of the command prompt has a lowe

Re: [tomcat] branch master updated: Fixed false positives in unit tests on Windows

2019-04-12 Thread Mark Thomas
On 12/04/2019 01:32, Igal Sapir wrote: > Mark, > > I just realized that you refactored my fix for the false positive unit test > [1] a while ago. Unfortunately your refactoring still shows false > positives if the path of the command prompt has a lower-cased driver > letter, e.g. > > expected: b

RE: [tomcat] branch master updated: Fixed false positives in unit tests on Windows

2019-04-11 Thread Igal Sapir
Mark, I just realized that you refactored my fix for the false positive unit test [1] a while ago. Unfortunately your refactoring still shows false positives if the path of the command prompt has a lower-cased driver letter, e.g. expected: but was: I pushed a different fix earlier, prior to no

[tomcat] branch master updated: Fixed false positives in unit tests on Windows

2019-04-11 Thread isapir
This is an automated email from the ASF dual-hosted git repository. isapir pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 985d008 Fixed false positives in unit tests on