Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-21 Thread Martin Grigorov
On Thu, Oct 21, 2021, 19:30 Christopher Schultz < ch...@christopherschultz.net> wrote: > Martin, > > On 10/21/21 06:09, Martin Grigorov wrote: > > On Thu, Oct 21, 2021 at 12:29 PM Mark Thomas wrote: > > > >> On 21/10/2021 10:19, Mark Thomas wrote: > >>> On 21/10/2021 08:40, Martin Grigorov

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-21 Thread Christopher Schultz
Martin, On 10/21/21 06:09, Martin Grigorov wrote: On Thu, Oct 21, 2021 at 12:29 PM Mark Thomas wrote: On 21/10/2021 10:19, Mark Thomas wrote: On 21/10/2021 08:40, Martin Grigorov wrote: Fails also at TravisCI: https://app.travis-ci.com/github/apache/tomcat/jobs/543217112 diff --git

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-21 Thread Mark Thomas
On October 21, 2021 10:09:09 AM UTC, Martin Grigorov wrote: >On Thu, Oct 21, 2021 at 12:29 PM Mark Thomas wrote: > >> On 21/10/2021 10:19, Mark Thomas wrote: >> > On 21/10/2021 08:40, Martin Grigorov wrote: >> > >> > >> > >> >>> Fails also at TravisCI: >> >>>

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-21 Thread Martin Grigorov
On Thu, Oct 21, 2021 at 12:29 PM Mark Thomas wrote: > On 21/10/2021 10:19, Mark Thomas wrote: > > On 21/10/2021 08:40, Martin Grigorov wrote: > > > > > > > >>> Fails also at TravisCI: > >>> https://app.travis-ci.com/github/apache/tomcat/jobs/543217112 > >>> > >> > >> diff --git > >> >

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-21 Thread Mark Thomas
On 21/10/2021 10:19, Mark Thomas wrote: On 21/10/2021 08:40, Martin Grigorov wrote: Fails also at TravisCI: https://app.travis-ci.com/github/apache/tomcat/jobs/543217112 diff --git test/org/apache/catalina/connector/TestCoyoteAdapterCanonicalization.java

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-21 Thread Mark Thomas
On 21/10/2021 08:40, Martin Grigorov wrote: Fails also at TravisCI: https://app.travis-ci.com/github/apache/tomcat/jobs/543217112 diff --git test/org/apache/catalina/connector/TestCoyoteAdapterCanonicalization.java test/org/apache/catalina/connector/TestCoyoteAdapterCanonicalization.java

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-21 Thread Martin Grigorov
On Thu, Oct 21, 2021 at 10:29 AM Martin Grigorov wrote: > > > On Thu, Oct 21, 2021 at 10:13 AM Martin Grigorov > wrote: > >> >> >> On Thu, Oct 21, 2021 at 9:56 AM Martin Grigorov >> wrote: >> >>> >>> >>> On Wed, Oct 20, 2021 at 3:39 PM Mark Thomas wrote: >>> I'm not seeing those failures

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-21 Thread Martin Grigorov
On Thu, Oct 21, 2021 at 10:13 AM Martin Grigorov wrote: > > > On Thu, Oct 21, 2021 at 9:56 AM Martin Grigorov > wrote: > >> >> >> On Wed, Oct 20, 2021 at 3:39 PM Mark Thomas wrote: >> >>> I'm not seeing those failures with OpenJDK 17.0.1 >>> >> >> I see the test is added 8 days ago, so most

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-21 Thread Martin Grigorov
On Thu, Oct 21, 2021 at 9:56 AM Martin Grigorov wrote: > > > On Wed, Oct 20, 2021 at 3:39 PM Mark Thomas wrote: > >> I'm not seeing those failures with OpenJDK 17.0.1 >> > > I see the test is added 8 days ago, so most probably it is not related to > the JDK version at all. > > >> >> The

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-21 Thread Martin Grigorov
On Wed, Oct 20, 2021 at 3:39 PM Mark Thomas wrote: > I'm not seeing those failures with OpenJDK 17.0.1 > I see the test is added 8 days ago, so most probably it is not related to the JDK version at all. > > The response line and body look to be correct to me. > > The failure appears to be

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-20 Thread Mark Thomas
I'm not seeing those failures with OpenJDK 17.0.1 The response line and body look to be correct to me. The failure appears to be with the request body. Is it possible you aren't using UTF-8 for the *.java file? You could try using "/foo\u20acbar" as the expected canonicalized URI. Mark On

2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-20 Thread Martin Grigorov
Hi, Today I've tested JDK 17.0.1 and noticed these failures: Testcase: testCanonicalizationSpecification[49: requestURI[/foo%E2%82%ACbar]] took 0.055 sec FAILED HTTP/1.1 200 /foo€bar junit.framework.AssertionFailedError: HTTP/1.1 200 /foo€bar at