DO NOT REPLY [Bug 47440] Remove DB-specific SQL statements from test cases (SELECT 1)

2010-08-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47440

Mark Thomas  changed:

   What|Removed |Added

  Component|Modules: jdbc-pool  |jdbc-pool
Product|Tomcat 6|Tomcat Modules
   Target Milestone|default |---

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47440] Remove DB-specific SQL statements from test cases (SELECT 1)

2009-06-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47440


Filip Hanik  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Comment #5 from Filip Hanik   2009-06-29 07:37:07 PST ---
Fixed in r789345 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=789345 )

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47440] Remove DB-specific SQL statements from test cases (SELECT 1)

2009-06-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47440


Sebb  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |




--- Comment #4 from Sebb   2009-06-28 17:36:09 PST ---
OK, I'd not noticed that the DefaultProperties.validationQuery field was not
propagated by DefaultTestCase.createDefaultDataSource().

So the first patch was wrong, but the original problem still remains - the
tests are DB-specific.

Two possible solutions:
- DefaultTestCase.createDefaultDataSource() could set the query from the
default
- change the patch to pick up the default query and use that.

The other patch is surely OK as it stands?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47440] Remove DB-specific SQL statements from test cases (SELECT 1)

2009-06-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47440


Filip Hanik  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Comment #3 from Filip Hanik   2009-06-28 16:47:54 PST ---
This would change the way the tests run, and that is not the intention of your
enhancement.
I cant remove the set validation query without replacing it with something, ie
a default query, that can be swapped out.

There is no default query set

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47440] Remove DB-specific SQL statements from test cases (SELECT 1)

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47440





--- Comment #2 from Sebb   2009-06-27 05:19:46 PST ---
Created an attachment (id=23891)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23891)
Use validationQuery instead of "SELECT 1"

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47440] Remove DB-specific SQL statements from test cases (SELECT 1)

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47440





--- Comment #1 from Sebb   2009-06-27 05:19:01 PST ---
Created an attachment (id=23890)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23890)
Remove setValidattionQuery() calls

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org