DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)
https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Component|Catalina|Catalina Version|5.5.28 |6.0.20 Resolution||FIXED Product|Tomcat 5|Tomcat 6 Target Milestone|--- |default --- Comment #9 from Konstantin Kolinko 2010-01-06 18:06:55 UTC --- metadata-complete is @since Servlet 2.5, so this issue is not applicable to Tomcat 5.5. Closing as FIXED in TC 6. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)
https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 Mark Thomas changed: What|Removed |Added Component|Catalina|Catalina Version|6.0.20 |5.5.28 Product|Tomcat 6|Tomcat 5 Target Milestone|default |--- --- Comment #8 from Mark Thomas 2009-12-19 14:35:59 GMT --- The patch has been applied to 6.0.x and will be included in 6.0.21 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)
https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 --- Comment #7 from Keiichi Fujino 2009-12-17 16:42:58 UTC --- (In reply to comment #5) > (In reply to comment #3) > > Created an attachment (id=24721) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24721) [details] [details] > > new patch. > > I can't see why null needs to be handled here. The only acceptable values are > true or false. I think. f "metadata-complete" is not specified for web.xml, value becomes null. In a new patch. For a strict spec, if "metadata-complete" is not specified, the annotation was made effective. However, I think that the concept is more profitable of conf/web.xml as for the comment 4. I support the previous patch. many thanks. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)
https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 --- Comment #6 from Konstantin Kolinko 2009-12-17 12:21:14 UTC --- >From second thought: - The spec authors had to specify how to interpret the missing value. Leaving that unspecified would be much worse. - The default content of global conf/web.xml provides specification-compliant behavior. If you start changing that file, you should know what you are doing. Thus, let's go with the original patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)
https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 --- Comment #5 from Mark Thomas 2009-12-17 08:17:37 GMT --- (In reply to comment #3) > Created an attachment (id=24721) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24721) [details] > new patch. I can't see why null needs to be handled here. The only acceptable values are true or false. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)
https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 --- Comment #4 from Mark Thomas 2009-12-17 08:16:39 GMT --- (In reply to comment #2) > SRV.14.5 of Servlet 2.5 says that if “metadata-complete” attribute is absent, > it must be treated the same way as having the value of "false". > > Thus, if we allow to specify it in global conf/web.xml, setting it to "true" > there will result in violation of the spec. I disagree. The spec does not consider the concept of a global or default web.xml. A global web.xml is a Tomcat invention and one where Tomcat controls how it is to be interpreted, not the spec. The convention is the the global web.xml sets the defaults for all application web.xml files unless explicitly overridden at the application level. Hence the behaviour with the patch applied is as expected. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)
https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 --- Comment #3 from Keiichi Fujino 2009-12-17 02:08:29 UTC --- Created an attachment (id=24721) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24721) new patch. Oops! My patch was a mistake. However, even if this patch is reverted, it is a violation of spec yet. If “metadata-complete" of conf/web.xml is set true, and “metadata-complete" is not specified in each webApp, the annotation is invalid yet. This is violation of spec. I made a new patch. if“metadata-complete" is not specified, the annotation is made effective. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)
https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 --- Comment #2 from Konstantin Kolinko 2009-12-16 23:45:57 UTC --- SRV.14.5 of Servlet 2.5 says that if “metadata-complete” attribute is absent, it must be treated the same way as having the value of "false". Thus, if we allow to specify it in global conf/web.xml, setting it to "true" there will result in violation of the spec. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)
https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 --- Comment #1 from Mark Thomas 2009-11-22 12:52:02 GMT --- Thanks for the patch. It has been applied to trunk and proposed for 5.5.x and 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)
https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 Karl-Heinz changed: What|Removed |Added CC||charly41...@yahoo.de -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
