DO NOT REPLY [Bug 52830] DataSource JNDI lookup with javax.naming.Name failed

2012-03-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52830

--- Comment #7 from Konstantin Kolinko knst.koli...@gmail.com 2012-03-23 
16:44:30 UTC ---
(In reply to comment #6)
I've applied this alternative implementation in r1304468 (trunk), r1304471
(TC7)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52830] DataSource JNDI lookup with javax.naming.Name failed

2012-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52830

--- Comment #6 from Konstantin Kolinko knst.koli...@gmail.com 2012-03-21 
00:47:51 UTC ---
Regarding the patch - r1298635 - I see one minor (theoretical?) issue.

It calls
Name result = new CompositeName();
..
result.addAll(name.getSuffix(1));


Looking at CompositeName#addAll(Name) in Java 6u31 I see that it expects that
(Name instanceof CompositeName) and throws InvalidNameException if it is not.
With a generic Name.getSuffix(int) that is not true.

Though I do not see how other name implementations could be used here.

Here is alternative implementation of the fix:
TestNamingContext passes with it as well.
[[[
Name result = name.getSuffix(1);
result.add(0, name.get(0).substring(prefixLength));
return result;
]]]

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52830] DataSource JNDI lookup with javax.naming.Name failed

2012-03-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52830

--- Comment #3 from lachame...@gmail.com 2012-03-12 18:20:16 UTC ---
The same bug happen on Tomcat 6.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52830] DataSource JNDI lookup with javax.naming.Name failed

2012-03-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52830

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
  Component|Catalina|Catalina
 Resolution|FIXED   |
Product|Tomcat 7|Tomcat 6
   Target Milestone|--- |default

--- Comment #4 from Mark Thomas ma...@apache.org 2012-03-12 19:52:17 UTC ---
Re-opening to fix in Tomcat 6.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52830] DataSource JNDI lookup with javax.naming.Name failed

2012-03-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52830

--- Comment #5 from Mark Thomas ma...@apache.org 2012-03-12 19:53:46 UTC ---
Fix proposed for 6.0.x.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52830] DataSource JNDI lookup with javax.naming.Name failed

2012-03-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52830

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Mark Thomas ma...@apache.org 2012-03-08 22:44:45 UTC ---
Fixed in trunk and 7.0.x and will be included in 7.0.27 onwards.

Thanks for the report.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52830] DataSource JNDI lookup with javax.naming.Name failed

2012-03-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52830

--- Comment #1 from moogle easyra...@gmail.com 2012-03-06 09:57:15 UTC ---
Doesn't work with a javax.naming.Name create with key java:comp/env/jdbc/mydb
If you look at
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/SelectorContext.java?revision=1225625view=markup

You could see that prefix is only java: and  protected Name parseName(Name
name) return name.getSuffix(1)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org