Re: Disabling Some Test Cases by Pattern

2021-05-12 Thread Igal Sapir 
Martin,

On Tue, May 11, 2021 at 12:18 AM Martin Grigorov 
wrote:

> Hi Igal,
>
> On Mon, May 10, 2021 at 4:28 AM Igal Sapir  wrote:
>
> > I am trying to disable some test cases that constantly fail on my
> machine.
> > I have added the following to build.properties:
> >
> >
> >
> test.exclude=org.apache.catalina.tribes.group.Test**,org.apache.catalina.tribes.group.interceptors.Test**
> >
> > But I still get the following failures:
> >
> >[concat] Testsuites with failed tests:
> >[concat]
> >
> >
> TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
> >[concat]
> >
> >
> TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
> >[concat]
> >
> >
> TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
> >[concat]
> >
> >
> TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
> >
> > I expect the pattern
> [org.apache.catalina.tribes.group.interceptors.Test**]
> > to exclude the last 3 for example, but that doesn't happen.
> >
> > What am I doing wrong?
> >
>
> Looking at
>
> https://github.com/apache/tomcat/blob/9747a3a6334369deb9b5bef1b17b1fe0ce774cdf/build.xml#L2024-L2039
> I think you should use '/' instead of '.',
> i.e.
>
> test.exclude=org/apache/catalina/tribes/group/Test*,org/apache/catalina/tribes/group/interceptors/Test*
>

Brilliant!  That worked.

Thank you,

Igal



>
>
> >
> > Thanks,
> >
> > Igal
> >
>

Re: Disabling Some Test Cases by Pattern

2021-05-11 Thread Martin Grigorov 
Hi Igal,

On Mon, May 10, 2021 at 4:28 AM Igal Sapir  wrote:

> I am trying to disable some test cases that constantly fail on my machine.
> I have added the following to build.properties:
>
>
> test.exclude=org.apache.catalina.tribes.group.Test**,org.apache.catalina.tribes.group.interceptors.Test**
>
> But I still get the following failures:
>
>[concat] Testsuites with failed tests:
>[concat]
>
> TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
>[concat]
>
> TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
>[concat]
>
> TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
>[concat]
>
> TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
>
> I expect the pattern [org.apache.catalina.tribes.group.interceptors.Test**]
> to exclude the last 3 for example, but that doesn't happen.
>
> What am I doing wrong?
>

Looking at
https://github.com/apache/tomcat/blob/9747a3a6334369deb9b5bef1b17b1fe0ce774cdf/build.xml#L2024-L2039
I think you should use '/' instead of '.',
i.e.
test.exclude=org/apache/catalina/tribes/group/Test*,org/apache/catalina/tribes/group/interceptors/Test*


>
> Thanks,
>
> Igal
>

Disabling Some Test Cases by Pattern

2021-05-09 Thread Igal Sapir 
I am trying to disable some test cases that constantly fail on my machine.
I have added the following to build.properties:

test.exclude=org.apache.catalina.tribes.group.Test**,org.apache.catalina.tribes.group.interceptors.Test**

But I still get the following failures:

   [concat] Testsuites with failed tests:
   [concat]
TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt

I expect the pattern [org.apache.catalina.tribes.group.interceptors.Test**]
to exclude the last 3 for example, but that doesn't happen.

What am I doing wrong?

Thanks,

Igal