Re: Fixing bug 33453

2011-06-20 Thread Mark Thomas
Getting back to this. Comments in-line. On 23/05/2011 22:01, Konstantin Kolinko wrote: 2011/5/20 Mark Thomas ma...@apache.org: All, I've been looking at [1]. Ignoring the flames, there do appear to be several use cases where the current time-stamp checks are insufficient (although there are

Re: Fixing bug 33453

2011-05-23 Thread Tim Funk
How about calling it getDependantsMap() instead of getDependants() ? Then catch the NoSuchMethodException (I in the case where the compiled jsp doesn't have getDependants() and that would force a recompile (and then the new version would be OK) -Tim On 5/20/2011 12:31 PM, Mark Thomas wrote:

Re: Fixing bug 33453

2011-05-23 Thread Konstantin Kolinko
2011/5/20 Mark Thomas ma...@apache.org: All, I've been looking at [1]. Ignoring the flames, there do appear to be several use cases where the current time-stamp checks are insufficient (although there are simple work-arounds). I have a patch [2] but I don't particularly like the fact that it

Fixing bug 33453

2011-05-20 Thread Mark Thomas
All, I've been looking at [1]. Ignoring the flames, there do appear to be several use cases where the current time-stamp checks are insufficient (although there are simple work-arounds). I have a patch [2] but I don't particularly like the fact that it breaks binary compatibility with JSPs