Re: Looking for mentor

2016-04-24 Thread Mark Thomas
On 23/04/2016 04:01, Abdessamed MANSOURI wrote: > I saw your modification on the code, but i really didn't understand the > idea behind it, in previous days, i tried to debug it, but really i didn't > figure where is the problem, if you have time, just explain to what you > have done :) The fix

Re: Looking for mentor

2016-04-22 Thread Abdessamed MANSOURI
I saw your modification on the code, but i really didn't understand the idea behind it, in previous days, i tried to debug it, but really i didn't figure where is the problem, if you have time, just explain to what you have done :) 2016-04-20 11:34 GMT+01:00 Mark Thomas : > On

Re: Looking for mentor

2016-04-20 Thread Mark Thomas
On 19/04/2016 23:44, Abdessamed MANSOURI wrote: > I think, i just have to write a simple test case which is pretty similair > to TestAsyncContextImpl.testListeners, or not?? :) Correct. You are heading in the right direction. You can use the existing test cases in TestAsyncContextImpl and the

Re: Looking for mentor

2016-04-19 Thread Abdessamed MANSOURI
I think, i just have to write a simple test case which is pretty similair to TestAsyncContextImpl.testListeners, or not?? :)

Re: Looking for mentor

2016-04-19 Thread Abdessamed MANSOURI
I'm seeing how you write unit test by reading the written unit test, i think, i should inherit TomcatBaseTest then use getTomcatInstance to get a Tomcat instance, then add the servlet to the context, then launching getUrl, and then how do i can know test the bug, do i should test it returned

Re: Looking for mentor

2016-04-19 Thread Abdessamed MANSOURI
correct me, if i'm wrong, plz :) 2016-04-19 22:58 GMT+01:00 Abdessamed MANSOURI : > I'm seeing how you write unit test by reading the written unit test, i > think, i should inherit TomcatBaseTest then use getTomcatInstance to get a > Tomcat instance, then add the servlet to

Re: Looking for mentor

2016-04-19 Thread Abdessamed MANSOURI
Yes, why not, since the past two days i were configuring my VM to run Ubuntu on my Windows 7, until today i finished (maybe because i'm not expert), the problem were when launch catalina jpda start, i can't listen on port 8000 (i tried to add rule in firewall but didn't work), so i changed it to

Re: Looking for mentor

2016-04-19 Thread Mark Thomas
On 17/04/2016 19:27, Abdessamed MANSOURI wrote: > Thank you so much, its so nice from you :) Another idea for somewhere to get started... I recently fixed bug 59219. That included a stand-alone test case but I didn't port that test case into the Tomcat unit tests. Porting that test case could be

Re: Looking for mentor

2016-04-17 Thread Abdessamed MANSOURI
Thank you so much, its so nice from you :) 2016-04-17 15:36 GMT+01:00 Mark Thomas : > On 17/04/2016 11:34, Abdessamed MANSOURI wrote: > > Guys, inside Tomcat source, there's many packages (Catalina, Jasper, > > Tomcat, Juli, Coyote) what these packages stand for?? ( i want to >

Re: Looking for mentor

2016-04-17 Thread Mark Thomas
On 17/04/2016 11:34, Abdessamed MANSOURI wrote: > Guys, inside Tomcat source, there's many packages (Catalina, Jasper, > Tomcat, Juli, Coyote) what these packages stand for?? ( i want to > understand basic Tomcat architecture) :) It is for Tomcat 6 and while the detail has changed the high-level

Re: Looking for mentor

2016-04-17 Thread Abdessamed MANSOURI
Guys, inside Tomcat source, there's many packages (Catalina, Jasper, Tomcat, Juli, Coyote) what these packages stand for?? ( i want to understand basic Tomcat architecture) :) Thank you all. 2016-04-16 22:46 GMT+01:00 Abdessamed MANSOURI : > Martin, i just have 2 computers

Re: Looking for mentor

2016-04-16 Thread Abdessamed MANSOURI
Martin, i just have 2 computers (laptop and desktop), i don't use desktop too much, so in past i tried many JVM implementations, i wanted to see performance for each one, but today, when i launched unit tests, i forget about changing it to OpenJDK, so at the end i figured that i used J9 :) Mark,

Re: Looking for mentor

2016-04-16 Thread Mark Thomas
On 16/04/2016 20:34, Abdessamed MANSOURI wrote: > Thank you for your response and your time, i checkouted svn trunk and built > Tomcat successfully, its works fine, i also run ant test, for unit testing, > but it ended with some errors (i've used IBM J9), now i completed this > step, what do you

Re: Looking for mentor

2016-04-16 Thread Martin Grigorov
Hi, On Sat, Apr 16, 2016 at 9:34 PM, Abdessamed MANSOURI wrote: > Thank you for your response and your time, i checkouted svn trunk and built > Tomcat successfully, its works fine, i also run ant test, for unit testing, > but it ended with some errors (i've used IBM J9), now

Re: Looking for mentor

2016-04-16 Thread Abdessamed MANSOURI
Thank you for your response and your time, i checkouted svn trunk and built Tomcat successfully, its works fine, i also run ant test, for unit testing, but it ended with some errors (i've used IBM J9), now i completed this step, what do you suggests me to do now?? :) I can't find Tomcat on Jira,

Re: Looking for mentor

2016-04-16 Thread Mark Thomas
On 15/04/2016 17:59, Abdessamed MANSOURI wrote: > Hello all, > > I'm newcomer and i want to contribute to Tomcat developement, i have some > free time (alots of time), so i want to be useful in this world better than > sleeping all the day, so i'm looking for applying Apache mentoring program, >

Looking for mentor

2016-04-15 Thread Abdessamed MANSOURI
Hello all, I'm newcomer and i want to contribute to Tomcat developement, i have some free time (alots of time), so i want to be useful in this world better than sleeping all the day, so i'm looking for applying Apache mentoring program, i'm not guru in Java but not totaly a newbie, so i want to