Re: Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
On Thu, May 9, 2019 at 6:44 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy and Mark, > > On 5/9/19 12:32, Rémy Maucherat wrote: > > On Thu, May 9, 2019 at 4:47 PM Mark Thomas > > wrote: > > > >> On 09/05/2019 14:38, Rémy

Re: Multi threaded accept and polling

2019-05-09 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 5/9/19 12:49, Mark Thomas wrote: > On 09/05/2019 17:44, Christopher Schultz wrote: >> Rémy and Mark, >> >> On 5/9/19 12:32, Rémy Maucherat wrote: >>> On Thu, May 9, 2019 at 4:47 PM Mark Thomas >>> wrote: >> On 09/05/2019 14:38,

Re: Multi threaded accept and polling

2019-05-09 Thread Mark Thomas
On 09/05/2019 17:44, Christopher Schultz wrote: > Rémy and Mark, > > On 5/9/19 12:32, Rémy Maucherat wrote: >> On Thu, May 9, 2019 at 4:47 PM Mark Thomas >> wrote: > >>> On 09/05/2019 14:38, Rémy Maucherat wrote: >>> >>> >>> > +1 to hard-coding to a single acceptor thread and removing

Re: Multi threaded accept and polling

2019-05-09 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy and Mark, On 5/9/19 12:32, Rémy Maucherat wrote: > On Thu, May 9, 2019 at 4:47 PM Mark Thomas > wrote: > >> On 09/05/2019 14:38, Rémy Maucherat wrote: >> >> >> +1 to hard-coding to a single acceptor thread and removing the

Re: Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
On Thu, May 9, 2019 at 4:47 PM Mark Thomas wrote: > On 09/05/2019 14:38, Rémy Maucherat wrote: > > > > >> +1 to hard-coding to a single acceptor thread and removing the plumbing > >> that supports more than that. > > > > Ok, done. > > Great. > > > So I suppose you prefer keeping the ability to

Re: Multi threaded accept and polling

2019-05-09 Thread Mark Thomas
On 09/05/2019 14:38, Rémy Maucherat wrote: >> +1 to hard-coding to a single acceptor thread and removing the plumbing >> that supports more than that. > > Ok, done. Great. > So I suppose you prefer keeping the ability to have multiple poller threads > for NIO ? NIO defaults to 1 anyway. I

Re: Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
On Thu, May 9, 2019 at 2:36 PM Mark Thomas wrote: > accept() is effectively synchronized at the OS level. > > I recall doing some testing on this and there was a small gain in > throughput when testing on localhost without keep-alive if I used two > accept threads. Essentially, one thread was

Re: Multi threaded accept and polling

2019-05-09 Thread Mark Thomas
On 09/05/2019 12:45, Rémy Maucherat wrote: > Hi, > > A long time ago (in this galaxy, not another one), Tomcat has added the > capability to have multiple accept threads. I have no idea what test > revealed that Tomcat was somehow not accepting sockets fast enough, and > maybe it could be the

Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
Hi, A long time ago (in this galaxy, not another one), Tomcat has added the capability to have multiple accept threads. I have no idea what test revealed that Tomcat was somehow not accepting sockets fast enough, and maybe it could be the case in crazy microbenchmarks, but this is not going to