Re: Proposed change to STREAMS_DROP_EMPTY_MESSAGES system property

2019-02-06 Thread Mark Thomas
I went for c in the end. The TCK passes as do all of our own tests. Back-porting the change is still on my personal TODO list. Mark On 05/02/2019 22:02, Romain Manni-Bucau wrote: > As an user c sounds ok. Worse case maybe keep it for 1 release with some > comm to have time to migrate if relevan

Re: Proposed change to STREAMS_DROP_EMPTY_MESSAGES system property

2019-02-05 Thread Romain Manni-Bucau
As an user c sounds ok. Worse case maybe keep it for 1 release with some comm to have time to migrate if relevant. Le mar. 5 févr. 2019 à 20:10, Rémy Maucherat a écrit : > On Tue, Feb 5, 2019 at 7:58 PM Mark Thomas wrote: > > > Hi, > > > > org.apache.tomcat.websocket.STREAMS_DROP_EMPTY_MESSAGES

Re: Proposed change to STREAMS_DROP_EMPTY_MESSAGES system property

2019-02-05 Thread Rémy Maucherat
On Tue, Feb 5, 2019 at 7:58 PM Mark Thomas wrote: > Hi, > > org.apache.tomcat.websocket.STREAMS_DROP_EMPTY_MESSAGES > > The above system property was added to address an issue with Tomcat's > WebSocket implementation not passing the TCK. Tomcat was sending empty > messages when the TCK wasn't exp

Proposed change to STREAMS_DROP_EMPTY_MESSAGES system property

2019-02-05 Thread Mark Thomas
Hi, org.apache.tomcat.websocket.STREAMS_DROP_EMPTY_MESSAGES The above system property was added to address an issue with Tomcat's WebSocket implementation not passing the TCK. Tomcat was sending empty messages when the TCK wasn't expecting a message to be sent. Now that we have access to the TCK