Re: Tomcat 10 digester warnings

2021-01-04 Thread Romain Manni-Bucau
Le lun. 4 janv. 2021 à 15:04, Mark Thomas a écrit : > On 04/01/2021 11:54, Romain Manni-Bucau wrote: > > > > > Well it also depends the classpath. I fully agree with a plain tomcat not > > customized you don't get much - just have a more consistent usage of > > resources but it is about being

Re: Tomcat 10 digester warnings

2021-01-04 Thread Mark Thomas
On 04/01/2021 11:54, Romain Manni-Bucau wrote: > Well it also depends the classpath. I fully agree with a plain tomcat not > customized you don't get much - just have a more consistent usage of > resources but it is about being purist so not that interesting to me here. > Now make your

Re: Tomcat 10 digester warnings

2021-01-04 Thread Romain Manni-Bucau
Le lun. 4 janv. 2021 à 12:41, Mark Thomas a écrit : > On 04/01/2021 08:59, Romain Manni-Bucau wrote: > > Hi Mark, > > > > The proposal is to move the locationFor to a Supplier instead of > > eagerly loading the URL (means the maps passed to the resolver override > the > > read part to handle it)

Re: Tomcat 10 digester warnings

2021-01-04 Thread Mark Thomas
On 04/01/2021 08:59, Romain Manni-Bucau wrote: > Hi Mark, > > The proposal is to move the locationFor to a Supplier instead of > eagerly loading the URL (means the maps passed to the resolver override the > read part to handle it) - or a fully lazy map impl works too. > Idea is to avoid to be

Re: Tomcat 10 digester warnings

2021-01-04 Thread Romain Manni-Bucau
Hi Mark, The proposal is to move the locationFor to a Supplier instead of eagerly loading the URL (means the maps passed to the resolver override the read part to handle it) - or a fully lazy map impl works too. Idea is to avoid to be able to hit locationFor() until it is used for the related

Re: Tomcat 10 digester warnings

2021-01-04 Thread Mark Thomas
On 03/01/2021 16:06, Romain Manni-Bucau wrote: > So thought it was a Tomcat 10 issue but seems it is a TomEE 9 one (which > wrongly repackaged servlet-api jar). Indeed. > So overall Tomcat 10 is ok, just to follow up on one still relevant > question: is it worth doing all these lookups lazily

Re: Tomcat 10 digester warnings

2021-01-03 Thread Romain Manni-Bucau
Hmm, maybe it is a packaging issue. Testing TomEE 9 patched with Tomcat 10 binaries I got: 03-Jan-2021 17:00:57.997 WARNING [main] org.apache.tomcat.util.descriptor.DigesterFactory.locationFor The XML schema [XMLSchema.dtd] could not be found. This is very likely to break XML validation if XML

Re: Tomcat 10 digester warnings

2021-01-03 Thread Mark Thomas
On 03/01/2021 10:35, Romain Manni-Bucau wrote: > Hi all > > Digester prefetches most ee schemas but ee 9 bundle does miss most of them > leading to a lot of warnings at startup. > Should log level be reduced or fetching be done lazily? Sorry, I am unable to understand the problem you are

Tomcat 10 digester warnings

2021-01-03 Thread Romain Manni-Bucau
Hi all Digester prefetches most ee schemas but ee 9 bundle does miss most of them leading to a lot of warnings at startup. Should log level be reduced or fetching be done lazily?