Re: javax.tools based JSP compiler

2019-05-13 Thread Emmanuel Bourg
Le 13/05/2019 à 12:17, Mark Thomas a écrit : > If I am understanding this all correctly, the proposed way forward is to > (eventually) replace the Ant compiler with the JSR199 based Javac > compiler? If so, then +1 from me. I mostly aim at providing an easy way to use the new language features

Re: javax.tools based JSP compiler

2019-05-13 Thread Mark Thomas
On 11/05/2019 21:23, Emmanuel Bourg wrote: > Le 11/05/2019 à 00:46, Emmanuel Bourg a écrit : > >> - I'm not sure about the performance, ECJ was known to be faster than >> javac in the past but I don't know if it's still true today. > > I ran a quick test on an old Core 2 Duo with a SSD,

Re: javax.tools based JSP compiler

2019-05-11 Thread Emmanuel Bourg
Le 11/05/2019 à 00:46, Emmanuel Bourg a écrit : > - I'm not sure about the performance, ECJ was known to be faster than > javac in the past but I don't know if it's still true today. I ran a quick test on an old Core 2 Duo with a SSD, compiling Tomcat and another Ant based project of mine. The

Re: javax.tools based JSP compiler

2019-05-10 Thread Emmanuel Bourg
Le 09/05/2019 à 00:34, Mark Thomas a écrit : > +1 > > Need to remove the @author tags and add some info on how to configure > jasper to use them. Ok will do. > A few daft questions: > > 1. If we used the JSR199Complier by default would that allow us to > remove the Eclipse compiler as a

Re: javax.tools based JSP compiler

2019-05-08 Thread Mark Thomas
On 08/05/2019 21:58, Rémy Maucherat wrote: > On Wed, May 8, 2019 at 10:31 PM Emmanuel Bourg wrote: > >> Hi all, >> >> I've rebased the javax.tools JSP compiler on top of the current master >> branch : >> >> https://github.com/ebourg/tomcat/tree/jasper-javax-tools-support >> >> Please let me

Re: javax.tools based JSP compiler

2019-05-08 Thread Rémy Maucherat
On Wed, May 8, 2019 at 10:31 PM Emmanuel Bourg wrote: > Hi all, > > I've rebased the javax.tools JSP compiler on top of the current master > branch : > > https://github.com/ebourg/tomcat/tree/jasper-javax-tools-support > > Please let me know how you feel about this stuff and if it's worth

Re: javax.tools based JSP compiler

2019-05-08 Thread Emmanuel Bourg
Hi all, I've rebased the javax.tools JSP compiler on top of the current master branch : https://github.com/ebourg/tomcat/tree/jasper-javax-tools-support Please let me know how you feel about this stuff and if it's worth merging. Emmanuel Bourg Le 09/04/2018 à 17:28, Emmanuel Bourg a écrit 

Re: javax.tools based JSP compiler

2018-04-09 Thread Emmanuel Bourg
Le 04/04/2018 à 09:54, Mark Thomas a écrit : > I like the idea of simplifying the integration of javac - irrespective > of the reasoning for wanting to use javac. I guess it is something to > look at in Tomcat 10. Whether or not it gets back-ported is a different > question. I guess it depends

Re: javax.tools based JSP compiler

2018-04-04 Thread Rémy Maucherat
On Wed, Apr 4, 2018 at 9:54 AM, Mark Thomas wrote: > On 04/04/18 08:52, Rémy Maucherat wrote: > > On Wed, Apr 4, 2018 at 9:34 AM, Emmanuel Bourg > wrote: > > > >> Hi all, > >> > >> Has anyone considered using the javax.tools API (JSR 199) to compile the > >>

Re: javax.tools based JSP compiler

2018-04-04 Thread Mark Thomas
On 04/04/18 08:52, Rémy Maucherat wrote: > On Wed, Apr 4, 2018 at 9:34 AM, Emmanuel Bourg wrote: > >> Hi all, >> >> Has anyone considered using the javax.tools API (JSR 199) to compile the >> JSPs yet? This could provide a unified API to compile the JSPs since ECJ >> also

Re: javax.tools based JSP compiler

2018-04-04 Thread Rémy Maucherat
On Wed, Apr 4, 2018 at 9:34 AM, Emmanuel Bourg wrote: > Hi all, > > Has anyone considered using the javax.tools API (JSR 199) to compile the > JSPs yet? This could provide a unified API to compile the JSPs since ECJ > also implements this API, and it would simplify the

javax.tools based JSP compiler

2018-04-04 Thread Emmanuel Bourg
Hi all, Has anyone considered using the javax.tools API (JSR 199) to compile the JSPs yet? This could provide a unified API to compile the JSPs since ECJ also implements this API, and it would simplify the integration of javac with Tomcat (no need to copy the Ant jars). With the new Java release