Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Mark Thomas
On 06/07/2011 13:26, Mark Thomas wrote: > On 06/07/2011 12:26, Konstantin Kolinko wrote: >> 2011/7/6 Mark Thomas : >>> On 06/07/2011 08:55, Konstantin Kolinko wrote: I have doubts regarding this change. If I understand correctly, recycle() (and thus recycleInternal()) is not ca

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Mark Thomas
On 06/07/2011 12:26, Konstantin Kolinko wrote: > 2011/7/6 Mark Thomas : >> On 06/07/2011 08:55, Konstantin Kolinko wrote: >>> I have doubts regarding this change. >>> >>> If I understand correctly, recycle() (and thus recycleInternal()) is >>> not called when several requests are processed in a ro

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Konstantin Kolinko
2011/7/6 Mark Thomas : > On 06/07/2011 08:55, Konstantin Kolinko wrote: >> I have doubts regarding this change. >> >> If I understand correctly,  recycle() (and thus recycleInternal()) is >> not called when several requests are processed in a row. > > Recycle is called between every request, keepin

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Mark Thomas
On 06/07/2011 08:55, Konstantin Kolinko wrote: > I have doubts regarding this change. > > If I understand correctly, recycle() (and thus recycleInternal()) is > not called when several requests are processed in a row. Recycle is called between every request, keeping in mind that a Comet request

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Konstantin Kolinko
I have doubts regarding this change. If I understand correctly, recycle() (and thus recycleInternal()) is not called when several requests are processed in a row. So, in the old code sendfile is set to null before each request, in the new code it is set to null only once after connection is clo

svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-06-19 Thread markt
Author: markt Date: Sun Jun 19 21:15:22 2011 New Revision: 1137440 URL: http://svn.apache.org/viewvc?rev=1137440&view=rev Log: Reset sendfile data in recycle method so prepareRequest can be pulled up Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java tomcat/trunk