Re: svn commit: r1214855 - in /tomcat/trunk: java/org/apache/jasper/compiler/Parser.java test/org/apache/jasper/compiler/TestParser.java test/webapp-3.0/bug52335.jsp

2011-12-16 Thread Mark Thomas
On 15/12/2011 23:22, ma...@apache.org wrote: Konstantin Kolinko knst.koli...@gmail.com wrote: 1. The test fix is wrong. \% should print % 2. Note // Output the first character comment in parseTemplateText(). That is special handling of the first character. My understanding of the

svn commit: r1214855 - in /tomcat/trunk: java/org/apache/jasper/compiler/Parser.java test/org/apache/jasper/compiler/TestParser.java test/webapp-3.0/bug52335.jsp

2011-12-15 Thread markt
Author: markt Date: Thu Dec 15 16:50:25 2011 New Revision: 1214855 URL: http://svn.apache.org/viewvc?rev=1214855view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52335 % is only escaped as \%, not \% Added: tomcat/trunk/test/webapp-3.0/bug52335.jsp Modified:

Re: svn commit: r1214855 - in /tomcat/trunk: java/org/apache/jasper/compiler/Parser.java test/org/apache/jasper/compiler/TestParser.java test/webapp-3.0/bug52335.jsp

2011-12-15 Thread Konstantin Kolinko
1. The test fix is wrong. \% should print % 2. Note // Output the first character comment in parseTemplateText(). That is special handling of the first character. My understanding of the code before this change is that the loop in parseTemplateText() always breaks when '' is encountered. I

Re: svn commit: r1214855 - in /tomcat/trunk: java/org/apache/jasper/compiler/Parser.java test/org/apache/jasper/compiler/TestParser.java test/webapp-3.0/bug52335.jsp

2011-12-15 Thread markt
Konstantin Kolinko knst.koli...@gmail.com wrote: 1. The test fix is wrong. \% should print % 2. Note // Output the first character comment in parseTemplateText(). That is special handling of the first character. My understanding of the code before this change is that the loop in