subject:"svn commit\: r1408152 \- in \/tomcat\/tc7.0.x\/trunk\: .\/ java\/org\/apache\/catalina\/core\/ java\/org\/apache\/coyote\/ test\/org\/apache\/catalina\/core\/ webapps\/docs\/"

Re: svn commit: r1408152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ test/org/apache/catalina/core/ webapps/docs/

2012-11-13 Thread Mark Thomas

On 13/11/2012 00:57, Konstantin Kolinko wrote:
 2012/11/12  ma...@apache.org:
 Author: markt
 Date: Sun Nov 11 23:35:41 2012
 New Revision: 1408152

 URL: http://svn.apache.org/viewvc?rev=1408152view=rev
 Log:
 Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54123
 There are two things going on here:
 1. The reported bug. If there is a async timeout and no async listeners, 
 trigger a 500 response.
 2. Implement error dispatch. This is used a couple of times in the spec 
 without any definition. The implication from the part of the spec quoted in 
 the bug report is:
- The standard error page mechanism should be used to identify the page
- An async request that has been started should be left in async mode 
 when forwarding to the error page
- The error page may call complete() or dispatch()
 This commit hooks into the StandardHostValve to access the error page 
 mechanism. I could have copied and pasted but I preferred the dependency on 
 StandardHostValve
 Because the error page may do a dispatch(), need to ensure that when running 
 the dispatch(), the error page mechanism is not triggered a second time.
 Depending on what emerges running the full unit tests and the TCK, I mat 
 still decide to copy the error page code to AsyncContextImpl

 Modified:
 tomcat/tc7.0.x/trunk/   (props changed)
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
 tomcat/tc7.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java
 
 tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
 tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

 Propchange: tomcat/tc7.0.x/trunk/
 --
   Merged /tomcat/trunk:r1408148

 Modified: 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
 URL: 
 http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=1408152r1=1408151r2=1408152view=diff
 ==
 --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
 (original)
 +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
 Sun Nov 11 23:35:41 2012
 @@ -41,6 +41,8 @@ import javax.servlet.http.HttpServletRes
  import org.apache.catalina.AsyncDispatcher;
  import org.apache.catalina.Context;
  import org.apache.catalina.Globals;
 +import org.apache.catalina.Host;
 +import org.apache.catalina.Valve;
  import org.apache.catalina.connector.Request;
  import org.apache.coyote.ActionCode;
  import org.apache.coyote.AsyncContextCallback;
 @@ -128,8 +130,8 @@ public class AsyncContextImpl implements
  ActionCode.ASYNC_IS_TIMINGOUT, result);
  return !result.get();
  } else {
 -// No listeners, container calls complete
 -complete();
 +// No listeners, trigger error handling
 +return false;
  }

  } finally {
 @@ -372,6 +374,23 @@ public class AsyncContextImpl implements
  listener.getClass().getName() + ], ioe);
  }
  }
 
 
 The spec in 2.3.3.3 says If none of the listeners called
 AsyncContext.complete or any of the AsyncContext.dispatch methods,
 then perform an error dispatch
 
 As far as I see, the code below is executed unconditionally, but the
 spec says that it has to be executed only if the listeners did not do
 the calls

The code below is part of AsyncContextImpl.setErrorState() and that is
only called from timeout() if there is no configured listener that calls
complete() or dispatch().

Aside: Filip has reused setErrorState() for the Servlet 3.1 async work
in trunk. It looks reasonable to me but we'll need to wait for the final
3.1 spec to see if it is consistent with the changes I made.

Mark

 
 +
 +// SRV.2.3.3.3 (search for error dispatch)
 +if (servletResponse instanceof HttpServletResponse) {
 +((HttpServletResponse) servletResponse).setStatus(
 +HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
 +}
 +
 +Host host = (Host) context.getParent();
 +Valve stdHostValve = host.getPipeline().getBasic();
 +if (stdHostValve instanceof StandardHostValve) {
 +((StandardHostValve) stdHostValve).throwable(request,
 +request.getResponse(), t);
 +}
 +
 +if (isStarted()  !request.isAsyncDispatching()) {
 +complete();
 +}
  }



 Modified: 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
 URL: 
 http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java?rev=1408152r1=1408151r2=1408152view=diff

Re: svn commit: r1408152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ test/org/apache/catalina/core/ webapps/docs/

2012-11-13 Thread Konstantin Kolinko

2012/11/13 Mark Thomas ma...@apache.org:
 On 13/11/2012 00:57, Konstantin Kolinko wrote:
 2012/11/12  ma...@apache.org:
 Author: markt
 Date: Sun Nov 11 23:35:41 2012
 New Revision: 1408152

 URL: http://svn.apache.org/viewvc?rev=1408152view=rev
 Log:
 Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54123
 There are two things going on here:
 1. The reported bug. If there is a async timeout and no async listeners, 
 trigger a 500 response.
 2. Implement error dispatch. This is used a couple of times in the spec 
 without any definition. The implication from the part of the spec quoted in 
 the bug report is:
- The standard error page mechanism should be used to identify the page
- An async request that has been started should be left in async mode 
 when forwarding to the error page
- The error page may call complete() or dispatch()
 This commit hooks into the StandardHostValve to access the error page 
 mechanism. I could have copied and pasted but I preferred the dependency on 
 StandardHostValve
 Because the error page may do a dispatch(), need to ensure that when 
 running the dispatch(), the error page mechanism is not triggered a second 
 time.
 Depending on what emerges running the full unit tests and the TCK, I mat 
 still decide to copy the error page code to AsyncContextImpl

 Modified:
 tomcat/tc7.0.x/trunk/   (props changed)
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
 tomcat/tc7.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java
 
 tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
 tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

 Propchange: tomcat/tc7.0.x/trunk/
 --
   Merged /tomcat/trunk:r1408148

 Modified: 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
 URL: 
 http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=1408152r1=1408151r2=1408152view=diff
 ==
 --- 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
 (original)
 +++ 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
 Sun Nov 11 23:35:41 2012
 @@ -41,6 +41,8 @@ import javax.servlet.http.HttpServletRes
  import org.apache.catalina.AsyncDispatcher;
  import org.apache.catalina.Context;
  import org.apache.catalina.Globals;
 +import org.apache.catalina.Host;
 +import org.apache.catalina.Valve;
  import org.apache.catalina.connector.Request;
  import org.apache.coyote.ActionCode;
  import org.apache.coyote.AsyncContextCallback;
 @@ -128,8 +130,8 @@ public class AsyncContextImpl implements
  ActionCode.ASYNC_IS_TIMINGOUT, result);
  return !result.get();
  } else {
 -// No listeners, container calls complete
 -complete();
 +// No listeners, trigger error handling
 +return false;
  }

  } finally {
 @@ -372,6 +374,23 @@ public class AsyncContextImpl implements
  listener.getClass().getName() + ], ioe);
  }
  }


 The spec in 2.3.3.3 says If none of the listeners called
 AsyncContext.complete or any of the AsyncContext.dispatch methods,
 then perform an error dispatch

 As far as I see, the code below is executed unconditionally, but the
 spec says that it has to be executed only if the listeners did not do
 the calls

 The code below is part of AsyncContextImpl.setErrorState() and that is
 only called from timeout() if there is no configured listener that calls
 complete() or dispatch().


I am not convinced.

I do not see other places where AsyncListenerWrapper.fireOnError(..)
were called. So it is the only place that calls onError() on those
listeners.

Where is it checking that none of the listeners called
AsyncContext.complete or any of the AsyncContext.dispatch methods in
their onError() methods?  Why does it go on to call
StandardHostValve.throwable(,,) in case the error has already been
handled by the listener?

SRV.2.3.3.3
Points i and ii on page 38 of 230. (numbered page 16 at the
bottom of the page).
servlet-3_0-mrel-spec.pdf



 +
 +// SRV.2.3.3.3 (search for error dispatch)
 +if (servletResponse instanceof HttpServletResponse) {
 +((HttpServletResponse) servletResponse).setStatus(
 +HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
 +}
 +
 +Host host = (Host) context.getParent();
 +Valve stdHostValve = host.getPipeline().getBasic();
 +if (stdHostValve instanceof StandardHostValve) {
 +((StandardHostValve) stdHostValve).throwable(request,
 +

Re: svn commit: r1408152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ test/org/apache/catalina/core/ webapps/docs/

2012-11-13 Thread Mark Thomas

On 13/11/2012 14:06, Konstantin Kolinko wrote:
 2012/11/13 Mark Thomas ma...@apache.org:
 On 13/11/2012 00:57, Konstantin Kolinko wrote:
 2012/11/12  ma...@apache.org:
 Author: markt
 Date: Sun Nov 11 23:35:41 2012
 New Revision: 1408152

 URL: http://svn.apache.org/viewvc?rev=1408152view=rev
 Log:
 Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54123
 There are two things going on here:
 1. The reported bug. If there is a async timeout and no async listeners, 
 trigger a 500 response.
 2. Implement error dispatch. This is used a couple of times in the spec 
 without any definition. The implication from the part of the spec quoted 
 in the bug report is:
- The standard error page mechanism should be used to identify the page
- An async request that has been started should be left in async mode 
 when forwarding to the error page
- The error page may call complete() or dispatch()
 This commit hooks into the StandardHostValve to access the error page 
 mechanism. I could have copied and pasted but I preferred the dependency 
 on StandardHostValve
 Because the error page may do a dispatch(), need to ensure that when 
 running the dispatch(), the error page mechanism is not triggered a second 
 time.
 Depending on what emerges running the full unit tests and the TCK, I mat 
 still decide to copy the error page code to AsyncContextImpl

 Modified:
 tomcat/tc7.0.x/trunk/   (props changed)
 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
 tomcat/tc7.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java
 
 tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
 tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

 Propchange: tomcat/tc7.0.x/trunk/
 --
   Merged /tomcat/trunk:r1408148

 Modified: 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
 URL: 
 http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=1408152r1=1408151r2=1408152view=diff
 ==
 --- 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
 (original)
 +++ 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
 Sun Nov 11 23:35:41 2012
 @@ -41,6 +41,8 @@ import javax.servlet.http.HttpServletRes
  import org.apache.catalina.AsyncDispatcher;
  import org.apache.catalina.Context;
  import org.apache.catalina.Globals;
 +import org.apache.catalina.Host;
 +import org.apache.catalina.Valve;
  import org.apache.catalina.connector.Request;
  import org.apache.coyote.ActionCode;
  import org.apache.coyote.AsyncContextCallback;
 @@ -128,8 +130,8 @@ public class AsyncContextImpl implements
  ActionCode.ASYNC_IS_TIMINGOUT, result);
  return !result.get();
  } else {
 -// No listeners, container calls complete
 -complete();
 +// No listeners, trigger error handling
 +return false;
  }

  } finally {
 @@ -372,6 +374,23 @@ public class AsyncContextImpl implements
  listener.getClass().getName() + ], ioe);
  }
  }


 The spec in 2.3.3.3 says If none of the listeners called
 AsyncContext.complete or any of the AsyncContext.dispatch methods,
 then perform an error dispatch

 As far as I see, the code below is executed unconditionally, but the
 spec says that it has to be executed only if the listeners did not do
 the calls

 The code below is part of AsyncContextImpl.setErrorState() and that is
 only called from timeout() if there is no configured listener that calls
 complete() or dispatch().

 
 I am not convinced.
 
 I do not see other places where AsyncListenerWrapper.fireOnError(..)
 were called. So it is the only place that calls onError() on those
 listeners.
 
 Where is it checking that none of the listeners called
 AsyncContext.complete or any of the AsyncContext.dispatch methods in
 their onError() methods?  Why does it go on to call
 StandardHostValve.throwable(,,) in case the error has already been
 handled by the listener?
 
 SRV.2.3.3.3
 Points i and ii on page 38 of 230. (numbered page 16 at the
 bottom of the page).
 servlet-3_0-mrel-spec.pdf

OK. I see where you are coming from. This needs some more work.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1408152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ test/org/apache/catalina/core/ webapps/docs/

2012-11-12 Thread Konstantin Kolinko

2012/11/12  ma...@apache.org:
 Author: markt
 Date: Sun Nov 11 23:35:41 2012
 New Revision: 1408152

 URL: http://svn.apache.org/viewvc?rev=1408152view=rev
 Log:
 Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54123
 There are two things going on here:
 1. The reported bug. If there is a async timeout and no async listeners, 
 trigger a 500 response.
 2. Implement error dispatch. This is used a couple of times in the spec 
 without any definition. The implication from the part of the spec quoted in 
 the bug report is:
- The standard error page mechanism should be used to identify the page
- An async request that has been started should be left in async mode when 
 forwarding to the error page
- The error page may call complete() or dispatch()
 This commit hooks into the StandardHostValve to access the error page 
 mechanism. I could have copied and pasted but I preferred the dependency on 
 StandardHostValve
 Because the error page may do a dispatch(), need to ensure that when running 
 the dispatch(), the error page mechanism is not triggered a second time.
 Depending on what emerges running the full unit tests and the TCK, I mat 
 still decide to copy the error page code to AsyncContextImpl

 Modified:
 tomcat/tc7.0.x/trunk/   (props changed)
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
 tomcat/tc7.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java
 
 tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
 tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

 Propchange: tomcat/tc7.0.x/trunk/
 --
   Merged /tomcat/trunk:r1408148

 Modified: 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
 URL: 
 http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=1408152r1=1408151r2=1408152view=diff
 ==
 --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
 (original)
 +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
 Sun Nov 11 23:35:41 2012
 @@ -41,6 +41,8 @@ import javax.servlet.http.HttpServletRes
  import org.apache.catalina.AsyncDispatcher;
  import org.apache.catalina.Context;
  import org.apache.catalina.Globals;
 +import org.apache.catalina.Host;
 +import org.apache.catalina.Valve;
  import org.apache.catalina.connector.Request;
  import org.apache.coyote.ActionCode;
  import org.apache.coyote.AsyncContextCallback;
 @@ -128,8 +130,8 @@ public class AsyncContextImpl implements
  ActionCode.ASYNC_IS_TIMINGOUT, result);
  return !result.get();
  } else {
 -// No listeners, container calls complete
 -complete();
 +// No listeners, trigger error handling
 +return false;
  }

  } finally {
 @@ -372,6 +374,23 @@ public class AsyncContextImpl implements
  listener.getClass().getName() + ], ioe);
  }
  }


The spec in 2.3.3.3 says If none of the listeners called
AsyncContext.complete or any of the AsyncContext.dispatch methods,
then perform an error dispatch

As far as I see, the code below is executed unconditionally, but the
spec says that it has to be executed only if the listeners did not do
the calls

 +
 +// SRV.2.3.3.3 (search for error dispatch)
 +if (servletResponse instanceof HttpServletResponse) {
 +((HttpServletResponse) servletResponse).setStatus(
 +HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
 +}
 +
 +Host host = (Host) context.getParent();
 +Valve stdHostValve = host.getPipeline().getBasic();
 +if (stdHostValve instanceof StandardHostValve) {
 +((StandardHostValve) stdHostValve).throwable(request,
 +request.getResponse(), t);
 +}
 +
 +if (isStarted()  !request.isAsyncDispatching()) {
 +complete();
 +}
  }



 Modified: 
 tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
 URL: 
 http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java?rev=1408152r1=1408151r2=1408152view=diff
 ==
 --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java 
 (original)
 +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java 
 Sun Nov 11 23:35:41 2012
 @@ -161,6 +161,9 @@ final class StandardHostValve extends Va
  // If a request init listener throws an exception, the request is
  // aborted

svn commit: r1408152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ test/org/apache/catalina/core/ webapps/docs/

2012-11-11 Thread markt

Author: markt
Date: Sun Nov 11 23:35:41 2012
New Revision: 1408152

URL: http://svn.apache.org/viewvc?rev=1408152view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54123
There are two things going on here:
1. The reported bug. If there is a async timeout and no async listeners, 
trigger a 500 response.
2. Implement error dispatch. This is used a couple of times in the spec 
without any definition. The implication from the part of the spec quoted in the 
bug report is:
   - The standard error page mechanism should be used to identify the page
   - An async request that has been started should be left in async mode when 
forwarding to the error page
   - The error page may call complete() or dispatch()
This commit hooks into the StandardHostValve to access the error page 
mechanism. I could have copied and pasted but I preferred the dependency on 
StandardHostValve
Because the error page may do a dispatch(), need to ensure that when running 
the dispatch(), the error page mechanism is not triggered a second time.
Depending on what emerges running the full unit tests and the TCK, I mat still 
decide to copy the error page code to AsyncContextImpl

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
tomcat/tc7.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java
tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1408148

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=1408152r1=1408151r2=1408152view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
Sun Nov 11 23:35:41 2012
@@ -41,6 +41,8 @@ import javax.servlet.http.HttpServletRes
 import org.apache.catalina.AsyncDispatcher;
 import org.apache.catalina.Context;
 import org.apache.catalina.Globals;
+import org.apache.catalina.Host;
+import org.apache.catalina.Valve;
 import org.apache.catalina.connector.Request;
 import org.apache.coyote.ActionCode;
 import org.apache.coyote.AsyncContextCallback;
@@ -128,8 +130,8 @@ public class AsyncContextImpl implements
 ActionCode.ASYNC_IS_TIMINGOUT, result);
 return !result.get();
 } else {
-// No listeners, container calls complete
-complete();
+// No listeners, trigger error handling
+return false;
 }
 
 } finally {
@@ -372,6 +374,23 @@ public class AsyncContextImpl implements
 listener.getClass().getName() + ], ioe);
 }
 }
+
+// SRV.2.3.3.3 (search for error dispatch)
+if (servletResponse instanceof HttpServletResponse) {
+((HttpServletResponse) servletResponse).setStatus(
+HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
+}
+
+Host host = (Host) context.getParent();
+Valve stdHostValve = host.getPipeline().getBasic();
+if (stdHostValve instanceof StandardHostValve) {
+((StandardHostValve) stdHostValve).throwable(request,
+request.getResponse(), t);
+}
+
+if (isStarted()  !request.isAsyncDispatching()) {
+complete();
+}
 }
 
 

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java?rev=1408152r1=1408151r2=1408152view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java 
Sun Nov 11 23:35:41 2012
@@ -161,6 +161,9 @@ final class StandardHostValve extends Va
 // If a request init listener throws an exception, the request is
 // aborted
 boolean asyncAtStart = request.isAsync(); 
+// An async error page may dispatch to another resource. This flag 
helps
+// ensure an infinite error handling loop is not entered
+boolean errorAtStart = response.isError();
 if (asyncAtStart || context.fireRequestInitEvent(request)) {
 
 // Ask this Context to process this request
@@ -168,29 +171,37 @@ final class StandardHostValve extends Va

Re: svn commit: r1408152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ test/org/apache/catalina/core/ webapps/docs/

Re: svn commit: r1408152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ test/org/apache/catalina/core/ webapps/docs/

Re: svn commit: r1408152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ test/org/apache/catalina/core/ webapps/docs/

Re: svn commit: r1408152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ test/org/apache/catalina/core/ webapps/docs/

svn commit: r1408152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ test/org/apache/catalina/core/ webapps/docs/

5 matches

Site Navigation

Mail list logo

Footer information