Re: svn commit: r1556071 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java

2014-01-08 Thread Mark Thomas
On 06/01/2014 23:40, r...@apache.org wrote: Author: remm Date: Mon Jan 6 23:40:32 2014 New Revision: 1556071 URL: http://svn.apache.org/r1556071 Log: Avoid NPE if the write listener is called once immediately after being set, even if no data was written (= the app doesn't send any

Re: svn commit: r1556071 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java

2014-01-08 Thread Rémy Maucherat
2014/1/8 Mark Thomas ma...@apache.org Tomcat only does this if the WriteListener is set via the CoyoteOutputStream. It does not do it if HTTP upgrade is used (which uses a lighter-weight ServletOutputStream). That looks like a bug that needs fixing. Yes, I saw after my commit there was code

svn commit: r1556071 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java

2014-01-06 Thread remm
Author: remm Date: Mon Jan 6 23:40:32 2014 New Revision: 1556071 URL: http://svn.apache.org/r1556071 Log: Avoid NPE if the write listener is called once immediately after being set, even if no data was written (= the app doesn't send any message during the init of the connection). I don't