svn commit: r1560702 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsRemoteEndpointImplBase.java WsSession.java pojo/PojoEndpointBase.java

2014-01-23 Thread remm
Author: remm Date: Thu Jan 23 14:42:21 2014 New Revision: 1560702 URL: http://svn.apache.org/r1560702 Log: - Call onClose before actually closing anything (sending a close message closes the endpoint). - If onClose throws an exception, call onError. - After using a blocking send, clear the

Re: svn commit: r1560702 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsRemoteEndpointImplBase.java WsSession.java pojo/PojoEndpointBase.java

2014-01-23 Thread Mark Thomas
On 23/01/2014 14:42, r...@apache.org wrote: Author: remm Date: Thu Jan 23 14:42:21 2014 New Revision: 1560702 URL: http://svn.apache.org/r1560702 Log: - Call onClose before actually closing anything (sending a close message closes the endpoint). -1 (veto) for a specification violation

Re: svn commit: r1560702 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsRemoteEndpointImplBase.java WsSession.java pojo/PojoEndpointBase.java

2014-01-23 Thread Rémy Maucherat
2014/1/23 Mark Thomas ma...@apache.org - Call onClose before actually closing anything (sending a close message closes the endpoint). -1 (veto) for a specification violation Section 2.1.5 requires that: the implementation must attempt to send the websocket close frame prior to calling

Re: svn commit: r1560702 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsRemoteEndpointImplBase.java WsSession.java pojo/PojoEndpointBase.java

2014-01-23 Thread Mark Thomas
On 23/01/2014 15:01, Rémy Maucherat wrote: 2014/1/23 Mark Thomas ma...@apache.org - Call onClose before actually closing anything (sending a close message closes the endpoint). -1 (veto) for a specification violation Section 2.1.5 requires that: the implementation must attempt to send

Re: svn commit: r1560702 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsRemoteEndpointImplBase.java WsSession.java pojo/PojoEndpointBase.java

2014-01-23 Thread Rémy Maucherat
2014/1/23 Mark Thomas ma...@apache.org I'd need to go back and check the archives but the I think the expectation from the EG was that onClose() would be used to clean up resources rather than anything else. It is always possible that I have misunderstood the intention of the spec here but