svn commit: r1710517 - /tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java

[violetagg]

Author: violetagg
Date: Mon Oct 26 07:22:55 2015
New Revision: 1710517

URL: http://svn.apache.org/viewvc?rev=1710517&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58537
ExtendedAccessLogValve inner AccessLogElement classes are made static. Patch 
provided by Anthony Whitford.

Modified:
    tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java

Modified: 
tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java?rev=1710517&r1=1710516&r2=1710517&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java 
Mon Oct 26 07:22:55 2015
@@ -258,7 +258,7 @@ public class ExtendedAccessLogValve exte
         }
     }
 
-    protected class RequestHeaderElement implements AccessLogElement {
+    protected static class RequestHeaderElement implements AccessLogElement {
         private final String header;
 
         public RequestHeaderElement(String header) {
@@ -271,7 +271,7 @@ public class ExtendedAccessLogValve exte
         }
     }
 
-    protected class ResponseHeaderElement implements AccessLogElement {
+    protected static class ResponseHeaderElement implements AccessLogElement {
         private final String header;
 
         public ResponseHeaderElement(String header) {
@@ -285,7 +285,7 @@ public class ExtendedAccessLogValve exte
         }
     }
 
-    protected class ServletContextElement implements AccessLogElement {
+    protected static class ServletContextElement implements AccessLogElement {
         private final String attribute;
 
         public ServletContextElement(String attribute) {
@@ -299,7 +299,7 @@ public class ExtendedAccessLogValve exte
         }
     }
 
-    protected class CookieElement implements AccessLogElement {
+    protected static class CookieElement implements AccessLogElement {
         private final String name;
 
         public CookieElement(String name) {
@@ -320,7 +320,7 @@ public class ExtendedAccessLogValve exte
     /**
      * write a specific response header - x-O(xxx)
      */
-    protected class ResponseAllHeaderElement implements AccessLogElement {
+    protected static class ResponseAllHeaderElement implements 
AccessLogElement {
         private final String header;
 
         public ResponseAllHeaderElement(String header) {
@@ -351,7 +351,7 @@ public class ExtendedAccessLogValve exte
         }
     }
 
-    protected class RequestAttributeElement implements AccessLogElement {
+    protected static class RequestAttributeElement implements AccessLogElement 
{
         private final String attribute;
 
         public RequestAttributeElement(String attribute) {
@@ -365,7 +365,7 @@ public class ExtendedAccessLogValve exte
         }
     }
 
-    protected class SessionAttributeElement implements AccessLogElement {
+    protected static class SessionAttributeElement implements AccessLogElement 
{
         private final String attribute;
 
         public SessionAttributeElement(String attribute) {
@@ -384,7 +384,7 @@ public class ExtendedAccessLogValve exte
         }
     }
 
-    protected class RequestParameterElement implements AccessLogElement {
+    protected static class RequestParameterElement implements AccessLogElement 
{
         private final String parameter;
 
         public RequestParameterElement(String parameter) {



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org