Author: violetagg
Date: Mon Oct 26 20:39:29 2015
New Revision: 1710689

URL: http://svn.apache.org/viewvc?rev=1710689&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58544,58541
Use Integer.toString(int) instead of Integer.valueOf(int).toString() when only 
a string representation of a primitive is needed. Based on a patch provided by 
Anthony Whitford.

Modified:
    tomcat/trunk/java/org/apache/catalina/filters/RequestDumperFilter.java
    tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java

Modified: tomcat/trunk/java/org/apache/catalina/filters/RequestDumperFilter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/RequestDumperFilter.java?rev=1710689&r1=1710688&r2=1710689&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/filters/RequestDumperFilter.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/filters/RequestDumperFilter.java Mon 
Oct 26 20:39:29 2015
@@ -109,7 +109,7 @@ public class RequestDumperFilter extends
 
         doLog(" characterEncoding", request.getCharacterEncoding());
         doLog("     contentLength",
-                Integer.valueOf(request.getContentLength()).toString());
+                Integer.toString(request.getContentLength()));
         doLog("       contentType", request.getContentType());
 
         if (hRequest == null) {
@@ -187,7 +187,7 @@ public class RequestDumperFilter extends
         doLog("            scheme", request.getScheme());
         doLog("        serverName", request.getServerName());
         doLog("        serverPort",
-                Integer.valueOf(request.getServerPort()).toString());
+                Integer.toString(request.getServerPort()));
 
         if (hRequest == null) {
             doLog("       servletPath", NON_HTTP_REQ_MSG);
@@ -236,7 +236,7 @@ public class RequestDumperFilter extends
             doLog("        remoteUser", NON_HTTP_RES_MSG);
         } else {
             doLog("            status",
-                    Integer.valueOf(hResponse.getStatus()).toString());
+                    Integer.toString(hResponse.getStatus()));
         }
 
         doLog("END TIME          ", getTimestamp());

Modified: tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java?rev=1710689&r1=1710688&r2=1710689&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java Mon Oct 26 
20:39:29 2015
@@ -1080,7 +1080,7 @@ public final class CGIServlet extends Ht
              */
             int contentLength = req.getContentLength();
             String sContentLength = (contentLength <= 0 ? "" :
-                (Integer.valueOf(contentLength)).toString());
+                Integer.toString(contentLength));
             envp.put("CONTENT_LENGTH", sContentLength);
 
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to