Author: markt Date: Sat Oct 14 15:16:49 2017 New Revision: 1812189 URL: http://svn.apache.org/viewvc?rev=1812189&view=rev Log: Fix a handful of SpotBugs warnings
Modified: tomcat/trunk/java/org/apache/tomcat/util/threads/TaskQueue.java tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFilter.java tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/java/org/apache/tomcat/util/threads/TaskQueue.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/threads/TaskQueue.java?rev=1812189&r1=1812188&r2=1812189&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/threads/TaskQueue.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/threads/TaskQueue.java Sat Oct 14 15:16:49 2017 @@ -32,7 +32,7 @@ public class TaskQueue extends LinkedBlo private static final long serialVersionUID = 1L; - private volatile ThreadPoolExecutor parent = null; + private transient volatile ThreadPoolExecutor parent = null; // No need to be volatile. This is written and read in a single thread // (when stopping a context and firing the listeners) Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFilter.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFilter.java?rev=1812189&r1=1812188&r2=1812189&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFilter.java (original) +++ tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFilter.java Sat Oct 14 15:16:49 2017 @@ -33,7 +33,7 @@ public class WsFilter extends GenericFil private static final long serialVersionUID = 1L; - private WsServerContainer sc; + private transient WsServerContainer sc; @Override Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1812189&r1=1812188&r2=1812189&view=diff ============================================================================== --- tomcat/trunk/res/findbugs/filter-false-positives.xml (original) +++ tomcat/trunk/res/findbugs/filter-false-positives.xml Sat Oct 14 15:16:49 2017 @@ -981,6 +981,11 @@ <Bug code="SF" /> </Match> <Match> + <!-- No performance issue as there is no DNS resolution --> + <Class name="org.apache.tomcat.util.scan.StandardJarScanner" /> + <Bug pattern="DMI_COLLECTION_OF_URLS" /> + </Match> + <Match> <!-- Yes the simple name is the same as the super class. Accept it. --> <Class name="org.apache.tomcat.util.threads.ThreadPoolExecutor" /> <Bug code="Nm" /> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org