Author: markt Date: Fri Apr 20 12:34:46 2018 New Revision: 1829649 URL: http://svn.apache.org/viewvc?rev=1829649&view=rev Log: Update ECJ to 4.7.3a Note: - this is identical to 3.13.102 from Maven Central - minimum Java versions for 4.7.x is Java 8 (hence Tomcat 9 only and not back-ported) - the constants for Java 9 have changed
This will allow formal support for Java 10 (although the class file format is identical to Java 9) Modified: tomcat/trunk/build.properties.default tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java tomcat/trunk/res/ide-support/eclipse/eclipse.classpath tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties tomcat/trunk/res/ide-support/netbeans/project.xml tomcat/trunk/res/maven/tomcat-embed-jasper.pom tomcat/trunk/res/maven/tomcat-jasper.pom tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1829649&r1=1829648&r2=1829649&view=diff ============================================================================== --- tomcat/trunk/build.properties.default (original) +++ tomcat/trunk/build.properties.default Fri Apr 20 12:34:46 2018 @@ -115,10 +115,10 @@ wsdl4j-lib.home=${base.path}/wsdl4j-${ws wsdl4j-lib.loc=${base-maven.loc}/wsdl4j/wsdl4j/${wsdl4j-lib.version}/wsdl4j-${wsdl4j-lib.version}.jar wsdl4j-lib.jar=${wsdl4j-lib.home}/wsdl4j-${wsdl4j-lib.version}.jar -# ----- Eclipse JDT, version 4.5.1 or later -----# +# ----- Eclipse JDT, version 4.7 or later -----# # See https://wiki.apache.org/tomcat/JDTCoreBatchCompiler before updating -jdt.version=4.6.3 -jdt.release=R-4.6.3-201703010400 +jdt.version=4.7.3a +jdt.release=R-4.7.3a-201803300640 jdt.home=${base.path}/ecj-${jdt.version} jdt.jar=${jdt.home}/ecj-${jdt.version}.jar # The download will be moved to the archive area eventually. We are taking care of that in advance. Modified: tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java?rev=1829649&r1=1829648&r2=1829649&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java (original) +++ tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java Fri Apr 20 12:34:46 2018 @@ -313,9 +313,11 @@ public class JDTCompiler extends org.apa } else if(opt.equals("1.8")) { settings.put(CompilerOptions.OPTION_Source, CompilerOptions.VERSION_1_8); - } else if(opt.equals("1.9")) { + // Version format changed from Java 9 onwards. + // Support old format that was used in EA implementation as well + } else if(opt.equals("9") || opt.equals("1.9")) { settings.put(CompilerOptions.OPTION_Source, - CompilerOptions.VERSION_1_9); + CompilerOptions.VERSION_9); } else { log.warn("Unknown source VM " + opt + " ignored."); settings.put(CompilerOptions.OPTION_Source, @@ -362,11 +364,13 @@ public class JDTCompiler extends org.apa CompilerOptions.VERSION_1_8); settings.put(CompilerOptions.OPTION_Compliance, CompilerOptions.VERSION_1_8); - } else if(opt.equals("1.9")) { + // Version format changed from Java 9 onwards. + // Support old format that was used in EA implementation as well + } else if(opt.equals("9") || opt.equals("1.9")) { settings.put(CompilerOptions.OPTION_TargetPlatform, - CompilerOptions.VERSION_1_9); + CompilerOptions.VERSION_9); settings.put(CompilerOptions.OPTION_Compliance, - CompilerOptions.VERSION_1_9); + CompilerOptions.VERSION_9); } else { log.warn("Unknown target VM " + opt + " ignored."); settings.put(CompilerOptions.OPTION_TargetPlatform, Modified: tomcat/trunk/res/ide-support/eclipse/eclipse.classpath URL: http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/eclipse/eclipse.classpath?rev=1829649&r1=1829648&r2=1829649&view=diff ============================================================================== --- tomcat/trunk/res/ide-support/eclipse/eclipse.classpath (original) +++ tomcat/trunk/res/ide-support/eclipse/eclipse.classpath Fri Apr 20 12:34:46 2018 @@ -24,7 +24,7 @@ <classpathentry kind="var" path="ANT_HOME/lib/ant.jar"/> <classpathentry kind="var" path="TOMCAT_LIBS_BASE/jaxrpc-1.1-rc4/geronimo-spec-jaxrpc-1.1-rc4.jar"/> <classpathentry kind="var" path="TOMCAT_LIBS_BASE/wsdl4j-1.6.2/wsdl4j-1.6.2.jar"/> - <classpathentry kind="var" path="TOMCAT_LIBS_BASE/ecj-4.6.3/ecj-4.6.3.jar"/> + <classpathentry kind="var" path="TOMCAT_LIBS_BASE/ecj-4.7.3a/ecj-4.7.3a.jar"/> <classpathentry kind="var" path="TOMCAT_LIBS_BASE/easymock-3.2/easymock-3.2.jar"/> <classpathentry kind="var" path="TOMCAT_LIBS_BASE/hamcrest-1.3/hamcrest-core-1.3.jar"/> <classpathentry kind="var" path="TOMCAT_LIBS_BASE/cglib-2.2.3/cglib-nodep-2.2.3.jar"/> Modified: tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties?rev=1829649&r1=1829648&r2=1829649&view=diff ============================================================================== --- tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties (original) +++ tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties Fri Apr 20 12:34:46 2018 @@ -37,7 +37,7 @@ nb-test.io-method=org.apache.coyote.http # it is not possible to retrieve the classpaths from the build to # use in the NetBeans targets, so they must be explicitly declared -nb-test.classpath=${test.classes}:${tomcat.build}/webapps/examples/WEB-INF/classes:${base.path}/junit-4.11/junit-4.11.jar:${base.path}/easymock-3.2/easymock-3.2.jar:${base.path}/hamcrest-1.3/hamcrest-core-1.3.jar:${base.path}/ecj-4.6.3/ecj-4.6.3.jar:${tomcat.classes} +nb-test.classpath=${test.classes}:${tomcat.build}/webapps/examples/WEB-INF/classes:${base.path}/junit-4.11/junit-4.11.jar:${base.path}/easymock-3.2/easymock-3.2.jar:${base.path}/hamcrest-1.3/hamcrest-core-1.3.jar:${base.path}/ecj-4.7.3a/ecj-4.7.3a.jar:${tomcat.classes} # Extra properties used by the Tomcat project additional NetBeans targets. Modified: tomcat/trunk/res/ide-support/netbeans/project.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/netbeans/project.xml?rev=1829649&r1=1829648&r2=1829649&view=diff ============================================================================== --- tomcat/trunk/res/ide-support/netbeans/project.xml (original) +++ tomcat/trunk/res/ide-support/netbeans/project.xml Fri Apr 20 12:34:46 2018 @@ -178,7 +178,7 @@ --> <compilation-unit> <package-root>java</package-root> - <classpath mode="compile">${base.path}/jaxrpc-1.1-rc4/geronimo-spec-jaxrpc-1.1-rc4.jar:${base.path}/wsdl4j-1.6.2/wsdl4j-1.6.2.jar:${base.path}/ecj-4.6.3/ecj-4.6.3.jar:${ant.includes}/</classpath> + <classpath mode="compile">${base.path}/jaxrpc-1.1-rc4/geronimo-spec-jaxrpc-1.1-rc4.jar:${base.path}/wsdl4j-1.6.2/wsdl4j-1.6.2.jar:${base.path}/ecj-4.7.3a/ecj-4.7.3a.jar:${ant.includes}/</classpath> <source-level>1.7</source-level> </compilation-unit> <compilation-unit> Modified: tomcat/trunk/res/maven/tomcat-embed-jasper.pom URL: http://svn.apache.org/viewvc/tomcat/trunk/res/maven/tomcat-embed-jasper.pom?rev=1829649&r1=1829648&r2=1829649&view=diff ============================================================================== --- tomcat/trunk/res/maven/tomcat-embed-jasper.pom (original) +++ tomcat/trunk/res/maven/tomcat-embed-jasper.pom Fri Apr 20 12:34:46 2018 @@ -45,7 +45,7 @@ <dependency> <groupId>org.eclipse.jdt</groupId> <artifactId>ecj</artifactId> - <version>3.12.3</version> + <version>3.13.102</version> </dependency> </dependencies> </project> Modified: tomcat/trunk/res/maven/tomcat-jasper.pom URL: http://svn.apache.org/viewvc/tomcat/trunk/res/maven/tomcat-jasper.pom?rev=1829649&r1=1829648&r2=1829649&view=diff ============================================================================== --- tomcat/trunk/res/maven/tomcat-jasper.pom (original) +++ tomcat/trunk/res/maven/tomcat-jasper.pom Fri Apr 20 12:34:46 2018 @@ -57,7 +57,7 @@ <dependency> <groupId>org.eclipse.jdt</groupId> <artifactId>ecj</artifactId> - <version>3.12.3</version> + <version>3.13.102</version> </dependency> <dependency> <groupId>org.apache.tomcat</groupId> Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1829649&r1=1829648&r2=1829649&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Fri Apr 20 12:34:46 2018 @@ -84,6 +84,13 @@ </fix> </changelog> </subsection> + <subsection name="Jasper"> + <changelog> + <update> + Update the Eclipse Compiler for Java to 4.7.3a. (markt) + </update> + </changelog> + </subsection> </section> <section name="Tomcat 9.0.7 (markt)" rtext="2018-04-07"> <subsection name="Catalina"> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org