Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-19 Thread Mladen Turk
Filip Hanik - Dev Lists wrote: Let's keep SSLEngine: it's explicit, and it works. not really, this wouldn't work Connector port=8444 scheme=https secure=true protocol=org.apache.coyote.http11.Http11AprProtocol SSLEngine=oneengine/ Connector port=8555 scheme=https secure=true

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-19 Thread Remy Maucherat
Mladen Turk wrote: If that is the case the secure=true|false can be used to determine if the transport is ssl or not, and fake the front end handled https/ssl connection. I find that doubtful. I am against such a change right now, since it might restrict usage of the connector for no good

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-19 Thread Mladen Turk
Remy Maucherat wrote: Mladen Turk wrote: If that is the case the secure=true|false can be used to determine if the transport is ssl or not, and fake the front end handled https/ssl connection. I find that doubtful. I am against such a change right now, since it might restrict usage of the

svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread fhanik
Author: fhanik Date: Wed Oct 18 10:10:44 2006 New Revision: 465303 URL: http://svn.apache.org/viewvc?view=revrev=465303 Log: Implemented SSLEngine attribute on the Java HTTP connectors. This allows one to specify secure=true and scheme=https to prevent tomcat from redirecting when using a SSL

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Mladen Turk
[EMAIL PROTECTED] wrote: -ssl = endpoint.getSecure(); +ssl = on.equalsIgnoreCase(endpoint.getSSLEngine()); Like Remy said, anything except Off is acceptable. It can be either On or EngineName (eg, SSLEngine=nuron) Regards, Mladen.

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Filip Hanik - Dev Lists
Mladen Turk wrote: [EMAIL PROTECTED] wrote: -ssl = endpoint.getSecure(); +ssl = on.equalsIgnoreCase(endpoint.getSSLEngine()); Like Remy said, anything except Off is acceptable. It can be either On or EngineName (eg, SSLEngine=nuron) that's for APR, because of if

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Filip Hanik - Dev Lists
Filip Hanik - Dev Lists wrote: Mladen Turk wrote: [EMAIL PROTECTED] wrote: -ssl = endpoint.getSecure(); +ssl = on.equalsIgnoreCase(endpoint.getSSLEngine()); Like Remy said, anything except Off is acceptable. It can be either On or EngineName (eg, SSLEngine=nuron) that's

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Filip Hanik - Dev Lists
Filip Hanik - Dev Lists wrote: Filip Hanik - Dev Lists wrote: Mladen Turk wrote: [EMAIL PROTECTED] wrote: -ssl = endpoint.getSecure(); +ssl = on.equalsIgnoreCase(endpoint.getSSLEngine()); Like Remy said, anything except Off is acceptable. It can be either On or

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Filip Hanik - Dev Lists
Mladen Turk wrote: Filip Hanik - Dev Lists wrote: to eager to press send, that way the connector would have only on/off values, while the actual SSLEngine value neuron would be in the APRLifeCycleListener, much cleaner, and all our connectors become consistent on that value Look, no

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Mladen Turk
Filip Hanik - Dev Lists wrote: no need to get edgy :), your point is well taken. I was edgy? Wasn't my intention. I have two suggestions 1. The SSLEngine attribute should be in the APR lifecycle listener, and not in the connector, since its static, I can't have more than one, so why do I

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Mladen Turk wrote: Filip Hanik - Dev Lists wrote: to eager to press send, that way the connector would have only on/off values, while the actual SSLEngine value neuron would be in the APRLifeCycleListener, much cleaner, and all our connectors become

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: not really, this wouldn't work Connector port=8444 scheme=https secure=true protocol=org.apache.coyote.http11.Http11AprProtocol SSLEngine=oneengine/ Connector port=8555 scheme=https secure=true protocol=org.apache.coyote.http11.Http11AprProtocol