Re: Observer Ordering

2014-03-21 Thread David Blevins
I tend to agree on the I hope we don't need it thought. I'm thinking maybe we don't do either approach. For the large part, there's little difference between public void observe(final @Observes(after=A.class) SimpleEvent event) ..and public void observe(final @Observes AfterSimpleEve

Re: Observer Ordering

2014-03-21 Thread Romain Manni-Bucau
yep both have advantages and drawbacks. One open question for me is Class or String but not int cause first thing you'll do if not the name (or class) is to look for all other adatpers...not efficient. Class makes a forced dependency, String make it optional. ATM I think Class is enough while we do

Re: Observer Ordering

2014-03-21 Thread David Blevins
There are some downsides to reference based approaches as well. A.class: public void observe(final @Observes SimpleEvent event) Z.class: public void observe(final @Observes(after=A.class) SimpleEvent event) If you later want to add B.class or C.class in the middle between A and Z, yo

Re: Observer Ordering

2014-03-21 Thread Romain Manni-Bucau
-1 to index, it is what is in deltaspike, spec etc and it doesn't work by design (see the spec already defined constants). For such an internal thing we know where we want to bind our event so I still think referencing the event is better. Always better to say where you want to be than saying "i w

Observer Ordering

2014-03-21 Thread David Blevins
For Observers maybe we can find another way to achieve OPENEJB-2082 without binding one observer directly to another: public void observe(final @Observes(after = SimpleObserver.class) SimpleEvent event) I can see that creating just as much of a mess as having too many events. Having to sor

Re: Connector Logging

2014-03-21 Thread Romain Manni-Bucau
can you retest now please? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-03-21 18:40 GMT+01:00 David Blevins : > That's from the build. > > mingus:~/work/tomee-trunk 10:

Re: Connector Logging

2014-03-21 Thread David Blevins
That's from the build. mingus:~/work/tomee-trunk 10:39:42 $ wget -q -O - http://ci.apache.org/builders/tomee-trunk-ubuntu/builds/958/steps/test/logs/stdio | grep -c WorkContextHandler 995 On Mar 21, 2014, at 10:07 AM, Romain Manni-Bucau wrote: > anything to reproduce it? > Romain Manni-Buc

Re: Connector Logging

2014-03-21 Thread Romain Manni-Bucau
PS: did you uncomment in conf/logging.properties the line: org.apache.geronimo.level = SEVERE Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-03-21 18:07 GMT+01:00 Romain

Re: Connector Logging

2014-03-21 Thread Romain Manni-Bucau
anything to reproduce it? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-03-21 18:02 GMT+01:00 David Blevins : > Some many releases ago, this started popping up in our lo

Connector Logging

2014-03-21 Thread David Blevins
Some many releases ago, this started popping up in our logs. Eternal gratitude to anyone who might have time to investigate and eliminate :) INFO - Removing non-required WorkContextHandler with no context: org.apache.geronimo.connector.work.TransactionContextHandler@8822a0 INFO - Removing non-r

Re: svn commit: r1579678 - in /tomee/tomee/trunk/server: openejb-cxf-rs/ openejb-rest/src/main/java/org/apache/openejb/server/rest/AfterServicesDeployed.java openejb-rest/src/main/java/org/apache/open

2014-03-21 Thread David Blevins
FYI, definitely the wrong license header on that file :) -David On Mar 20, 2014, at 9:35 AM, Romain Manni-Bucau wrote: > Hi > > maybe last event should be AfterServiceCall(service, appInfo) for all > services or renamed to AfterRESTService > > Side note: please don't add a bunch of events or