Re: TomEE 8 Release Preview

2018-10-08 Thread Romain Manni-Bucau
Le mar. 9 oct. 2018 01:56, Roberto Cortez a écrit : > Romain, you mean here: > > https://github.com/radcortez/tomee/blob/426e0c14fede5ee5907e43e1c46e2fd51c904412/tomee/tomee-catalina/src/main/java/org/apache/tomee/catalina/TomcatWebAppBuilder.java#L1772-L1774? > < >

Re: TomEE 8 Release Preview

2018-10-08 Thread Roberto Cortez
Romain, you mean here: https://github.com/radcortez/tomee/blob/426e0c14fede5ee5907e43e1c46e2fd51c904412/tomee/tomee-catalina/src/main/java/org/apache/tomee/catalina/TomcatWebAppBuilder.java#L1772-L1774?

Re: TomEE 8 Release Preview

2018-10-08 Thread David Blevins
I shot a note out to bval asking of there's a chance of getting a release this week. Assuming that's possible, is there anything standing in our way for putting up a release vote ourselves this week? -David > On Oct 8, 2018, at 8:28 AM, Romain Manni-Bucau wrote: > > one option can be to

[GitHub] tomee pull request #175: [tomee-7.0.x][TOMEE-2249] Fix EclipseLink NPE on in...

2018-10-08 Thread exabrial
Github user exabrial commented on a diff in the pull request: https://github.com/apache/tomee/pull/175#discussion_r223483193 --- Diff: container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/OpenEJBServerPlatform.java --- @@ -26,13 +27,14 @@

[GitHub] tomee pull request #175: [tomee-7.0.x][TOMEE-2249] Fix EclipseLink NPE on in...

2018-10-08 Thread rmannibucau
Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/175#discussion_r223478552 --- Diff: container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/OpenEJBServerPlatform.java --- @@ -26,13 +27,14

[GitHub] tomee pull request #175: [tomee-7.0.x][TOMEE-2249] Fix EclipseLink NPE on in...

2018-10-08 Thread rmannibucau
Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/175#discussion_r223478337 --- Diff: container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/MBeanOpenEJBRuntimeServices.java --- @@ -0,0

[GitHub] tomee issue #175: [tomee-7.0.x][TOMEE-2249] Fix EclipseLink NPE on init

2018-10-08 Thread exabrial
Github user exabrial commented on the issue: https://github.com/apache/tomee/pull/175 @rmannibucau If this looks good, could you merge? ---

[GitHub] tomee pull request #175: [tomee-7.0.x][TOMEE-2249] Fix EclipseLink NPE on in...

2018-10-08 Thread exabrial
Github user exabrial commented on a diff in the pull request: https://github.com/apache/tomee/pull/175#discussion_r223456172 --- Diff: container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/OpenEJBServerPlatform.java --- @@ -63,4 +65,11 @@

[GitHub] tomee pull request #175: [tomee-7.0.x][TOMEE-2249] Fix EclipseLink NPE on in...

2018-10-08 Thread exabrial
Github user exabrial commented on a diff in the pull request: https://github.com/apache/tomee/pull/175#discussion_r223455236 --- Diff: container/openejb-jpa-integration/src/main/java/org/apache/openejb/jpa/integration/eclipselink/MBeanOpenEJBRuntimeServices.java --- @@ -0,0 +1,26

Re: How about upgrading to Tomcat 8.5.34 for CVE & bug fixes?

2018-10-08 Thread exabrial12
Looks like the other Jonathan beat me to it :) -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: [GitHub] tomee pull request #172: [7.0.x][Tomee-2243] jmx on managed executors

2018-10-08 Thread exabrial12
Hey guys, can this PR get merged into 7.0.x, 7.1.x and 8.0.x? Thanks! -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: How about upgrading to Tomcat 8.5.34 for CVE & bug fixes?

2018-10-08 Thread exabrial12
Alex I'll create a PR for this for 7.0.x. Can you see if TomEE 7.1.x and 8.0.x-SNAPSHOT are affected as well? -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: TomEE 8 Release Preview

2018-10-08 Thread Romain Manni-Bucau
one option can be to start only one webapp here instead of all and hope there is a single one or others are skipped ;) Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: TomEE 8 Release Preview

2018-10-08 Thread Roberto Cortez
Ok, thanks. Can you help to better test it? Cheers, Roberto > On 6 Oct 2018, at 08:26, Romain Manni-Bucau wrote: > > Le sam. 6 oct. 2018 00:30, Roberto Cortez a > écrit : > >> Would something like this work? >> >>