[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on the issue: https://github.com/apache/tomee/pull/262 found few more diamond :) ---

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239968653 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/Files.java --- @@ -245,8 +356,8 @@ public static File mkdirs(final File file) {

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239968576 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java --- @@ -20,18 +20,25 @@ import

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user otaviojava commented on the issue: https://github.com/apache/tomee/pull/262 That is nice @cchacin :) I believe just left the empty javadoc ---

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user otaviojava commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239967594 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/Files.java --- @@ -245,8 +356,8 @@ public static File mkdirs(final File file) {

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user otaviojava commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239967433 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/Files.java --- @@ -245,8 +356,8 @@ public static File mkdirs(final File file) {

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user otaviojava commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239967355 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java --- @@ -20,18 +20,25 @@ import

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user otaviojava commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239967048 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java --- @@ -39,6 +40,12 @@ public ClassLoader run() {

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on the issue: https://github.com/apache/tomee/pull/262 @otaviojava I updated little code, could you please check if it's okej ---

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239955101 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java --- @@ -27,6 +27,11 @@ import java.util.Locale;

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239954854 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java --- @@ -24,14 +24,20 @@

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239954756 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java --- @@ -263,7 +318,7 @@ public ClassLoader

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user otaviojava commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239954220 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java --- @@ -263,7 +318,7 @@ public ClassLoader

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user otaviojava commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239953751 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java --- @@ -24,14 +24,20 @@

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user otaviojava commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r239952984 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java --- @@ -27,6 +27,11 @@ import java.util.Locale;

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

GitHub user cicekhayri opened a pull request: https://github.com/apache/tomee/pull/262 TOMEE-2337 - Code cleanup openejb container loader Added JavaDoc's, use diamond operator, isEmpty method, Switch case statement and added @Override You can merge this pull request into a Git

Optimize string operations

This PR has the goal to optimize String operations in the module container. - The first operation is instead of using the method isEmpty instead of use string.equals("") - The second operation changes a String with one characater to a char type. @Warmup(iterations = 5, time =

[GitHub] tomee pull request #261: Optimize string operations

GitHub user otaviojava opened a pull request: https://github.com/apache/tomee/pull/261 Optimize string operations This PR has the goal to optimize String operations in the module container. * The first operation is instead of using the method isEmpty instead of use

Re: Stabilize TomEE Build

Thanks Dani. That's right, and these two as well: XMLConfigurationTest - XMLConfiguredConstraintValidatorTest On Fri, 7 Dec 2018, 18:20 Daniel Cunha Hey Jon, > > I can help with BVal tests. > If I get it is the BVal test related DuplicateConfigurationTest right? > > > Em sex, 7 de dez de 2018

Re: Fix pom.xml in examples.

Thanks Daniel! Bruno Baptista https://twitter.com/brunobat_ On 07/12/18 18:28, Daniel Cunha wrote: Hi Bruno, Nice... it sounds good to go! +1 Em sex, 7 de dez de 2018 às 08:32, Bruno Baptista escreveu: Hi Folks. Here is the Jira: https://issues.apache.org/jira/browse/TOMEE-2328 And a

Re: Fix pom.xml in examples.

Hi Bruno, Nice... it sounds good to go! +1 Em sex, 7 de dez de 2018 às 08:32, Bruno Baptista escreveu: > Hi Folks. > > Here is the Jira: https://issues.apache.org/jira/browse/TOMEE-2328 > > And a PR: https://github.com/apache/tomee/pull/259 > > The changes should not conflict with ongoing

Re: MicroProfile JWT 1.1

Hi, Just rebased this PR with the MP 2.0 merge, so this one should be good to go too. Cheers, Roberto > On 4 Dec 2018, at 19:18, Roberto Cortez wrote: > > Hey, > > I think we are mostly done with the JWT 1.1 work. At least the TCK is passing > except for two tests with the issue described

Re: Stabilize TomEE Build

Hey Jon, I can help with BVal tests. If I get it is the BVal test related DuplicateConfigurationTest right? Em sex, 7 de dez de 2018 às 14:03, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > Filed a ticket: https://issues.apache.org/jira/browse/TOMEE-2330. We could > ignore the

MicroProfile Samples

Hi folks, We have a parent JIRA issue with a lot of work going on in enriching TomEE samples with MicroProfile: https://jira.apache.org/jira/browse/TOMEE-2285 The following are up for grabs: TOMEE-2336 - MicroProfile OpenTracing Example for

Re: MicroProfile 2.0

Now we just need to merge the JWT 1.1 work. There are couple of conflicts now, since MP 2.0 work and JWT 1.1 were done on separate branches. These should be easy to fix. > On 7 Dec 2018, at 17:38, Jean-Louis Monteiro wrote: > > Agreed. > Merged. Let's hack ahead now > -- > Jean-Louis Monteiro

Re: MicroProfile 2.0

Agreed. Merged. Let's hack ahead now -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Dec 7, 2018 at 6:37 PM David Blevins wrote: > > On Dec 7, 2018, at 8:38 AM, Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > > > > I have built and reviewed

Re: MicroProfile 2.0

> On Dec 7, 2018, at 8:38 AM, Jean-Louis Monteiro > wrote: > > I have built and reviewed this PR. We should merge it. The master is broken > anyway because we need to update the rest-client api version. > > Are we ok to merge it and continue the work on master? You know my philosophy: - if

[GitHub] tomee pull request #260: TOMEE-2291 - MicroProfile Fault Tolerance Example f...

GitHub user josehenriqueventura opened a pull request: https://github.com/apache/tomee/pull/260 TOMEE-2291 - MicroProfile Fault Tolerance Example for @Retry pom.xml - Removed parent examples - Added properties to hold the versions of which libraries in use. - Added

[GitHub] tomee pull request #212: TOMEE-2280 - Microprofile 2.0

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/212 ---

Re: MicroProfile 2.0

I may be biased to say yes :) > On 7 Dec 2018, at 16:38, Jean-Louis Monteiro wrote: > > I have built and reviewed this PR. We should merge it. The master is broken > anyway because we need to update the rest-client api version. > > Are we ok to merge it and continue the work on master? > > --

Re: Stabilize TomEE Build

Filed a ticket: https://issues.apache.org/jira/browse/TOMEE-2330. We could ignore the test in the meantime. Jon On Fri, Dec 7, 2018 at 4:36 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I committed a fix for CustomOrmXmlTest. The failure in CmpMappingsTest > actually looks like

Re: MicroProfile 2.0

I have built and reviewed this PR. We should merge it. The master is broken anyway because we need to update the rest-client api version. Are we ok to merge it and continue the work on master? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Dec 7, 2018

[NOTICE] Mandatory relocation of Apache git repositories on git-wip-us.apache.org

[IF YOUR PROJECT DOES NOT HAVE GIT REPOSITORIES ON GIT-WIP-US PLEASE DISREGARD THIS EMAIL; IT WAS MASS-MAILED TO ALL APACHE PROJECTS] Hello Apache projects, I am writing to you because you may have git repositories on the git-wip-us server, which is slated to be decommissioned in the coming

Re: Stabilize TomEE Build

I committed a fix for CustomOrmXmlTest. The failure in CmpMappingsTest actually looks like a genuine error case that only affects Plume/EclipseLink. I'm digging in. Does someone want to take the BVal tests off me? Not required, but if someone is looking for something to do, I'm happy to hand

Re: MicroProfile 2.0

Ok, then I'll checkout your PR and build it locally -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Dec 7, 2018 at 5:07 PM Roberto Cortez wrote: > We already released a TomEE 8 M1 with MP 1.3 support. > > And in reality, MP 2.x is the one we should be

Re: MicroProfile 2.0

We already released a TomEE 8 M1 with MP 1.3 support. And in reality, MP 2.x is the one we should be targeting with TomEE 8, since we have CDI 2.0. > On 7 Dec 2018, at 15:49, Otávio Gonçalves de Santana > wrote: > > JL, I like baby steps. > Maybe, keep MP 1.3, release a TomEE 8 RC-2, then

Re: CI with Jenkins

There is a Jenkins at Apache. Some projects like OWB uses it. Not sure the boxes are big enough though -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Dec 7, 2018 at 3:21 PM Richard Monson-Haefel wrote: > Cesar, > > Whatever happened to this discussion

Re: MicroProfile 2.0

JL, I like baby steps. Maybe, keep MP 1.3, release a TomEE 8 RC-2, then upgrade the version to MP 2.0. On Fri, Dec 7, 2018 at 1:40 PM Jean-Louis Monteiro wrote: > Let's revive this discussion ... > > We are working on build stability (see other thread). > I was digging into an issue where there

Re: MicroProfile 2.0

Hi JL, In my opinion, I think we should move to MP 2.0. We started with MP 1.3 to start to support something and because we didn’t have implementations to support 2.0, which we have now, aside from Fault Tolerance (work is being done on Geronimo at the moment). There is already a PR with all

Re: MicroProfile 2.0

Let's revive this discussion ... We are working on build stability (see other thread). I was digging into an issue where there is a mismatch between the API we pick in TomEE 8.x (master) which is for the moment MP 1.3 compliant. Unfortunately we have upgraded CXF which is now rest-client 1.1 as

Re: Approving Pull Requests

+1 -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Dec 7, 2018 at 4:21 PM Otávio Gonçalves de Santana < osant...@tomitribe.com> wrote: > That is a nice point. > > I usually do this, I just keep one PR active and just open a second one > when the first

Re: Stabilize TomEE Build

Looks like a CXF upgrade changed the API CXF is implementing. If we upgrade the API on our MicroProfile module then we won't be 1.3 compliant. But other solution is to downgrade CXF to match MP 1.3 which has rest-client 1.0 I'd rather get TomEE 8 to be upgraded in regards to MP so we support MP

Re: Stabilize TomEE Build

Hi folks, Thank you for working on this. Were we able to determine the cause of all these issues? When we did the M1 release and even after that we had green builds, so it seems we did something that broke a lot of tests? Cheers, Roberto > On 7 Dec 2018, at 15:05, Jean-Louis Monteiro wrote:

Re: Approving Pull Requests

That is a nice point. I usually do this, I just keep one PR active and just open a second one when the first is merged. I think that became easier to review and merge process. On Thu, Dec 6, 2018 at 10:24 AM Richard Monson-Haefel < monsonhae...@gmail.com> wrote: > I went through and gave my

Re: Stabilize TomEE Build

The rest-client seems to be a version issue [ERROR] testInvokesPostOperation(org.eclipse.microprofile.rest.client.tck.cditests.CDIInvokeWithRegisteredProvidersTest) Time elapsed: 0.521 s <<< FAILURE! java.lang.NoSuchMethodError:

Re: Stabilize TomEE Build

The Duplicate one is also BVal Jon. I'l looking at the rest-client part. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Dec 7, 2018 at 2:55 PM Jean-Louis Monteiro wrote: > JmsInjectionTests works locally > -- > Jean-Louis Monteiro >

[GitHub] tomee issue #173: TOMEE-2247 - MicroProfile JWT Propagation 1.1

Github user radcortez commented on the issue: https://github.com/apache/tomee/pull/173 @jeanouii this work should now be complete. I've sent an email about this to the ML. I think we can merge it. ---

CI with Jenkins

Cesar, Whatever happened to this discussion about implementing a CI using Jenkins? Seems like people felt it would be a good idea. You've been on vacation. Can you spearhead this? Past discussion http://tomee-openejb.979440.n4.nabble.com/Continuous-integration-and-a-PR-td4685376.html --

[GitHub] tomee issue #169: TOMEE-2239 removing the try-catch block

Github user rzo1 commented on the issue: https://github.com/apache/tomee/pull/169 @tveronezi Can you close PR please? According to @radcortez everything was merged. ---

Re: Stabilize TomEE Build

JmsInjectionTests works locally -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Dec 7, 2018 at 11:52 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > I have been digging and running tests locally. > Here is the list of tests failures I have

Re: TOMEE-2291 - Fault Tolerance Microprofile example for @Retry

Hi José, Thanks and yes, please do remove the parent in your example in a new PR. The maven-war-plugin difference is fine. It's good to have a different solution for the same problem :). Thanks for noticing it! Cheers Bruno Baptista https://twitter.com/brunobat_ On 07/12/18 13:06, Jose

Re: TOMEE-2291 - Fault Tolerance Microprofile example for @Retry

Hi Bruno, Thanks for the feedback on my PR and all other things that you spotted also. Based on this PR https://github.com/apache/tomee/pull/259, I see that you made some changes for a few pom.xml and I also made the same changes to reflect what you have done in mp-faultolerance-retry pom.xml.

[GitHub] tomee pull request #240: TOMEE-2291 - Fault Tolerance Microprofile example f...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/240 ---

Re: Fix pom.xml in examples.

Hi Folks. Here is the Jira: https://issues.apache.org/jira/browse/TOMEE-2328 And a PR: https://github.com/apache/tomee/pull/259 The changes should not conflict with ongoing work. We have a project that has errors and is commented out in the modules: arquillian-jpa I digger into it and it

[GitHub] tomee pull request #259: TOMEE-2328 - Cleanup examples maven structure

GitHub user brunobat opened a pull request: https://github.com/apache/tomee/pull/259 TOMEE-2328 - Cleanup examples maven structure @ivanjunckes please take a look at this one because I changed the pom of some metrics examples. You can merge this pull request into a Git

Re: Stabilize TomEE Build

I see this also fails on buildbot: org.apache.openejb.arquillian.tests.cmp.sample.CustomOrmXmlTest - its a simple fix which I'll commit now. Jon On Fri, Dec 7, 2018 at 11:05 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Hey Jean-Louis > > Thanks for the list! > > These ones

Re: Stabilize TomEE Build

Hey Jean-Louis Thanks for the list! These ones _should_ be fixed (as of late yesterday) - LegacyServerTest - LegacyClientTest - (StickyConnection|RoundRobin|Random)StrategyTest - ReconnectDelayCaseInsensitiveTest - ReconnectDelayListSelfTest - ReconnectTest Its possible you didn't have my

Re: connetor-ear-sample in examples

Great. Thanks Jon Bruno Baptista https://twitter.com/brunobat_ On 07/12/18 10:53, Jonathan Gallimore wrote: Yes please - I believe it was my mistake. Cheers Jon On Fri, Dec 7, 2018 at 10:51 AM Bruno Baptista wrote: Hi The connector-ear-sample doesn't have a parent pom.xml but has 4

Re: Stabilize TomEE Build

I have been digging and running tests locally. Here is the list of tests failures I have extracted. - JMSInjectionTest - CDIInvokeSimpleGetOperationTest - CDIInvokeWithRegisteredProviderTest - FeatureRegistrationTest - InvokeWithJsonProviderTest - DuplicateConfigurationTest - XMLConfigurationTest

Re: connetor-ear-sample in examples

Yes please - I believe it was my mistake. Cheers Jon On Fri, Dec 7, 2018 at 10:51 AM Bruno Baptista wrote: > Hi > > The connector-ear-sample doesn't have a parent pom.xml but has 4 > sub-projects. > > We also have a connector-ear project with sub-projects that look alike. > > I wonder if at

connetor-ear-sample in examples

Hi The connector-ear-sample doesn't have a parent pom.xml but has 4 sub-projects. We also have a connector-ear project with sub-projects that look alike. I wonder if at some point a refactoring was done and the connector-ear-sample was left there by mistake... Can I delete

Re: TomEE 8 Release Preview

Yes we are trying to work on Java EE 8, Java 11 support, the website update, and MicroProfile compliancy. If you are willing to help, we can definitely guide you. JLouis -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Dec 5, 2018 at 2:59 PM j4fm

Re: Fix pom.xml in examples.

Thanks Bruno for reviewing and for the ticket to fix the issue. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Dec 6, 2018 at 3:04 PM Bruno Baptista wrote: > Hi Folks, > > Yet in relation with the examples... > > I've noticed that project folder names

[GitHub] tomee pull request #200: Creates an unmarshal that does not filter to JavaEE...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/200 ---

[GitHub] tomee pull request #205: added ignore folder from vscode.

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/205 ---

[GitHub] tomee issue #240: TOMEE-2291 - Fault Tolerance Microprofile example for @Ret...

Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/240 It still has a conflict @josehenriqueventura ---

[GitHub] tomee issue #173: TOMEE-2247 - MicroProfile JWT Propagation 1.1

Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/173 So what do we do? Do we leave this open? ---

Re: Documentation Contribution Opportunities

Wilco :) чт, 6 дек. 2018 г. в 23:43, David Blevins : > I would vote for the TomEE Maven Plugin, which has a lot of features. Any > love it gets would help many people. > > If you're up for pushing the bounds of creativity a bit, here's a fun idea. > > - write the javadoc in asciidoc format : >