[GitHub] tomee pull request #273: Added index information to mp examples readme files...

GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/273 Added index information to mp examples readme files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee

Re: Website: Questions and Errors

Hi Frankie, My 2 cents about this thread is that currently, the community find two flavors of TomEE websites, we all are working on a migration to the site-generator following a git workflow and that is awesome but adding a third platform may increase the complexity for both the, reviewers, and

Re: TOMEE-2339 Describe Workflow for Contribution

Hi Frankie, I review your PR, current status looks awesome. The coding approach for the workflow is now in your PR detailed in four pages with text, I wonder if some visual diagram can also help, what do you think about it? El lun., 10 dic. 2018 a las 9:28, Frankie () escribió: > That's great,

Re: More Community Website section improvements [TOMEE-2317]

Hi, The PR is now part of master, but the JIRA ticket is still in Open state and unassigned. It's ok to ask to the list for JIRA admins to move forward the ticket or before each release, the Jira admins do the JIRA pruning? El mar., 4 dic. 2018 a las 13:08, César Hernández Mendoza (<

Re: Website: Questions and Errors

Hi Richard, thank you. The main point is that we need an easier and more handy way to manage the information for the community section. I suggested the wiki because it already exists and obviously belongs to the Apache infrastructure so that I hope we could quickly start with this. But I'm open

Re: CI with Jenkins

Hi Richard, The Past discussion you are referring too is still waiting for a question I made to the committers since I don't have the grants. I would recommend doing the follow up in the original thread. El vie., 7 dic. 2018 a las 8:21, Richard Monson-Haefel (< monsonhae...@gmail.com>) escribió:

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

Hi @Jean-Louis, The fix you did solve the general build if the test is skipt, but today I was starting to work on TOMEE-2357 [1] but when I pull the latest master, now the mp-rest-jwt example[2] PR you merged today is broken: I've attached the entire log. But the first exception present is: Dec

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

Of course Le mer. 12 déc. 2018 à 23:28, Roberto Cortez a écrit : > Yeah, sorry I got it. > > > On 12 Dec 2018, at 16:55, Jean-Louis Monteiro > wrote: > > > > Yes, here is the fix > > > https://github.com/apache/tomee/commit/c17b93cb644bc7cbdd463d59ccfbf6a08998553f > > > > -- > > Jean-Louis

Re: TOMEE-2354 - Added MicroProfile Support to TomEE Plus.

Good Idea. That's TomEE's face on github. In any case, we need the new command line profiles mentioned somewhere. Cheers Bruno Baptista https://twitter.com/brunobat_ On 12/12/18 22:26, Roberto Cortez wrote: Which one? That reminds me that I think we should improve our README file that

[GitHub] tomee pull request #272: TOMEE-2234 fix Bmp finder can only return 256 entit...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/272 ---

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

Yeah, sorry I got it. > On 12 Dec 2018, at 16:55, Jean-Louis Monteiro > wrote: > > Yes, here is the fix > https://github.com/apache/tomee/commit/c17b93cb644bc7cbdd463d59ccfbf6a08998553f > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On

Re: TOMEE-2354 - Added MicroProfile Support to TomEE Plus.

Which one? That reminds me that I think we should improve our README file that shows on Github. Right now is very poor: https://github.com/apache/tomee/blob/master/README.md I’ve created this issue:

[GitHub] tomee issue #60: amq and ibm mq portability using tomee

Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/60 @suyogbarve Thank you for putting this together, it looks great. I have a couple of points for feedback: * Can you add the ASL header to your source files? * Can ChatBean and

Re: TOMEE-2354 - Added MicroProfile Support to TomEE Plus.

Hi Roberto, Would it be possible to update the main README with the new profiles, so people are aware of them when building? Cheers Bruno Baptista https://twitter.com/brunobat_ On 11/12/18 15:04, Roberto Cortez wrote: Ok, so I’m going to leave the MP TCK to run default on the MP flavour

Re: How can I help?

Thank you very much guys. I'll try to add some work to the project ;-) Pavel On Wed, Dec 12, 2018, 18:38 Bruno Baptista Welcome Pavel! > > I'm glad to see you around. > > Cheers. > > Bruno Baptista > https://twitter.com/brunobat_ > > > On 11/12/18 22:29, Pavel Šmajda wrote: > > Hi, > > > > I

Re: How can I help?

Welcome Pavel! I'm glad to see you around. Cheers. Bruno Baptista https://twitter.com/brunobat_ On 11/12/18 22:29, Pavel Šmajda wrote: Hi, I would like to join the community and help with some testing. What I can do for TomEE or for community? How can I help you to improve it? I'm not

Re: How can I help

Hi Prakash, Welcome! You can also take a look in the Apache TomEE Jira and ask to take any unassigned issue you like: https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2264?filter=allopenissues Bruno Baptista https://twitter.com/brunobat_ Bruno Baptista https://twitter.com/brunobat_

Re: Stabilize TomEE Build

I'll take the first one first -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Dec 12, 2018 at 5:21 PM Roberto Cortez wrote: > Thank you JL, > > At least this test is failing: > org.apache.openejb.config.rules.CheckMissingClassTest > > And this one

Re: Stabilize TomEE Build

Thank you JL, At least this test is failing: org.apache.openejb.config.rules.CheckMissingClassTest And this one seems to fail randomly. org.apache.openejb.resource.AutoConnectionTrackerTest Cheers, Roberto > On 12 Dec 2018, at 16:18, Jean-Louis Monteiro > wrote: > > I have merged a couple

Re: Stabilize TomEE Build

I have merged a couple of PR and I'm running a full build locally. I'll work on fixes any issues if I find some but I'll report first here -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Dec 12, 2018 at 3:33 PM Roberto Cortez wrote: > Hey Jon, > > The

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on the issue: https://github.com/apache/tomee/pull/262 This is bad 😓, i think i just delete this PR and let somebody else work on this ---

[GitHub] tomee pull request #233: TOMEE-2304 Improving MP-REST-JWT example

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/233 ---

[GitHub] tomee pull request #270: TOMEE-2354 - Added MicroProfile Support to TomEE Pl...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/270 ---

[GitHub] tomee pull request #271: Unnecessary boxing

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/271 ---

Re: Website: Questions and Errors

I know that this wiki exists, but I have to say that Confluence has never been a favorite of mine. I'm not sure if there is an alternative but I vote against it. On Tue, Dec 11, 2018 at 11:23 PM Frankie wrote: > Obviously the information is distributed over many heads and we have to > bring >

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user pzygielo commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r241067971 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java --- @@ -120,10 +150,19 @@ public File getFile(final String path,

Re: How can I help?

Welcome, Pavel! I'm glad that you were helped so quickly by David B. Nice! On Wed, Dec 12, 2018 at 6:27 AM Pavel Šmajda wrote: > Hi David, > > That's perfect! I definitely want to expand coding skills on field of > testing, especially in Java. It looks like a great idea and place where >

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user pzygielo commented on the issue: https://github.com/apache/tomee/pull/262 I see no value in the most of JavaDocs added. The rest is misleading in the best case. ---

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user pzygielo commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r241051038 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java --- @@ -74,6 +80,12 @@ public boolean addObserver(final

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user pzygielo commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r241049965 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverAdded.java --- @@ -26,10 +26,20 @@ private final

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user pzygielo commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r241049054 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverAdded.java --- @@ -26,10 +26,20 @@ private final

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user pzygielo commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r241048270 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/observer/event/ObserverRemoved.java --- @@ -26,10 +26,20 @@ private

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on the issue: https://github.com/apache/tomee/pull/262 Hi everyone, wonder if someone could check the JavaDocs I added..would love some help if there are wrong ones ---

[GitHub] tomee issue #269: Add some JavaDoc to the maven plugin

Github user pzygielo commented on the issue: https://github.com/apache/tomee/pull/269 What purpose is served by that kind of JavaDocs? I see only unneeded noise that duplicates what types/methods/fields/... **already** deliver with their names. ---

[GitHub] tomee issue #269: Add some JavaDoc to the maven plugin

Github user radcortez commented on the issue: https://github.com/apache/tomee/pull/269 Hey @dalexandrov! Great to have you here :) Thank you for your PR. If you could just replace the name TomEE instead of Tomee or other variations it should be good to go :) ---

[GitHub] tomee pull request #269: Add some JavaDoc to the maven plugin

Github user dalexandrov commented on a diff in the pull request: https://github.com/apache/tomee/pull/269#discussion_r241041631 --- Diff: maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java --- @@ -1439,14 +1662,29 @@ protected void

[GitHub] tomee pull request #269: Add some JavaDoc to the maven plugin

Github user radcortez commented on a diff in the pull request: https://github.com/apache/tomee/pull/269#discussion_r241041283 --- Diff: maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java --- @@ -1439,14 +1662,29 @@ protected void

[GitHub] tomee pull request #269: Add some JavaDoc to the maven plugin

Github user radcortez commented on a diff in the pull request: https://github.com/apache/tomee/pull/269#discussion_r241041171 --- Diff: maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java --- @@ -1439,14 +1662,29 @@ protected void

[GitHub] tomee pull request #269: Add some JavaDoc to the maven plugin

Github user radcortez commented on a diff in the pull request: https://github.com/apache/tomee/pull/269#discussion_r241041043 --- Diff: maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java --- @@ -283,57 +400,111 @@ @Parameter

[GitHub] tomee pull request #269: Add some JavaDoc to the maven plugin

Github user radcortez commented on a diff in the pull request: https://github.com/apache/tomee/pull/269#discussion_r241040758 --- Diff: maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java --- @@ -148,45 +187,87 @@

[GitHub] tomee pull request #269: Add some JavaDoc to the maven plugin

Github user radcortez commented on a diff in the pull request: https://github.com/apache/tomee/pull/269#discussion_r241040709 --- Diff: maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java --- @@ -148,45 +187,87 @@

[GitHub] tomee pull request #269: Add some JavaDoc to the maven plugin

Github user radcortez commented on a diff in the pull request: https://github.com/apache/tomee/pull/269#discussion_r241040579 --- Diff: maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java --- @@ -148,45 +187,87 @@

[GitHub] tomee pull request #269: Add some JavaDoc to the maven plugin

Github user radcortez commented on a diff in the pull request: https://github.com/apache/tomee/pull/269#discussion_r241040636 --- Diff: maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java --- @@ -148,45 +187,87 @@

[GitHub] tomee pull request #269: Add some JavaDoc to the maven plugin

Github user radcortez commented on a diff in the pull request: https://github.com/apache/tomee/pull/269#discussion_r241040510 --- Diff: maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java --- @@ -99,37 +99,73 @@ import static

[GitHub] tomee pull request #269: Add some JavaDoc to the maven plugin

Github user radcortez commented on a diff in the pull request: https://github.com/apache/tomee/pull/269#discussion_r241040435 --- Diff: maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java --- @@ -99,37 +99,73 @@ import static

[GitHub] tomee pull request #269: Add some JavaDoc to the maven plugin

Github user radcortez commented on a diff in the pull request: https://github.com/apache/tomee/pull/269#discussion_r241040363 --- Diff: maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java --- @@ -99,37 +99,73 @@ import static

[GitHub] tomee issue #60: amq and ibm mq portability using tomee

Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/60 Yes, I'll get that done today. Thanks for the nudge. ---

Re: MP JWT example revisited

Hey Cesar, It seems good to go. I pushed my +1 on the PR. Em qua, 12 de dez de 2018 2:26 AM, César Hernández Mendoza < cesargu...@gmail.com escreveu: > Thank you @Roberto for the comments. > > I finish my PR and removed the "WIP" from the PR name, can somebody please > review it:

Re: How can I help?

Hi David, That's perfect! I definitely want to expand coding skills on field of testing, especially in Java. It looks like a great idea and place where I'll be happy :-) What it takes about non-coding part - I can do it too. If those docs are important to you, I can update all of them. They

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

Hey JL, Were you able to fix the issue? > On 11 Dec 2018, at 09:03, Jean-Louis Monteiro > wrote: > > I think I found the bug on this one. Let's open a PR and then if you could > give me your thoughts > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com >

Re: MPJWT @RolesAllowed is been applied with a all or nothing policy - TOMEE-2357

Assigned! > On 12 Dec 2018, at 05:33, César Hernández Mendoza > wrote: > > During the creation of a second version of the MP JWT example [1] I found a > bug related with the enforcement of the @RolesAllowed validation. > > I created https://issues.apache.org/jira/browse/TOMEE-2357 with the >

Re: TOMEE-2234 BMP finder issue

Still testing, but here's the change: https://github.com/apache/tomee/pull/272. Any feedback is welcome. Jon On Wed, Dec 12, 2018 at 10:29 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I found the issue here, and fixed it. I need to check to ensure that the > change doesn't

[GitHub] tomee pull request #272: TOMEE-2234 - WIP

GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/272 TOMEE-2234 - WIP This PR introduces Arquillian tests for BMP finder methods, and addresses an issue when there are more than 256 handles in the stack. The root issue is that when proxies are

Re: TOMEE-2234 BMP finder issue

I found the issue here, and fixed it. I need to check to ensure that the change doesn't affect the wire protocol - I'm _fairly_ sure it doesn't, but we'd need to discuss how to handle it, if it did. I should have a PR up for review later today. Jon On Tue, Dec 11, 2018 at 2:34 PM Jonathan

Re: Move to Gitbox?

To be honest. We'll have to do anyways. So being proactive can be only a good thing. Le mer. 12 déc. 2018 à 11:25, Jonathan Gallimore < jonathan.gallim...@gmail.com> a écrit : > Thanks for all the responses. Going to give it another 24 hours, just in > case there's an objection, and then I'll

Update the version comparison webpage

Hi Folks, I've created a new Jira in order to update the version comparison webpage: http://tomee.apache.org/comparison.html https://issues.apache.org/jira/browse/TOMEE-2359 We should probably cleanup the "TomEE JAX-RS" and include Webprofile and Microprofile to match what we have on the