How can I contribute?

2019-01-04 Thread Venu Krishnan
Hello Team: This is Venu from Toronto, Canada. Have been a TomEE user for quite sometime and would like to learn more by contributing to it with open source community, I have 10+ years of experience focused on backend development in Java, JEE, Spring, webservices, middleware technologies in a

[GitHub] asfgit closed pull request #15: TOMEE-2412 & TOMEE-2414 - pdf filename and tomee master link CI.

2019-01-04 Thread GitBox
asfgit closed pull request #15: TOMEE-2412 & TOMEE-2414 - pdf filename and tomee master link CI. URL: https://github.com/apache/tomee-site-generator/pull/15 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

Fwd: TOMEE-2378

2019-01-04 Thread Jonathan Gallimore
Forwarding this to dev@ with Jeff's permission - thanks Jeff! Feel free to followup here if you need any help at all. Jon -- Forwarded message - From: Jonathan Gallimore Date: Fri, Jan 4, 2019 at 4:22 PM Subject: Re: TOMEE-2378 To: Jeff Mitchell Hi Jeff That page you found

Re: Stabilize TomEE Build

2019-01-04 Thread Jonathan Gallimore
On Fri, Jan 4, 2019 at 6:39 PM Ivan Junckes Filho wrote: > Hey guys, can someone provide me the way to check if my PR is green? > Yep, run the build on your branch :-). I run builds on PRs when I review them. If you don't want to run the full build, you could run tests that are relevant to your

Re: TOMEE-2289

2019-01-04 Thread Romain Manni-Bucau
Hi Ivan For the browser usage /openapi.json or /openapi.yaml will solve it nicely On master we ensure to respect the request expected type - it is fine to serialize it as html, this is even a way to implement a UI for it ;) - but we also ensure there is a writer instead of assuming the user

Re: TOMEE-2289

2019-01-04 Thread Ivan Junckes Filho
FYI I opened a PR on geronimo to fix the issue with text/html. https://github.com/apache/geronimo-openapi/pull/4 Postman was working because it used */* and the implementation was properly handling it, but not handling text/html. On Thu, Jan 3, 2019 at 2:34 PM Ivan Junckes Filho wrote: > Yes,

Re: Stabilize TomEE Build

2019-01-04 Thread Ivan Junckes Filho
Hey guys, can someone provide me the way to check if my PR is green? Also, now that apache has migrated to gitbox, is there a way to integrate the build with github? On Thu, Jan 3, 2019 at 10:03 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > That'd be great indeed > > -- >

Re: TomEE 7.1 release note issue ? and Metrics not working on TomEE 8.0.0 M1 ?

2019-01-04 Thread Roberto Cortez
So maybe we should open up a PR and improve the documentation spec to make it clear? :) > On 4 Jan 2019, at 16:43, COURTAULT Francois > wrote: > > Hello Roberto, > > Read more carefully the spec and the metrics I have listed in my previous > mail were optional metrics: sorry. > Anyway,

Re: TomEE 7.1 release note issue ? and Metrics not working on TomEE 8.0.0 M1 ?

2019-01-04 Thread Roberto Cortez
Great! Interesting. If things are missing, then they are not being picked up by the TCK. So I think we need to checkout the MP Metrics TCK and see if they are checking for these metrics and possible open an issue for them and a PR. Also, open an issue on the Geronimo project, since the

Re: TomEE logo poll

2019-01-04 Thread Ivan Junckes Filho
Roberto, I don't know the Apache internals for this. Maybe someone in the PMC could help with this information. I am not against it if there is a level of agility... Anyone could give a feedback about this? On Thu, Jan 3, 2019 at 9:54 AM Roberto Cortez wrote: > Well I think that would be

Re: git productivity

2019-01-04 Thread César Hernández Mendoza
Thank you for the reply guys! I use a small version of git-prompt.sh. In my .bash_profile, this is how it looks: PS1='\[\e[0;33m\]\u\[\e[0m\]:\[\e[0;32m\]\W\[\e[0m\]\[\e[34m\]$(parse_git_branch)\[\e[m\]\$ ' The parse_git_branch is actually the one that comes with in this tools (git status):

Re: Is there anyone who works on RandomConnectionStrategyTest failure?

2019-01-04 Thread Jonathan Gallimore
I'm not aware of anyone looking at it. Go for it, and the help is much appreciated. Cheers Jon On Fri, Jan 4, 2019 at 3:35 PM Doychin Bondzhev wrote: > Hi guys, > > I think I found why this test fails and I'll try to propose solution for > it later today. > > The failure is : > >

Is there anyone who works on RandomConnectionStrategyTest failure?

2019-01-04 Thread Doychin Bondzhev
Hi guys, I think I found why this test fails and I'll try to propose solution for it later today. The failure is : java.lang.AssertionError: services failed to come online: waited 60 SECONDS In case any one is working on it just let me know so we don't do this work twice ;-) -- Doychin

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-04 Thread Gurkan Erdogdu
Thank you Jon! On Fri, Jan 4, 2019 at 5:35 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Thanks for the explanation, I appreciate it. As long as there's no > objections I'll merge the PR in. > > Jon > > On Fri, Jan 4, 2019 at 6:28 AM Gurkan Erdogdu wrote: > > > Thanks Jon. > >

Re: git productivity

2019-01-04 Thread Jonathan Gallimore
One note for committers - do go and link your GitHub and Apache accounts here: https://gitbox.apache.org/setup/. Make sure you have your github userid setup on your Apache account profile (https://id.apache.org/). This should trigger you to be invited to the Apache organization on GitHub. If you

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-04 Thread Jonathan Gallimore
Thanks for the explanation, I appreciate it. As long as there's no objections I'll merge the PR in. Jon On Fri, Jan 4, 2019 at 6:28 AM Gurkan Erdogdu wrote: > Thanks Jon. > > I don't have any aim to replace service-jar.xml approach. We will just add > another YAML based configuration support.

Re: git productivity

2019-01-04 Thread Roberto Cortez
I use hub and I have aliased to git. I find it super useful to submit PR via git pull-request -b master for instance. I also use this git-prompt: https://github.com/git/git/blob/master/contrib/completion/git-prompt.sh

Re: Buildbot and Gitbox

2019-01-04 Thread Roberto Cortez
This was the issue: https://issues.apache.org/jira/browse/INFRA-17548 I had to update the buildbot config file to the new Git repo address sitting here:

Re: git productivity

2019-01-04 Thread Jean-Louis Monteiro
I use a plain git client -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Jan 3, 2019 at 6:08 PM César Hernández Mendoza wrote: > any git alias tool do you recommend to use apart from hub [1]? > I use to have some alias on my terminal for `git status`,

Re: Buildbot and Gitbox

2019-01-04 Thread Jean-Louis Monteiro
Thanks man -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Jan 4, 2019 at 12:23 PM Roberto Cortez wrote: > Hi folks, > > It seems that our Buildbot CI stopped working (not picking up new commits > to build) after the repo migration to Gitbox. Opening a

Buildbot and Gitbox

2019-01-04 Thread Roberto Cortez
Hi folks, It seems that our Buildbot CI stopped working (not picking up new commits to build) after the repo migration to Gitbox. Opening a ticket to the Apache Infra team. Cheers, Roberto

Re: TomEE 7.1 release note issue ? and Metrics not working on TomEE 8.0.0 M1 ?

2019-01-04 Thread Roberto Cortez
Hi Francois, The metrics are exposed when you deploy an app, so you need to have an app deployed and then the metrics should be available in http://localhost:8080/APP_CONTEXT/metrics Are you running TomEE with the MicroProfile classifier? Have you