[GitHub] [tomee] rzo1 commented on pull request #883: Tomee 3824

2022-05-12 Thread GitBox
rzo1 commented on PR #883: URL: https://github.com/apache/tomee/pull/883#issuecomment-1125684017 Thanks for the PR @tichovz - I left some comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824

2022-05-12 Thread GitBox
rzo1 commented on code in PR #883: URL: https://github.com/apache/tomee/pull/883#discussion_r872021449 ## container/openejb-jee/src/test/resources/web-fragment-example.xml: ## @@ -0,0 +1,14 @@ + Review Comment: This file misses a license header - subsequently, the license

[GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824

2022-05-12 Thread GitBox
rzo1 commented on code in PR #883: URL: https://github.com/apache/tomee/pull/883#discussion_r872020377 ## container/openejb-jee/src/test/java/org/apache/openejb/jee/JeeTest.java: ## @@ -18,23 +18,22 @@ package org.apache.openejb.jee; +import jakarta.xml.bind.*; Review

Re: TOMEE-3824 New Jakarta EE 9 XML namespace not recognized in web-fragment.xml (was Re: How can I help?)

2022-05-12 Thread Zoltán Tichov
Hi! If I have a pending pull request, can I work on another issue as well? Thanks: Zoltán On Tue, May 10, 2022 at 10:48 PM David Blevins wrote: > Hi Zoltán! > > Really fantastic you have something working! > > If you create a PR that'a the best way to say "here are my changes, can > you

Re: TomEE 9.x - from javax to jakarta namespace

2022-05-12 Thread Wiesner, Martin
+1 Best Martin — https://twitter.com/mawiesne Am 11.05.2022 um 19:00 schrieb Cesar Hernandez mailto:cesargu...@gmail.com>>: +1, Thank you! El mié, 11 may 2022 a las 9:06, Daniel Dias Dos Santos (< daniel.dias.analist...@gmail.com>) escribió: +1 On

TomEE 9.x - jakarta.enterpise.inject.spi.Extension VS javax.enterpise.inject.spi.Extension

2022-05-12 Thread Richard Zowalla
Hi all, while working on fixing the Deltaspike examples on EE9 / master I encountered some Currently, TomEE 9.x only scans for "META- INF/services/jakarta.enterprise.inject.spi.Extension". This breaks, if 3rd party artifacts do not correctly relocate their "META-INF/services" files and still