rzo1 commented on code in PR #963:
URL: https://github.com/apache/tomee/pull/963#discussion_r1018706789
##
server/openejb-cxf/pom.xml:
##
@@ -264,7 +264,7 @@
com.sun.xml.messaging.saaj
saaj-impl
- ${saaj-impl.version}
+ ${version.impl.saaj}
Review
Hi!
I resolved the conflicts.
Thanks:
Zoltán
On Wed, Nov 9, 2022 at 7:48 PM GitBox wrote:
>
> rzo1 commented on PR #962:
> URL: https://github.com/apache/tomee/pull/962#issuecomment-1309211994
>
>@tichovz Thanks for the PR. Can you resolve the conflicts?
>
>
> --
> This is an automated
tichovz commented on PR #962:
URL: https://github.com/apache/tomee/pull/962#issuecomment-1309363487
I made the merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sultan opened a new pull request, #963:
URL: https://github.com/apache/tomee/pull/963
this one is renaming Jakarta EE version properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
> On Nov 9, 2022, at 10:29 AM, Zoltán Tichov wrote:
>
> Hi!
>
> Is there another task that could be taken care of?
There's a change in the same code that's on my "I should really find the time
to fix that" list if you want to dig in.
Basically, we added a TomEE-specific property
rzo1 merged PR #955:
URL: https://github.com/apache/tomee/pull/955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
sultan commented on code in PR #955:
URL: https://github.com/apache/tomee/pull/955#discussion_r1018321280
##
tomee/tomee-microprofile/mp-common/pom.xml:
##
@@ -27,7 +27,61 @@
mp-common
TomEE :: TomEE :: MicroProfile Common
+
Review Comment:
i believe this is not a
sultan commented on code in PR #955:
URL: https://github.com/apache/tomee/pull/955#discussion_r1018320773
##
tck/microprofile-tck/pom.xml:
##
@@ -63,4 +63,134 @@
+
+
Review Comment:
i believe this is not a duplicate, there are artifacts for API and more
sultan commented on PR #955:
URL: https://github.com/apache/tomee/pull/955#issuecomment-1309236149
all the versions are locked in a parent pom when desirable. there are
dependency management sections for MP in three pom:
* root pom.xml for MP API
* mp-common pom.xml for MP Geronimo
rzo1 commented on PR #962:
URL: https://github.com/apache/tomee/pull/962#issuecomment-1309211994
@tichovz Thanks for the PR. Can you resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Hi!
Is there another task that could be taken care of?
Thanks:
Zoltán
On Wed, Nov 9, 2022 at 10:19 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:
> We can get the CI system to build it.
> Thanks Zoltan
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
>
Hi Rod,
that shouldn't affect us at runtime. We should be fine at the moment,
but we might need to revisit in future Java versions.
Gruß
Richard
Am Montag, dem 31.10.2022 um 22:31 + schrieb Jenkins, Rodney J
(Rod):
> All,
>
> I see some new warnings when building the Docker images for
tichovz opened a new pull request, #962:
URL: https://github.com/apache/tomee/pull/962
implement 'mp.jwt.verify.token.age property'
implement 'mp.jwt.verify.clock.skew'
org.apache.tomee.microprofile.jwt.config.JWTAuthConfiguration
expGracePeriodSecs maybe superfluous
--
This is
sultan commented on PR #940:
URL: https://github.com/apache/tomee/pull/940#issuecomment-1308895567
TODO :
* create a JIRA for this dep update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rzo1 opened a new pull request, #961:
URL: https://github.com/apache/tomee/pull/961
as the title says
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sultan commented on PR #940:
URL: https://github.com/apache/tomee/pull/940#issuecomment-1308878859
rebased upon dependencies cleanup, i do recommend:
* review about the hard coded values of the multi-driver datasources tests
* build on CI
--
This is an automated message from the
rzo1 commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308868926
> Yes we can. It should work the same way
Ok. I will create a Jira for it, so we can pick it up.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jeanouii merged PR #959:
URL: https://github.com/apache/tomee/pull/959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
jeanouii merged PR #960:
URL: https://github.com/apache/tomee/pull/960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
stklcode opened a new pull request, #960:
URL: https://github.com/apache/tomee/pull/960
addition to PR #959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jeanouii commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308866109
Yes we can. It should work the same way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rzo1 commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308861846
@jeanouii Do we want to backport this change to 8.x, too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jeanouii commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308858672
You should be able to create a PR against this branch so I can merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
stklcode commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308829472
I do not have write permissions on this repository, so I'm afraid I cannot
do this.
What I can do is (re-)create this PR from my fork or you can cherry-pick the
referenced commit.
jeanouii commented on PR #959:
URL: https://github.com/apache/tomee/pull/959#issuecomment-1308819736
I agree that it does not hurt. Can you push your changes in this branch so
when I merge, your changes are included instead of me stealing your test?
--
This is an automated message from
rzo1 merged PR #953:
URL: https://github.com/apache/tomee/pull/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
sultan commented on PR #955:
URL: https://github.com/apache/tomee/pull/955#issuecomment-1308771100
sorry for the lack of update, i'll have time to rework the PR this weekend
or after the daily job. it should not take me much time, but i'll switch the
draft to ready only when ok.
--
This
rzo1 commented on PR #955:
URL: https://github.com/apache/tomee/pull/955#issuecomment-1308761706
Any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Hi everyone,
i wanted to discuss whether it was possible or desirable to switch some of
the project's API and Impl dependencies.
i'll try to be as concise as possible and polite to people doing already a
lot of good to the project. so please forgive in advance any heavy idea
from me or my bad
We can get the CI system to build it.
Thanks Zoltan
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Wed, Nov 9, 2022 at 10:06 AM Richard Zowalla wrote:
> Hi,
>
> good news! Yes - go for a PR.
>
> Gruß
> Richard
>
> Am Dienstag, dem 08.11.2022 um 23:30 +0100
Hi,
good news! Yes - go for a PR.
Gruß
Richard
Am Dienstag, dem 08.11.2022 um 23:30 +0100 schrieb Zoltán Tichov:
> Hi!
>
> I managed to get all the MP-JWT-TCK 2.1-RC6 tests to pass. I created
> microprofile-jwt-2.1-RC6 branch in my forked tomee project.
> What should I do? Can I create a PR?
>
31 matches
Mail list logo
