Re: Connector issues

2018-10-04 Thread Jean-Louis Monteiro
Great note Jon. Thanks it's appreciated +1 Le jeu. 4 oct. 2018 à 12:01, Romain Manni-Bucau a écrit : > +1 looks good > > Romain Manni-Bucau > @rmannibucau | Blog > | Old Blog > | Github < >

Re: Connector issues

2018-10-04 Thread Romain Manni-Bucau
+1 looks good Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: Connector issues

2018-10-04 Thread Jonathan Gallimore
I have pushed some commits onto the PR here: https://github.com/apache/tomee/pull/174, and would appreciate some review. One the things I found was that if I hold onto a reference to the proxy for the transaction, it doesn't get cleaned up, but then losing the reference from the scope at the end of

Re: Connector issues

2018-09-28 Thread Jonathan Gallimore
I was thinking the same - do it through the registry. Let me have a go at hacking on that and I'll post back here. Many thanks for the feedback. Jon On Fri, Sep 28, 2018 at 3:15 PM Romain Manni-Bucau wrote: > that is what I had in mind, throught it was already the case to be honest > through th

Re: Connector issues

2018-09-28 Thread Romain Manni-Bucau
that is what I had in mind, throught it was already the case to be honest through the transaction registry - excess of enthusiasm probably ;) Side note: dropped G for now, if we find something impacting g-txmgr we'll add it back Romain Manni-Bucau @rmannibucau |

Re: Connector issues

2018-09-28 Thread Jonathan Gallimore
I apologize, I CC'd Geronimo in case there was anything relevant on the Geronimo connector side. Happy to drop the CC if its not relevant. Thanks for the quick response! Off the top of my head, I wonder if we could keep a reference to the connection proxy in the transaction (if there is one), and

Re: Connector issues

2018-09-28 Thread Romain Manni-Bucau
Hi Jon, I experienced that kind of "surprise" in recent jvm since gc is way more aggressive - cause lambda are way more memory consuming ;). This lead to this kind of issue where the GC happens before the object should actually be finalizable. I suspect we need to rework the AutoConnectionTracker

Connector issues

2018-09-28 Thread Jonathan Gallimore
Hi Folks, I have been looking into some issues with TomEE using Websphere MQ, specifically issues where XA resources are returning a -7 error during a transaction commit when the system is under load. The -7 error indicates that the resource is closed. The result of this error seems to be resourc