jgallimore merged pull request #541: TOMEE-2481 - Move code using
PropertyEditors (deprecated class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/541
This is an automated message from the Apache Git
rzo1 opened a new pull request #541: TOMEE-2481 - Move code using
PropertyEditors (deprecated class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/541
Hi,
this PR is a follow up of the discussion in
https://github.com/apache/tomee/pull/427 and reflects
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors
(deprecated class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/541#issuecomment-523874982
Can one of the admins verify this patch
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors
(deprecated class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/541#issuecomment-523874985
Can one of the admins verify this patch
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors
(deprecated class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/541#issuecomment-523874983
Can one of the admins verify this patch
Hi Jon,
thank you for your review, I'll take a look after we finish the changes for
java and have it merged on master
Em seg, 4 de mar de 2019 às 08:27, Jonathan Gallimore <
jonathan.gallim...@gmail.com> escreveu:
> Added feedback on the PR, but including it here for visibility:
>
> In
Added feedback on the PR, but including it here for visibility:
In LocalJMXCommand the PropertyEditorRegistry is held as a field. In other
places, this is doing PropertyEditorRegistry.registerDefaults() when
calling getValue(), which has to go an do a bunch of registration each time.
What do we
Interesting. Thanks for the PR - looking at it now.
Jon
On Thu, Feb 28, 2019 at 3:26 PM Daniel Cunha wrote:
> Hi Folks,
>
> I've created the ticket https://issues.apache.org/jira/browse/TOMEE-2481
>
> That because the class PropertyEditors is a deprected class, because of
> that we are moving
Hi Folks,
I've created the ticket https://issues.apache.org/jira/browse/TOMEE-2481
That because the class PropertyEditors is a deprected class, because of
that we are moving it to use the PropertyEditorRegistry as indicated on the
PropertyEditors comment: this is all static and leaks, use
