Re: Fwd: svn commit: r1600089 - /tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/test/java/org/apache/openejb/concurrencyutilities/test/ManagedScheduledExecutorServiceTest.java

2014-06-04 Thread Andy Gumbrecht
I saw that also, and decided to leave it - I.e. not change it. It looks like it's there because the test could potentially return 7 due to getNextRunTime and Thread.sleep(5000) not really guaranteeing count accuracy . Maybe just testing for 5 is better. Andy. On 04/06/2014 13:06, Romain

Re: Fwd: svn commit: r1600089 - /tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/test/java/org/apache/openejb/concurrencyutilities/test/ManagedScheduledExecutorServiceTest.java

2014-06-04 Thread Romain Manni-Bucau
I'd go for a version with latches and no sleep rather. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-06-04 13:28 GMT+02:00 Andy Gumbrecht agumbre...@tomitribe.com: I

Re: Fwd: svn commit: r1600089 - /tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/test/java/org/apache/openejb/concurrencyutilities/test/ManagedScheduledExecutorServiceTest.java

2014-06-04 Thread Andy Gumbrecht
Sure, sounds good to me - I'll have another look in a minute, just got to get a sandwich for lunch :-D Andy. On 04/06/2014 13:39, Romain Manni-Bucau wrote: I'd go for a version with latches and no sleep rather. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/

Re: Fwd: svn commit: r1600089 - /tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/test/java/org/apache/openejb/concurrencyutilities/test/ManagedScheduledExecutorServiceTest.java

2014-06-04 Thread Romain Manni-Bucau
Hehe no hurry ;). Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-06-04 13:44 GMT+02:00 Andy Gumbrecht agumbre...@tomitribe.com: Sure, sounds good to me - I'll have

Re: Fwd: svn commit: r1600089 - /tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/test/java/org/apache/openejb/concurrencyutilities/test/ManagedScheduledExecutorServiceTest.java

2014-06-04 Thread hanas...@gmail.com
*From:* Romain Manni-Bucau rmannibu...@gmail.com *Sent:* Wednesday, June 04, 2014 6:48AM *To:* dev@tomee.apache.org dev@tomee.apache.org *Subject:* Re: Fwd: svn commit: r1600089 - /tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/test/java/org/apache/openejb/concurrencyutilities

Re: Fwd: svn commit: r1600089 - /tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/test/java/org/apache/openejb/concurrencyutilities/test/ManagedScheduledExecutorServiceTest.java

2014-06-04 Thread Andy Gumbrecht
/2014 14:31, hanas...@gmail.com wrote: *From:* Romain Manni-Bucau rmannibu...@gmail.com *Sent:* Wednesday, June 04, 2014 6:48AM *To:* dev@tomee.apache.org dev@tomee.apache.org *Subject:* Re: Fwd: svn commit: r1600089 - /tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/test/java/org

Re: Fwd: svn commit: r1600089 - /tomee/tomee/trunk/container/openejb-concurrency-utilities-ee/src/test/java/org/apache/openejb/concurrencyutilities/test/ManagedScheduledExecutorServiceTest.java

2014-06-04 Thread Romain Manni-Bucau
/container/openejb-concurrency-utilities-ee/src/test/java/org/apache/openejb/concurrencyutilities/test/ManagedScheduledExecutorServiceTest.java Is this based on my posting yesterday about a build failure that subsequently passed when increasing the sleep time? Either way, the thread waits are a bit