OK, I think I fixed everything but the mp-rest-jwt-jwk example that I'm
going to start working on now
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Mon, Jan 14, 2019 at 1:33 PM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:
> The build is now
The build is now running and tests executing. I'll monitor and try to fix
the rest.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Mon, Jan 14, 2019 at 10:28 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:
> Just saw there are some checkstyle
Just saw there are some checkstyle issues. Working on it.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Mon, Jan 7, 2019 at 3:56 PM César Hernández Mendoza
wrote:
> >
> > one suggestion was for committers to be able to kick off builds using a
> > specific
>
> one suggestion was for committers to be able to kick off builds using a
> specific commit hash, rather than automatically for each PR.
My only observation about it is that this will require a non commiter to
send an email to the dev list to request kick builds before actually
sending the
A couple of updates on this. I have a Jenkins install at home, which now
runs master with 5 test failures that we don't see on buildbot, so I don't
think there is technically much that holds us back from using Jenkins over
something else.
In terms of PR building, there's an interesting discussion
On Fri, Jan 4, 2019 at 7:24 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> On Fri, Jan 4, 2019 at 6:39 PM Ivan Junckes Filho
> wrote:
>
> > Hey guys, can someone provide me the way to check if my PR is green?
> >
>
> Yep, run the build on your branch :-). I run builds on PRs when
On Fri, Jan 4, 2019 at 6:39 PM Ivan Junckes Filho
wrote:
> Hey guys, can someone provide me the way to check if my PR is green?
>
Yep, run the build on your branch :-). I run builds on PRs when I review
them. If you don't want to run the full build, you could run tests that are
relevant to your
Hey guys, can someone provide me the way to check if my PR is green?
Also, now that apache has migrated to gitbox, is there a way to integrate
the build with github?
On Thu, Jan 3, 2019 at 10:03 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:
> That'd be great indeed
>
> --
>
That'd be great indeed
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Thu, Jan 3, 2019 at 12:26 PM Roberto Cortez
wrote:
> Maybe Bruno would like to work on that, since he is heavily involved with
> the EG and he did the integration for the last version?
Yes, I can have a look, but only next week.
Bruno Baptista
https://twitter.com/brunobat_
On 03/01/19 11:26, Roberto Cortez wrote:
Maybe Bruno would like to work on that, since he is heavily involved with the
EG and he did the integration for the last version?
Maybe Bruno would like to work on that, since he is heavily involved with the
EG and he did the integration for the last version?
> On 3 Jan 2019, at 11:16, Jean-Louis Monteiro wrote:
>
> Ok, looks like the build is back to stable.
> There are 2 other votes currently. I'll do an update when
Ok, looks like the build is back to stable.
There are 2 other votes currently. I'll do an update when the vote is
closed.
Meanwhile, we need an action plan for fault tolerance. We need to
investigate what happened or if we need to rework the integration.
--
Jean-Louis Monteiro
I think there's a vote for a minor release fixing an issue there.
Bruno Baptista
https://twitter.com/brunobat_
On 02/01/19 18:56, Roberto Cortez wrote:
The OpenTracing update was also failing the TCK. I’ve reverted it back until we
figure out what is going on.
On 2 Jan 2019, at 16:50,
The OpenTracing update was also failing the TCK. I’ve reverted it back until we
figure out what is going on.
> On 2 Jan 2019, at 16:50, Roberto Cortez wrote:
>
> It seems to fail intermittently. It took me a few tries to make it fail. On
> the latest buildbot it seems fine.
>
> Not sure if
It seems to fail intermittently. It took me a few tries to make it fail. On the
latest buildbot it seems fine.
Not sure if it was like this before or if it was something we did.
> On 2 Jan 2019, at 12:14, Jean-Louis Monteiro wrote:
>
> [ERROR] Failures:
> [ERROR]
[ERROR] Failures:
[ERROR] LegacyServerTest.test:208->assertBalance:219 Bad number of
invocations for the bean "green". expected:<2> but was:<1>
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Wed, Jan 2, 2019 at 1:14 PM Jean-Louis Monteiro
wrote:
> I
I also get this one locally
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Wed, Jan 2, 2019 at 1:05 PM Roberto Cortez
wrote:
> One issue at least was with the Safeguard upgrade. I’ve reverted it back.
> Lets see if this helps.
>
> > On 2 Jan 2019, at
One issue at least was with the Safeguard upgrade. I’ve reverted it back. Lets
see if this helps.
> On 2 Jan 2019, at 11:33, Roberto Cortez wrote:
>
> Yeah, just noticed it as well. Was about to send a message too. I can have a
> look.
>
>> On 2 Jan 2019, at 11:00, Jean-Louis Monteiro
>>
Yeah, just noticed it as well. Was about to send a message too. I can have a
look.
> On 2 Jan 2019, at 11:00, Jean-Louis Monteiro wrote:
>
> Ok, looks like we are back to red.
> Someone working on it?
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
Ok, looks like we are back to red.
Someone working on it?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Fri, Dec 21, 2018 at 12:59 AM Roberto Cortez
wrote:
> By the way, lets try to keep it that way :)
>
> > On 20 Dec 2018, at 20:48, César Hernández
Nice work guys!
El jue., 20 dic. 2018 a las 13:55, Frankie ()
escribió:
> Great! Well Done!
>
> Frankie
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>
--
Atentamente:
César Hernández Mendoza.
Very nice :) Thank you!
Am 20.12.2018 um 18:34 schrieb Bruno Baptista:
That's great! :)
Bruno Baptista
https://twitter.com/brunobat_
On 20/12/18 17:25, Jean-Louis Monteiro wrote:
Build is green, yeah.
https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8
Great community effort. Thanks
That's great! :)
Bruno Baptista
https://twitter.com/brunobat_
On 20/12/18 17:25, Jean-Louis Monteiro wrote:
Build is green, yeah.
https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8
Great community effort. Thanks everyone
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
Great! Congratulations everyone!
Did we change something on the CDI tests?
> On 20 Dec 2018, at 17:25, Jean-Louis Monteiro
> wrote:
>
> Build is green, yeah.
>
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8
>
> Great community effort. Thanks everyone
>
> --
> Jean-Louis Monteiro
Build is green, yeah.
https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8
Great community effort. Thanks everyone
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Wed, Dec 19, 2018 at 10:56 PM Daniel Cunha wrote:
> Hi Roberto,
>
> I can't reproduce the
Hi Roberto,
I can't reproduce the issue in both 7.0.x and 7.1.x with my patch applied,
it seems passing as expected:
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO] Running
The CDI TCK runs after the OpenEJB Core, so you should be able to see the debug
information you added.
I’m not sure if you noticed it, but I did add a @Ignore to the
AutoConnectionTracker test until we figure out what is wrong.
> On 19 Dec 2018, at 13:51, Jean-Louis Monteiro
> wrote:
>
>
Roberto, I saw you commented the test in which I added some more stuff to
test.
Do you have some inputs after the run?
Or are we still stuck on CDI ?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Wed, Dec 19, 2018 at 12:44 PM Daniel Cunha wrote:
> I saw
I saw your comment and it's weird.
I'll look it again, the patch should fix exactly the test which you are
getting error. :)
Thanks for review.
Em qua, 19 de dez de 2018 8:08 AM, Roberto Cortez
Hi Daniel,
>
> I’m having test failures in the PR updates for 7.0.x and 7.1.x. Can you
> confirm?
Hi Daniel,
I’m having test failures in the PR updates for 7.0.x and 7.1.x. Can you
confirm? Left you a note in the PR’s.
Cheers,
Roberto
> On 18 Dec 2018, at 15:18, Jean-Louis Monteiro
> wrote:
>
> I pushed some debugging information on the other test and I'll be
> monitoring the built
> --
I pushed some debugging information on the other test and I'll be
monitoring the built
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Tue, Dec 18, 2018 at 4:16 PM Daniel Cunha wrote:
> Nice... Thanks!
>
> Em ter, 18 de dez de 2018 11:48 AM, Roberto Cortez
Nice... Thanks!
Em ter, 18 de dez de 2018 11:48 AM, Roberto Cortez
Hi Daniel,
> I didn't yet for the other branches. I'll do it today.
> On Tuesday, December 18, 2018, 1:37:34 PM GMT, Daniel Cunha <
> daniels...@gmail.com> wrote:
>
> Hi Roberto,
>
> I saw that you merged the changes on
Hi Daniel,
I didn't yet for the other branches. I'll do it today.
On Tuesday, December 18, 2018, 1:37:34 PM GMT, Daniel Cunha
wrote:
Hi Roberto,
I saw that you merged the changes on master, did you see the others changes
for branch 7.0.x and 7.1.x?
Em seg, 17 de dez de 2018 às 18:07,
Hi Roberto,
I saw that you merged the changes on master, did you see the others changes
for branch 7.0.x and 7.1.x?
Em seg, 17 de dez de 2018 às 18:07, Roberto Cortez
escreveu:
> Thank you Daniel,
>
> I’ll review and merge.
>
> Yeah it seems it gets stuck in the CDI TCK. I saw it happening a
Thank you Daniel,
I’ll review and merge.
Yeah it seems it gets stuck in the CDI TCK. I saw it happening a couple of days
before, but now it happened again. Not sure what is wrong there, since we used
to pass it.
> On 17 Dec 2018, at 20:16, Daniel Cunha wrote:
>
> Hi Roberto,
>
> the fix
Hi Roberto,
the fix which I send is to make sure that the test is using the correct
version for libs.
For example, here
https://github.com/apache/tomee/pull/287/files#diff-88785d5b00bc141a892b2e21e6aaabcaL70
we have the version of the lib on the code.
Which means that, if you try run it on TomEE
Hi Daniel,
Can you please explain what the issue was?
Also, it seems our build is getting killed for taking to long due to some tests
being stuck?
Dec 17, 2018 12:06:54 PM org.apache.openejb.client.EventLogger log
INFO: RemoteInitialContextCreated{providerUri=http://localhost:40395/tomee/ejb}
Hey folks,
we found an issue on TomEECliIT test.
I've opened fixes for test in all branch, please take a look on it.
Fixes:
master -> https://github.com/apache/tomee/pull/288
7.1.x -> https://github.com/apache/tomee/pull/287
7.0.x -> https://github.com/apache/tomee/pull/286
Em sex, 14 de dez de
Please wait a minute lol
I'd rather have you help me if needed.
First I don't have the feeling I spent time for nothing on it and second,
at least I will learn something.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Fri, Dec 14, 2018 at 4:33 PM Jonathan
I added this test, and it was pretty stable. Happy to help look into it.
On Fri, Dec 14, 2018 at 10:44 AM Roberto Cortez
wrote:
> It seems the build just randomly fails with this test:
> AutoConnectionTrackerTest.test
>
> [ERROR] Failures:
> [ERROR] AutoConnectionTrackerTest.test:198
Working on Cesar's PR. I'll have a look after.
Le ven. 14 déc. 2018 à 11:44, Roberto Cortez
a écrit :
> It seems the build just randomly fails with this test:
> AutoConnectionTrackerTest.test
>
> [ERROR] Failures:
> [ERROR] AutoConnectionTrackerTest.test:198 expected:<1> but was:<0>
>
>
It seems the build just randomly fails with this test:
AutoConnectionTrackerTest.test
[ERROR] Failures:
[ERROR] AutoConnectionTrackerTest.test:198 expected:<1> but was:<0>
Sometimes it passes, sometimes it fails. I suspect it may be related with some
timing issues / box speed of the build
I'll take the first one first
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Wed, Dec 12, 2018 at 5:21 PM Roberto Cortez
wrote:
> Thank you JL,
>
> At least this test is failing:
> org.apache.openejb.config.rules.CheckMissingClassTest
>
> And this one
Thank you JL,
At least this test is failing:
org.apache.openejb.config.rules.CheckMissingClassTest
And this one seems to fail randomly.
org.apache.openejb.resource.AutoConnectionTrackerTest
Cheers,
Roberto
> On 12 Dec 2018, at 16:18, Jean-Louis Monteiro
> wrote:
>
> I have merged a couple
I have merged a couple of PR and I'm running a full build locally. I'll
work on fixes any issues if I find some but I'll report first here
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Wed, Dec 12, 2018 at 3:33 PM Roberto Cortez
wrote:
> Hey Jon,
>
> The
Hi Cesar,
> This is a valuable piece of information.
That's what I thohght, too when I read the information on IRC ...
Thanks that you want to preserve it on the website.
The JIRA task is now assigned to you.
Frankie
--
Sent from:
Thanks, Jean-Louis and Roberto,
This is a valuable piece of information.
I'm planning to open a PR to add this information to the
http://tomee.apache.org/community/ section under an "Infra" (or maybe
"Continous Integration") category. (Suggestion?)
I created
Yes you can do that with IRC
Le mar. 11 déc. 2018 à 04:27, César Hernández Mendoza
a écrit :
> Hi,
> Is there a way to trigger a Buildbot just against current master and not
> related with a specific PR?
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8
>
>
> El lun., 10 dic. 2018 a las
Pulling and building it now :). Thanks Dani!
On Mon, Dec 10, 2018 at 2:23 PM Daniel Cunha wrote:
> Nice!
>
> PR opened: https://github.com/apache/tomee/pull/267
>
> Em seg, 10 de dez de 2018 às 11:01, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> escreveu:
>
> > Awesome, SNAPSHOT is
Nice!
PR opened: https://github.com/apache/tomee/pull/267
Em seg, 10 de dez de 2018 às 11:01, Jonathan Gallimore <
jonathan.gallim...@gmail.com> escreveu:
> Awesome, SNAPSHOT is good. Send a PR :)
>
>
> On Mon, Dec 10, 2018 at 1:45 PM Daniel Cunha
> wrote:
>
> > Hi folks,
> >
> > The fix for
Awesome, SNAPSHOT is good. Send a PR :)
On Mon, Dec 10, 2018 at 1:45 PM Daniel Cunha wrote:
> Hi folks,
>
> The fix for testes below is already on bval master branch.
> Just update bval to 2.0.1-SNAPSHOT and it will be fixed.
>
> DuplicateConfigurationTest
> XMLConfigurationTest
>
For the moment we can use the snapshot and monotor when bval is released
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Mon, Dec 10, 2018 at 2:45 PM Daniel Cunha wrote:
> Hi folks,
>
> The fix for testes below is already on bval master branch.
> Just
Hi folks,
The fix for testes below is already on bval master branch.
Just update bval to 2.0.1-SNAPSHOT and it will be fixed.
DuplicateConfigurationTest
XMLConfigurationTest
XMLConfiguredConstraintValidatorTest
Can we use SNAPSHOT for now or wait for the next bval release?
Em dom, 9 de dez de
Agree on both.
> On 9 Dec 2018, at 07:52, Jean-Louis Monteiro wrote:
>
> I only fixed the 2 imports for checkstyle
>
> I don't think from an end user perspective the information is very
> important in the changelog so did not created any ticket.
>
> If everyone thinks this is important for
I only fixed the 2 imports for checkstyle
I don't think from an end user perspective the information is very
important in the changelog so did not created any ticket.
If everyone thinks this is important for the user. I'm happy to create one.
In that area I don't think it makes sense either to
Overlooked that, sorry.
I intended to concentrate on the documentation for contribution workflow,
that's why I asked.
So no problem if Jean-Louis picks it up.
And: what about a JIRA ticket for that ... ? ;-)
--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
Ok Jon,
I'll work on these tests.
Thanks.
Em sex, 7 de dez de 2018 às 16:23, Jonathan Gallimore <
jonathan.gallim...@gmail.com> escreveu:
> Thanks Dani.
>
> That's right, and these two as well:
>
> XMLConfigurationTest
> - XMLConfiguredConstraintValidatorTest
>
> On Fri, 7 Dec 2018, 18:20
Thanks Dani.
That's right, and these two as well:
XMLConfigurationTest
- XMLConfiguredConstraintValidatorTest
On Fri, 7 Dec 2018, 18:20 Daniel Cunha Hey Jon,
>
> I can help with BVal tests.
> If I get it is the BVal test related DuplicateConfigurationTest right?
>
>
> Em sex, 7 de dez de 2018
Hey Jon,
I can help with BVal tests.
If I get it is the BVal test related DuplicateConfigurationTest right?
Em sex, 7 de dez de 2018 às 14:03, Jonathan Gallimore <
jonathan.gallim...@gmail.com> escreveu:
> Filed a ticket: https://issues.apache.org/jira/browse/TOMEE-2330. We could
> ignore the
Filed a ticket: https://issues.apache.org/jira/browse/TOMEE-2330. We could
ignore the test in the meantime.
Jon
On Fri, Dec 7, 2018 at 4:36 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> I committed a fix for CustomOrmXmlTest. The failure in CmpMappingsTest
> actually looks like
I committed a fix for CustomOrmXmlTest. The failure in CmpMappingsTest
actually looks like a genuine error case that only affects
Plume/EclipseLink. I'm digging in.
Does someone want to take the BVal tests off me? Not required, but if
someone is looking for something to do, I'm happy to hand
Looks like a CXF upgrade changed the API CXF is implementing. If we upgrade
the API on our MicroProfile module then we won't be 1.3 compliant.
But other solution is to downgrade CXF to match MP 1.3 which has
rest-client 1.0
I'd rather get TomEE 8 to be upgraded in regards to MP so we support MP
Hi folks,
Thank you for working on this.
Were we able to determine the cause of all these issues? When we did the M1
release and even after that we had green builds, so it seems we did something
that broke a lot of tests?
Cheers,
Roberto
> On 7 Dec 2018, at 15:05, Jean-Louis Monteiro wrote:
The rest-client seems to be a version issue
[ERROR]
testInvokesPostOperation(org.eclipse.microprofile.rest.client.tck.cditests.CDIInvokeWithRegisteredProvidersTest)
Time elapsed: 0.521 s <<< FAILURE!
java.lang.NoSuchMethodError:
The Duplicate one is also BVal Jon.
I'l looking at the rest-client part.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Fri, Dec 7, 2018 at 2:55 PM Jean-Louis Monteiro
wrote:
> JmsInjectionTests works locally
> --
> Jean-Louis Monteiro
>
JmsInjectionTests works locally
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Fri, Dec 7, 2018 at 11:52 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:
> I have been digging and running tests locally.
> Here is the list of tests failures I have
I see this also fails on
buildbot: org.apache.openejb.arquillian.tests.cmp.sample.CustomOrmXmlTest -
its a simple fix which I'll commit now.
Jon
On Fri, Dec 7, 2018 at 11:05 AM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> Hey Jean-Louis
>
> Thanks for the list!
>
> These ones
Hey Jean-Louis
Thanks for the list!
These ones _should_ be fixed (as of late yesterday)
- LegacyServerTest
- LegacyClientTest
- (StickyConnection|RoundRobin|Random)StrategyTest
- ReconnectDelayCaseInsensitiveTest
- ReconnectDelayListSelfTest
- ReconnectTest
Its possible you didn't have my
I have been digging and running tests locally.
Here is the list of tests failures I have extracted.
- JMSInjectionTest
- CDIInvokeSimpleGetOperationTest
- CDIInvokeWithRegisteredProviderTest
- FeatureRegistrationTest
- InvokeWithJsonProviderTest
- DuplicateConfigurationTest
- XMLConfigurationTest
I've merged a few PRs in which appear to have kept the build in the same
state. I also fixed up the itest failures. I'll work on bval tomorrow. I
get failures with the MicroProfile REST client locally, so if someone can
take a look at that, that would be great.
Thanks
Jon
On Tue, Dec 4, 2018 at
Actually I just cherry-picked this for both branches - seems to have merged
cleanly, so building and pushing.
Jon
On Thu, Dec 6, 2018 at 8:41 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> Hi Dani
>
> Do you want to have a go at backporting my changes to your PR? The SHAs
> you
Hi Dani
Do you want to have a go at backporting my changes to your PR? The SHAs you
need are these ones: https://github.com/apache/tomee/pull/258/commits
Jon
On Thu, Dec 6, 2018 at 8:03 PM Daniel Cunha wrote:
> Hi Jon,
>
> Thank you for your fix, it also need to be applied on branch 7.0.1
Hi Jon,
Thank you for your fix, it also need to be applied on branch 7.0.1 and on
7.1.x I need update my PR with your changes [
https://github.com/apache/tomee/pull/236]
Em qui, 6 de dez de 2018 às 13:58, Jonathan Gallimore <
jonathan.gallim...@gmail.com> escreveu:
> Filed a ticket for bval
Filed a ticket for bval failures and will work on that next.
https://issues.apache.org/jira/browse/TOMEE-2327
Jon
On Thu, Dec 6, 2018 at 3:31 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> Hopefully this will do the trick: https://github.com/apache/tomee/pull/258.
> Full build
Hopefully this will do the trick: https://github.com/apache/tomee/pull/258.
Full build currently running here.
Jon
On Thu, Dec 6, 2018 at 10:46 AM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> I believe this is the root cause of these test failures:
>
> WARNING: Failed to invoke
I believe this is the root cause of these test failures:
WARNING: Failed to invoke bootstrap:
javax/persistence/spi/PersistenceUnitInfo
Exception in thread "main" java.lang.NoClassDefFoundError:
org/apache/commons/cli/ParseException
at java.lang.Class.getDeclaredConstructors0(Native Method)
at
Looks like we have some new failures in the itest module:
[ERROR] RandomConnectionStrategyTest.test:162 » Naming Cannot lookup
'/CalculatorBeanR...
[ERROR] ReconnectDelayCaseInsensitiveTest.test:150 » Naming Cannot lookup
'/Calculator...
[ERROR] ReconnectDelayListSelfTest.test:150 »
Oups, then I believe I need to apologize guys.
I wanted to at least fix the 2 imports so we can get a build with some
results.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Wed, Dec 5, 2018 at 1:24 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com>
I appreciate that. Can I ask you be mindful that Frankie posted, and I
asked him if he wanted to have a go in my reply? We should give him some
time to respond, before someone else picks it up. If Frankie worked on
fixing those, and then found someone else had done the same work without a
JIRA, I
I can help fixing some of those
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> Hi,
>
> Great question. The commands are:
>
> Checkstyle: mvn -Pstyle checkstyle:check
>
Hi,
Great question. The commands are:
Checkstyle: mvn -Pstyle checkstyle:check
PMD: mvn -Pstyle pmd:check
These are relatively quick to run - about a minute or so.
Looks like we have 2 checkstyle violations in the build at the moment:
What can I do to already detect such problems when I work on the code?
What is the difference on the build system? (additional checkstyle rules
...?
Frankie
--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
82 matches
Mail list logo
