Re: [PR] TOMEE-2102: IvmContext bind/unbind creates duplicate contexts

2017-07-25 Thread Svetlin Zarev
Thanks! 2017-07-25 11:24 GMT+03:00 Jonathan Gallimore : > Thanks for this Svetlin, I've merged it in. > > Cheers! > > Jon > > On Mon, Jul 24, 2017 at 10:53 PM, Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > Hi Svetlin, > > > > Many thanks for the writeup - really helpful. I'm

Re: [PR] TOMEE-2102: IvmContext bind/unbind creates duplicate contexts

2017-07-25 Thread Jonathan Gallimore
Thanks for this Svetlin, I've merged it in. Cheers! Jon On Mon, Jul 24, 2017 at 10:53 PM, Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Hi Svetlin, > > Many thanks for the writeup - really helpful. I'm reviewing now. > > Jon > > On Fri, Jul 21, 2017 at 12:43 PM, Svetlin Zarev < >

Re: [PR] TOMEE-2102: IvmContext bind/unbind creates duplicate contexts

2017-07-24 Thread Jonathan Gallimore
Hi Svetlin, Many thanks for the writeup - really helpful. I'm reviewing now. Jon On Fri, Jul 21, 2017 at 12:43 PM, Svetlin Zarev < svetlin.angelov.za...@gmail.com> wrote: > Hi, > > Yesterday the topic was hijaced by unrelated issues, so I'd like to restart > the discussion. > > > The issue is t

[PR] TOMEE-2102: IvmContext bind/unbind creates duplicate contexts

2017-07-21 Thread Svetlin Zarev
Hi, Yesterday the topic was hijaced by unrelated issues, so I'd like to restart the discussion. The issue is that bind() may create alternative NameNodes for the very same JNDI name, which results in issues such as being able to bind to objects to the same JNDI name, or being unable to lookup an

Re: [jira] [Commented] (TOMEE-2102) IvmContext bind/unbind creates duplicate contexts

2017-07-20 Thread Jonathan Gallimore
> > > > > > > Thanks Svetlin - I'll review later today. I'm currently getting > some > > > > > IvmContextTest test failures on master - I'll send over a list. > Happy > > > to > > > > > help fix

Re: [jira] [Commented] (TOMEE-2102) IvmContext bind/unbind creates duplicate contexts

2017-07-20 Thread Svetlin Zarev
s on master - I'll send over a list. Happy > > to > > > > help fix these. > > > > > > > > Jon > > > > > > > > On Thu, Jul 20, 2017 at 9:19 AM, ASF GitHub Bot (JIRA) < > > j...@apache.org> > > >

Re: [jira] [Commented] (TOMEE-2102) IvmContext bind/unbind creates duplicate contexts

2017-07-20 Thread Romain Manni-Bucau
wrote: > > > > > >> > > >> [ https://issues.apache.org/jira/browse/TOMEE-2102?page=com. > > >> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane > > >> l&focusedCommentId=16094340#comment-16094340 ] > > >> > >

Re: [jira] [Commented] (TOMEE-2102) IvmContext bind/unbind creates duplicate contexts

2017-07-20 Thread Svetlin Zarev
entId=16094340#comment-16094340 ] > >> > >> ASF GitHub Bot commented on TOMEE-2102: > >> --- > >> > >> GitHub user SvetlinZarev opened a pull request: > >> > >> https://github.com/apache/tomee

Re: [jira] [Commented] (TOMEE-2102) IvmContext bind/unbind creates duplicate contexts

2017-07-20 Thread Jonathan Gallimore
> l&focusedCommentId=16094340#comment-16094340 ] >> >> ASF GitHub Bot commented on TOMEE-2102: >> --- >> >> GitHub user SvetlinZarev opened a pull request: >> >> https://github.com/apache/tomee/pull/94 >>

TOMEE-2102: IvmContext bind/unbind creates duplicate contexts

2017-07-20 Thread Svetlin Zarev
Hi, While i was trying to simplify my IvmTests I stubmbled on another bug in IvmContext - thi stime in bind()/unbind(). The issue is simple -> if bind()-ing from a "relative" node (for instance lets have "a/b/c", and you try to do b.bind(x, obj) instead of root.bind("a/b/x", obj)), bind() binds th

Re: [jira] [Commented] (TOMEE-2102) IvmContext bind/unbind creates duplicate contexts

2017-07-20 Thread Jonathan Gallimore
gt; > https://github.com/apache/tomee/pull/94 > > TOMEE-2102: IvmContext bind/unbind creates duplicate contexts > > > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/SvetlinZarev/tomee fixBindUndbind > > A