[PR] Improve failed startup follow-up exceptions and back to OWB snapshot (tomee)

2024-01-16 Thread via GitHub
tandraschko opened a new pull request, #1093: URL: https://github.com/apache/tomee/pull/1093 OWB contains new 2 fixes, one is necessary for JSF applications as some ELs are not resolveable anymore -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Improve failed startup follow-up exceptions and back to OWB snapshot (tomee)

2024-01-16 Thread via GitHub
tandraschko commented on PR #1093: URL: https://github.com/apache/tomee/pull/1093#issuecomment-1893263540 @rzo1 yep i can make a new PR later, or if you have 1 min, would be great can you do it -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Regenerated BOMs after dependency upgrades (tomee)

2024-01-16 Thread via GitHub
rzo1 merged PR #1094: URL: https://github.com/apache/tomee/pull/1094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

Re: [PR] Improve failed startup follow-up exceptions and back to OWB snapshot (tomee)

2024-01-16 Thread via GitHub
rzo1 commented on PR #1093: URL: https://github.com/apache/tomee/pull/1093#issuecomment-1893259476 @tandraschko From my understanding this should fix

Re: [PR] Fixed exclusions (related to TOMEE-4294) (tomee)

2024-01-16 Thread via GitHub
jungm commented on PR #1092: URL: https://github.com/apache/tomee/pull/1092#issuecomment-1893360536 This also applies to 9.x (note how smallrye-health pulls in cdi/jsonp): ``` tomee/tomee/tomee-microprofile/mp-common ➜ mvn dependency:tree [INFO] Scanning for projects... [INFO]

Re: [PR] Improve failed startup follow-up exceptions and back to OWB snapshot (tomee)

2024-01-16 Thread via GitHub
rzo1 merged PR #1093: URL: https://github.com/apache/tomee/pull/1093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

Re: [PR] Improve failed startup follow-up exceptions and back to OWB snapshot (tomee)

2024-01-16 Thread via GitHub
rzo1 commented on PR #1093: URL: https://github.com/apache/tomee/pull/1093#issuecomment-1893264281 Yeah, I will merge this and re-enable the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Regenerated BOMs after dependency upgrades (tomee)

2024-01-16 Thread via GitHub
github-actions[bot] opened a new pull request, #1094: URL: https://github.com/apache/tomee/pull/1094 Found some uncommited changes (from BOM regeneration) after running build on TomEE main -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fixed exclusions (related to TOMEE-4294) (tomee)

2024-01-16 Thread via GitHub
rzo1 commented on PR #1092: URL: https://github.com/apache/tomee/pull/1092#issuecomment-1893368212 Thanks @jungm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fixed dependency exclusions + enhanced logging (tomee)

2024-01-16 Thread via GitHub
rzo1 merged PR #1095: URL: https://github.com/apache/tomee/pull/1095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

Re: [PR] Regenerated BOMs after dependency upgrades (tomee)

2024-01-16 Thread via GitHub
rzo1 merged PR #1099: URL: https://github.com/apache/tomee/pull/1099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

Re: [PR] use MyFaces SNAPSHOT for now (tomee)

2024-01-16 Thread via GitHub
rzo1 merged PR #1098: URL: https://github.com/apache/tomee/pull/1098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

[PR] use MyFaces SNAPSHOT for now (tomee)

2024-01-16 Thread via GitHub
tandraschko opened a new pull request, #1098: URL: https://github.com/apache/tomee/pull/1098 i fixed a blocker bug there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Regenerated BOMs after dependency upgrades (tomee)

2024-01-16 Thread via GitHub
github-actions[bot] opened a new pull request, #1099: URL: https://github.com/apache/tomee/pull/1099 Found some uncommited changes (from BOM regeneration) after running build on TomEE main -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [DRAFT] WIP on Concurrency work (tomee)

2024-01-16 Thread via GitHub
rzo1 commented on PR #1090: URL: https://github.com/apache/tomee/pull/1090#issuecomment-1893414477 Let's see how it looks for a full build, so people can get a chance to dig into test failures: https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/64/ -- This is an automated

Re: [PR] Backport #1092 to tomee-9.x (tomee)

2024-01-16 Thread via GitHub
rzo1 merged PR #1096: URL: https://github.com/apache/tomee/pull/1096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

Re: [PR] Backport #1092 to tomee-9.x (tomee)

2024-01-16 Thread via GitHub
rzo1 commented on PR #1096: URL: https://github.com/apache/tomee/pull/1096#issuecomment-1893553067 Thanks @jungm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fixed dependency exclusions + enhanced logging (tomee)

2024-01-16 Thread via GitHub
rzo1 commented on code in PR #1095: URL: https://github.com/apache/tomee/pull/1095#discussion_r1453292819 ## pom.xml: ## @@ -224,7 +224,7 @@ 4.0.1 -6.3.1.Final +6.4.1.Final Review Comment: There might be other occurences of Hibernate in the

[PR] Fixed dependency exclusions + enhanced logging (tomee)

2024-01-16 Thread via GitHub
tandraschko opened a new pull request, #1095: URL: https://github.com/apache/tomee/pull/1095 - OWB e.g. switched from geronimo to jakarta - i added both exclusions to MF as the master switched to jakarta there, but 4.0.x is still geronimo - added logging to

[PR] Regenerated BOMs after dependency upgrades (tomee)

2024-01-16 Thread via GitHub
github-actions[bot] opened a new pull request, #1097: URL: https://github.com/apache/tomee/pull/1097 Found some uncommited changes (from BOM regeneration) after running build on TomEE 9.x branch -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Regenerated BOMs after dependency upgrades (tomee)

2024-01-16 Thread via GitHub
rzo1 merged PR #1097: URL: https://github.com/apache/tomee/pull/1097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

[PR] Backport #1092 to tomee-9.x (tomee)

2024-01-16 Thread via GitHub
jungm opened a new pull request, #1096: URL: https://github.com/apache/tomee/pull/1096 New dependency tree with the following exclusions: - CDI/JSON-P - glassfish json/parsson -> We should use johnzon instead - smallrye-health-api -> custom [vendor specific