Re: Any EE8 spec API releases needed?

[Mark Struberg]

It's on my list to review that one. 

txs and LieGrue,
strub

> Am 17.06.2017 um 22:11 schrieb Svetlin Zarev 
> :
> 
> Hi Mark,
> 
> Have you considered fixing
> https://issues.apache.org/jira/browse/GERONIMO-6569 ? It's about common
> annotations spec compliance.
> 
> Kind regards,
> SVetlin
> 
> 2017-06-17 19:37 GMT+03:00 Mark Struberg :
> 
>> Hi folks!
>> 
>> I'm about to release the common-annotation-1.3 and jcdi-2.0 APIs over in
>> Geronimo.
>> Does TomEE also need some API to be released?
>> Would like to do things only once if possible ;)
>> 
>> txs and LieGrue,
>> strub

Re: Any EE8 spec API releases needed?

[Svetlin Zarev]

Hi Mark,

Have you considered fixing
https://issues.apache.org/jira/browse/GERONIMO-6569 ? It's about common
annotations spec compliance.

Kind regards,
SVetlin

2017-06-17 19:37 GMT+03:00 Mark Struberg :

> Hi folks!
>
> I'm about to release the common-annotation-1.3 and jcdi-2.0 APIs over in
> Geronimo.
> Does TomEE also need some API to be released?
> Would like to do things only once if possible ;)
>
> txs and LieGrue,
> strub

Re: The EE8 Roadmap

[Mark Struberg]

FYI, With help from Romain, Reinhard Sandtner, Gerhard Petracek and John Ament, 
 Apache OpenWebBeans now passes the CDI-2.0 TCK!

The next step is to do a bit more testing, release the missing Geronimo spec 
APIs and then we are good to go for rolling TomEE-8.0.0 ^^

LieGrue,
strub


 
> Am 05.06.2017 um 12:59 schrieb Jean-Louis Monteiro :
> 
> Wow, great status Mark.
> Thanks a lot.
> 
> Yes, agree, TomEE 8.x seems to be the de facto choice based on what the
> community decided last time.
> Even though the time is missing I'd like to help somehow and join the
> effort.
> 
> I'll shoot when I have some time.
> 
> Cheers.
> 
> 
> 
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
> 
> On Fri, Jun 2, 2017 at 8:55 PM, Romain Manni-Bucau 
> wrote:
> 
>> 2017-06-02 20:27 GMT+02:00 Mark Struberg :
>> 
>>> Hi folks!
>>> 
>>> Behind the scene there was a lot of work done towards EE8.
>>> Not directly in TomEE, but in most parts which are needed
>>> 
>>> * Tomcat 9 for Servlet 4.0 - While the final API is not yet ready we
>>> already have many public Milestone builds
>>> 
>>> * OpenWebBeans-2.0.x for CDI 2.0 - We already implemented most of the new
>>> features and are down to 35 failing TCK tests (out of 1300). Might take
>> us
>>> 2 more weeks to finish, but we are already very close
>>> 
>>> * BVal - Matt Benson is working like wild for implementing the new spec
>>> changes. Once OWB is finished Romain and I will join the effort with more
>>> power. Others are welcome to help of course!
>>> 
>>> * Johnzon for JSON-P 1.1 and JSON-B 1.0: 1.1.1 is currently being
>>> released. Works like a charm!
>>> 
>>> * MyFaces - gonna need to check the latest status, but I think Leo has
>>> already implemented most things
>>> 
>>> * OpenJPA - lags a bit behind, but there have been no changes so far in
>>> JPA for EE8 anyway
>>> 
>>> * Geronimo - we have quite a few new spec versions to be released. Most
>>> are already implemented and just need to get released once the specs go
>>> final and we can compare our signatures with the ones from the official
>>> artifacts.
>>> 
>>> 
>>> How to name the baby? TomEE-8.0.0 seems quite natural to me, wdyt?
>>> 
>>> 
>> Well no real choice we moved to 7 recently with this engagement for at
>> least a moment.
>> 
>> 
>>> When to branch away from trunk?
>>> 
>> 
>> When at least OWB is fully ready I'd say and 7.0.4 out, can do it soon if
>> it helps
>> 
>> 
>>> After OWB is finished?
>>> 
>>> 
>> Hehe seems we agree ;)
>> 
>> 
>>> C'mon, tell me what you think, lords and ladies!
>>> 
>>> LieGrue,
>>> strub
>>> 
>>> 
>>> 
>>> 
>> 

Re: CompManagedBean & @DatasourceDefinition - TOMEE-2053

[Romain Manni-Bucau]

You rock Svetlin, applied, thanks a lot!


Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | JavaEE Factory


2017-06-17 7:56 GMT+02:00 Svetlin Zarev :

> Hi,
>
> Here it is: https://github.com/apache/tomee/pull/74
>
> Kind regards,
> Svetlin
>
>
> 2017-06-16 23:44 GMT+03:00 Svetlin Zarev  >:
>
> > The test fails, because the @DataSourceDefinition is used on a POJO -
> i.e.
> > it's not a JndiConsumer, hence the ConvertDataSourceDefinitions deployer
> > cannot know that such definition exists. I'll have to check the spec if
> it
> > mentions which classes can be annotated with @DataSourceDefinition, but
> > either way it would be easy to fix. I'll take a look tomorrow :)
> >
> > Kind regards,
> > Svetlin
> >
> > 2017-06-16 22:37 GMT+03:00 Romain Manni-Bucau :
> >
> >> Trunk seems to have an issue with this in the test
> >> XADataSourceDefinitionTest
> >>
> >> Want to have a look?
> >>
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau  |  Blog
> >>  | Old Blog
> >>  | Github <
> >> https://github.com/rmannibucau> |
> >> LinkedIn  | JavaEE Factory
> >> 
> >>
> >> 2017-06-16 20:46 GMT+02:00 Romain Manni-Bucau :
> >>
> >> > applied, thanks!
> >> >
> >> >
> >> > Romain Manni-Bucau
> >> > @rmannibucau  |  Blog
> >> >  | Old Blog
> >> >  | Github
> >> >  | LinkedIn
> >> >  | JavaEE Factory
> >> > 
> >> >
> >> > 2017-06-16 20:33 GMT+02:00 Svetlin Zarev
>  >> om>
> >> > :
> >> >
> >> >> I've fixed the license headers. Here is the PR:
> >> >> https://github.com/apache/tomee/pull/73
> >> >>
> >> >> I didn't check JMS, only WepProfile specs.
> >> >>
> >> >> 2017-06-16 21:01 GMT+03:00 Romain Manni-Bucau  >:
> >> >>
> >> >> > This looks good, while the merge deployer still makes available the
> >> >> > resource to comp it works :)
> >> >> >
> >> >> > Think you need to fix details on your PR like headers etc but looks
> >> ok
> >> >> to
> >> >> > merge once the build pass.
> >> >> >
> >> >> > Side note: by curiosity, did you check jms resource as well? it
> >> should
> >> >> be
> >> >> > close ot datasources.
> >> >> >
> >> >> >
> >> >> > Romain Manni-Bucau
> >> >> > @rmannibucau  |  Blog
> >> >> >  | Old Blog
> >> >> >  | Github  >> >> > rmannibucau> |
> >> >> > LinkedIn  | JavaEE
> Factory
> >> >> > 
> >> >> >
> >> >> > 2017-06-16 19:56 GMT+02:00 Svetlin Zarev
> >>  >> >> om
> >> >> > >:
> >> >> >
> >> >> > > I'm back with tests:) :
> >> >> > > https://github.com/apache/tomee/compare/master...
> >> >> > > SvetlinZarev:ds_def?expand=1
> >> >> > >
> >> >> > > Unless I misunderstood you, it seems that DS injection in servlet
> >> >> works
> >> >> > > after the fix and does not before it (well, it injects it, but
> with
> >> >> wrong
> >> >> > > config).
> >> >> > > The reason it works is that the ConvertDataSourceDefinitions
> >> deployer
> >> >> > only
> >> >> > > processes the DataSource definitions by converting them to
> Resource
> >> >> > objects
> >> >> > > which are not associated with specific component, and since the
> >> >> > > CompManagedBean does not have its own, unique definitions, if we
> >> >> exclude
> >> >> > it
> >> >> > > from processing in that specific deployer we won't lose anything,
> >> >> because
> >> >> > > data sources with the same IDs ( and with correct config !) will
> be
> >> >> > pulled
> >> >> > > from the JndiConsumers that actually provide them.
> >> >> > >
> >> >> > > So to summarize, the flow before the proposed fix is:
> >> >> > > 1. Collect all JndiConsumers
> >> >> > > 2. MyBean -> provide DataSource with correct config
> >> >> > > 3. CompManagedBean -> overwrite MyBean's datasource, with one
> with
> >> bad
> >> >> > > config
> >> >> > > 4. We end up with one resource with bad config
> >> >> > >
> >> >> > > And after the fix it becomes:
> >> >> > > 1. Collect all JndiConsumers
> >> >> > > 2. MyBean -> provide DataSource with correct config
> >> >> > > 3. We end up with one resource with good config
> >> >> > >
> >>