Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
Hmm, you close the classloader before it is used so it is no more usable
normally - or it will leak.
Side question: any issue having an impl os ClassPath using the classloader
to keep
Github user danielsoro commented on the issue:
https://github.com/apache/tomee/pull/176
Ok @rmannibucau,
sent the correct patch, let me know what do you think.
Thank you!
---
Github user danielsoro commented on the issue:
https://github.com/apache/tomee/pull/176
Ohh.. sorry I sent the wrong patch.
Pushing the correct one.
---
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
Hope i didnt misread the diff (starts to be late ;)) but it misses a close
and the urlclassloader cast will not work on all java versions right?
---
Github user danielsoro commented on the issue:
https://github.com/apache/tomee/pull/176
Hi @rmannibucau,
patch updated. It seems to look better now.
Please, review it and thank you for all the help, I really appreciate it.
---
Github user danielsoro commented on the issue:
https://github.com/apache/tomee/pull/176
@rmannibucau,
Nice.. working on it.
Thank you! :)
---
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
Yes, this is what i had in mind as well. That said if it is just for our
CLI your hack is fine, we should just lock it for other cases like
openejb-standalone
---
Github user danielsoro commented on the issue:
https://github.com/apache/tomee/pull/176
@rmannibucau,
TomEE is not showing any exception when running with j11 (I was able to
start and deploy a simple application on it really fine), that is not the issue.
It just
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/176
well some thoughts:
1. most of the time we dont need this dynamism so maybe we can just rework
the distro and delete it
2. we already hack equals/hashcode in cxf container loader but
Github user danielsoro commented on the issue:
https://github.com/apache/tomee/pull/176
Hey @rmannibucau,
I updated it to call `close` and also now we call the
ClassLoader.registerAsParallelCapable(); in a static block.
hashcode and equals still using the super, the
I think we can add it.
Also, I think we wanted to be careful about it, so to not disrupt any of the
other profiles and people could test it.
We could add MP specs for M2.
> On 23 Oct 2018, at 08:26, Jonathan Gallimore
> wrote:
>
> I'd also like to see it part of Plus and Plume. It adds
Exactly.
Cheers,
Roberto
> On 22 Oct 2018, at 10:22, COURTAULT Francois
> wrote:
>
> Hello Roberto,
>
> So if I have understood you well TomEE MP is TomEE Web Profile + MP
> specifications, right ?
>
> Best Regards.
>
> -Original Message-
> From: Roberto Cortez
I'd also like to see it part of Plus and Plume. It adds about 3MB to the
distribution size. Any other thoughts?
Jon
On Tue, Oct 23, 2018 at 4:44 PM dkwakkel wrote:
> I was also planning to use Plus and expected micro profile being part of
> it.
> We don't see that our customers maintain their
I was also planning to use Plus and expected micro profile being part of it.
We don't see that our customers maintain their own distro. We just instruct
them how to download/install tomee.
Could you reconsider making microprofile part of Plus?
--
Sent from:
GitHub user brunobat opened a pull request:
https://github.com/apache/tomee/pull/178
TOMEE-2261 - Make service.bat compatible with JDK11+
Detect java version and act on it. After java 11:
- Remove jre references because they are invalid when using the JDK.
- Remove
15 matches
Mail list logo
