[GitHub] tomee pull request #178: TOMEE-2261 - Make service.bat compatible with JDK11...

2018-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/178 ---

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-24 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 @rmannibucau I get it, but we isolate it just for the CLI. What is the scenario which you are seeing which can break something with that change? It should not have any impact on the

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-24 Thread rmannibucau
Github user rmannibucau commented on the issue: https://github.com/apache/tomee/pull/176 @danielsoro if you change the classloader it can impact the users relying on that (it can be the case if they tune java or use system classloader only libs. This is rare but already saw it. This

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-10-24 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 @rmannibucau, Yeah, I'm closing it before, going to fix it. I didn't get your question about j8's user, but it should not have an impact on j8's user. ---