Re: Fwd: svn commit: r1612260 - in /tomee/tomee/branches/tomee-1.7.x/container/openejb-core/src: main/java/org/apache/openejb/core/stateless/ main/java/org/apache/openejb/util/ test/java/org/apache/op

2014-07-21 Thread Romain Manni-Bucau
:) Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-07-21 18:51 GMT+02:00 Andy Gumbrecht : > Sure, I didn't just choose to add a lock for no reason. I removed the lock >

Re: Fwd: svn commit: r1612260 - in /tomee/tomee/branches/tomee-1.7.x/container/openejb-core/src: main/java/org/apache/openejb/core/stateless/ main/java/org/apache/openejb/util/ test/java/org/apache/op

2014-07-21 Thread Andy Gumbrecht
Sure, I didn't just choose to add a lock for no reason. I removed the lock now and replaced the hashmap with a concurrent one, so it'll bite us if it doesn't like it ;) Andy. On 21/07/2014 15:53, Romain Manni-Bucau wrote: previous lock? well this part shouldn't lock at all IMO Romain Mann

Re: Fwd: svn commit: r1612260 - in /tomee/tomee/branches/tomee-1.7.x/container/openejb-core/src: main/java/org/apache/openejb/core/stateless/ main/java/org/apache/openejb/util/ test/java/org/apache/op

2014-07-21 Thread Romain Manni-Bucau
previous lock? well this part shouldn't lock at all IMO Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-07-21 15:50 GMT+02:00 Andy Gumbrecht : > The previous lock was

Re: Fwd: svn commit: r1612260 - in /tomee/tomee/branches/tomee-1.7.x/container/openejb-core/src: main/java/org/apache/openejb/core/stateless/ main/java/org/apache/openejb/util/ test/java/org/apache/op

2014-07-21 Thread Andy Gumbrecht
The previous lock was inconsistent, half internal and half external - So rather than remove the lock/synchronization entirely without knowing the consequences it was better to ensure the lock was consistent. Andy. On 21/07/2014 15:19, Romain Manni-Bucau wrote: Hi Andy Why is this lock needed