Re: Growing number of pull requests

2014-04-21 Thread Romain Manni-Bucau
patch -p0 6.patch Oops that's a git patch and then you need a good bash script to get it on svn or simply apply it on git then diff in svn format...not efficient and on update/upgrade patches can just be too hard. Le 20 avr. 2014 21:24, David Blevins david.blev...@gmail.com a écrit : What

Re: Growing number of pull requests

2014-04-21 Thread Jean-Louis Monteiro
add .diff instead of .patch should be enough -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Apr 21, 2014 at 8:55 AM, Romain Manni-Bucau rmannibu...@gmail.comwrote: patch -p0 6.patch Oops that's a git patch and then you need a good

Re: Growing number of pull requests

2014-04-21 Thread Jean-Louis Monteiro
I mean https://github.com/apache/tomee/pull/6.diff -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Apr 21, 2014 at 11:58 AM, Jean-Louis Monteiro jlmonte...@tomitribe.com wrote: add .diff instead of .patch should be enough --

Re: Growing number of pull requests

2014-04-21 Thread Romain Manni-Bucau
looks better, something to try next time, thanks! Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-04-21 11:59 GMT+02:00 Jean-Louis Monteiro jlmonte...@tomitribe.com: I

Re: Growing number of pull requests

2014-04-20 Thread David Blevins
I think when you submitted your patch the asf hadn't yet improved the github integration. Daniel Gruno (@Humbedooh) has put a lot of work into and would probably do more if we had more ideas for him. -David On Apr 19, 2014, at 9:19 AM, Ivan St. Ivanov ivan.st.iva...@gmail.com wrote: Hey

Re: Growing number of pull requests

2014-04-20 Thread Romain Manni-Bucau
It was but svn/git doesnt work together well enough to have it working well. If we were on git it would be nice. Le 20 avr. 2014 20:44, David Blevins david.blev...@gmail.com a écrit : I think when you submitted your patch the asf hadn't yet improved the github integration. Daniel Gruno

Re: Growing number of pull requests

2014-04-20 Thread David Blevins
What approach did you take? The patch approach should be the same as svn: - https://github.com/apache/tomee/pull/6.patch On Apr 20, 2014, at 1:08 PM, Romain Manni-Bucau rmannibu...@gmail.com wrote: It was but svn/git doesnt work together well enough to have it working well. If we were on

Re: Growing number of pull requests

2014-04-19 Thread Ivan St. Ivanov
Hey folks! Before you start reviewing and merging, maybe it's a good idea for everyone of us that has submitted a pull request, to review it. When I did mine, I didn't know that the official path to contribute something was SVN patches. So after I understood that, I made the same change as SVN

Re: Growing number of pull requests

2014-04-19 Thread Romain Manni-Bucau
Ok, we should be up to date and we can close all PR...but applying them is really not as easy as it should. I wouldn't ask guys to do PR while we can apply it to main (svn today) directly. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn:

Re: Growing number of pull requests

2014-04-18 Thread Alan Cabrera
On Apr 18, 2014, at 3:07 PM, David Blevins david.blev...@gmail.com wrote: This is probably not the full list of patches yet to be applied, but a definite good start: - https://github.com/apache/tomee/pulls Andy or anyone else, possible to get some of these cleared out? The