Re: Best Practices for Creating and Merging PRs

2017-03-06 Thread Chip Senkbeil
We don't have access to the GitHub merge PR button, do we? That I'm aware of, Gino, Corey, and I have been manually merging fully-rebased PRs to keep a clean commit history. If the GitHub merge PR button was available, we could use the squash-and-rebase option, which provides a very clean way to b

Best Practices for Creating and Merging PRs

2017-03-06 Thread Luciano Resende
Do we have any set of recommendations on creating and Merging PRs for the Toree Project ? At least on the Merging side, I would like to recommend that we avoid using the GitHub merge PR button as that causes a bunch of not useful commits to be displayed in the commit history such as: "Merging pr #

[jira] [Commented] (TOREE-390) Lazily start Spark sessions

2017-03-06 Thread Luciano Resende (JIRA)
[ https://issues.apache.org/jira/browse/TOREE-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897536#comment-15897536 ] Luciano Resende commented on TOREE-390: --- Are you seeing this issue because you are us