Re: Golang Proxy Validation Dependencies

So, for the vote of using the validation dependencies we had 5 +1's for using the Validation libs So the vote passes, that these dependencies will be used for the Golang Proxy validation rules. This PR will be can now be merged: https://github.com/apache/incubator-trafficcontrol/pull/1766

Re: Golang Proxy Validation Dependencies

+1 On 1/17/18, 5:43 AM, "John Rushford" wrote: +1 Sent from my iPad > On Jan 16, 2018, at 2:07 PM, Dave Neuman wrote: > > +1 > >> On Tue, Jan 16, 2018 at 12:58 Jan van Doorn wrote: >>

Re: Golang Proxy Validation Dependencies

+1 Sent from my iPad > On Jan 16, 2018, at 2:07 PM, Dave Neuman wrote: > > +1 > >> On Tue, Jan 16, 2018 at 12:58 Jan van Doorn wrote: >> >> +1 on using libs. >> >>> On Jan 16, 2018, at 10:52 AM, Dan Kirkwood wrote: >>> >>> +1 --

Re: Golang Proxy Validation Dependencies

+1 on using libs. > On Jan 16, 2018, at 10:52 AM, Dan Kirkwood wrote: > > +1 -- agree with Jeff -- the validation of the fields of > deliveryservice is something that is incomplete in the Perl > traffic_ops. > > These libraries make for concise code to do the validation so

Re: Golang Proxy Validation Dependencies

+1 -- agree with Jeff -- the validation of the fields of deliveryservice is something that is incomplete in the Perl traffic_ops. These libraries make for concise code to do the validation so it will be easier to extend without much extra code. It will not be called on every API function, but

Re: Golang Proxy Validation Dependencies

I don't think we should assume anything about the performance just because it uses reflection. Yes, traditionally reflection is computationally expensive, however, when used properly the penalty can be negligible. I don't think we have enough understanding of these libraries to know whether there

Re: Golang Proxy Validation Dependencies

True, but how many of those out-of-the-box checks are both useful and relevantly complex? To me, the cool part of ozzo is the way it collects the output and formats it. That's unfortunately also the computationally expensive part. On Thu, Jan 11, 2018 at 9:49 AM, Dewayne Richardson

Re: Golang Proxy Validation Dependencies

I like the output style, but I'm a bit concerned on the performance front. ozzo appears to do all it's magic with heavy use of reflection, which is often a slow spot in go. Most places, it wouldn't matter much, but this will be called on every element of every API function, so a nod toward