Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-220791012
@PSUdaemon There's not any issues I'm aware of at the moment.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-220702623
Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-220231207
@chaiman I see what you mean. I'll fix that in a separate ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-219347020
@zwoop done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-219324620
@zwoop I've gone ahead and done that. I don't know how (or if I can) to run
the CI builds so I'll just leave that to you.
---
If your project i
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-210516157
@jpeach Thanks for the comments.
I've addressed the relevant issues you brought up in the force pushed
commits. I've also gone ahead and made
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r59888075
--- Diff: lib/ts/Diags.cc ---
@@ -816,29 +820,39 @@ Diags::set_stdout_output(const char *_bind_stdout)
if (strcmp(_bind_stdout, "&q
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-209691924
@jpeach Is there a preferred framework for unit testing? (ie how/where do I
put the tests?)
---
If your project is set up for it, you can reply to this email and
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r59644646
--- Diff: lib/ts/Diags.cc ---
@@ -716,14 +722,12 @@ Diags::should_roll_outputlog()
bool ret_val = false;
bool need_consider_stderr = true
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/568
TS-4072 Diagnostic log rolling races
This patch prevents race conditions when a diagnostic log rolls. The patch
is a little longer than I had hoped for because of error handling conditions
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/563
TS-4250 fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-4250
Alternatively you can review and apply these
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/558
TS-4250 clang-format breaks on Centos 6
Change clang-format.sh to use native sha1sum command
when available.
You can merge this pull request into a Git repository by running:
$ git
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/483
TS-4214 HttpSM debug message incorrect
The debug message didn't make any sense before since it was
displaying the expected value as actual and vis versa.
You can merge this pull re
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/446
TS-4165 Logging breaks if changing log format
TS wasn't calling `open_file()` on the LogFile it was trying
to rotate away. This was occurring when an existing log file's
form
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/437
TS-4148 Add a log field for connection attempts made to origin
Added a log field `sca` that outputs the number of connection
attempts made to the origin server for the current transaction
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/430
TS-4143 Validate host in GET URL
Also moved all the host validation logic to URL.cc since HTTP.cc
inherits from URL.cc.
You can merge this pull request into a Git repository by running
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/383
TS-4084 Empty README.md file
The empty `README.md` file makes Github not show the
correct README.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/382
TS-4071 Unused mutex Diags::rotate_lock
Removed the unused mutex.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/363#issuecomment-164196139
How does that look now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/367
TS-4057 Missing check for system call error
EPERM and EACCES are often consfused for each other.
EPERM means "operation not permitted", ie doing this would not be
in
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/363#issuecomment-162063591
I'm just going to keep the early return for consistency since there's
already an early return later.
---
If your project is set up for it, you can rep
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/363#issuecomment-162035450
It is marked private. Would your suggestion still be to nest everything
inside the `if (blf != NULL)`? I don't see any reason to keep
`ink_assert(diag
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/363#issuecomment-162032775
`setup_diagslog` is only ever called within the `Diags.cc` constructor. If
you look at the original change in commit b29149c2, you'll see that I actually
m
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/363
TS-4054 Incorrect ink_assert behavior in Diags.cc
`ink_assert(diags_log == NULL)` is incorrect since there are times
when `blf` correctly has the value NULL. In that case, we would
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/356
TS-4043 Prevent bogus FQDN characters in host header
Validate the host header string to prevent malformed hostnames from being
let in.
You can merge this pull request into a Git repository
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/355#issuecomment-160669072
Messed up the commit message -- going to redo this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user danobi closed the pull request at:
https://github.com/apache/trafficserver/pull/355
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/355
YTSATS-659 XSS via Host header for 404
Validate the host header string to prevent malformed hostnames from being
let in.
You can merge this pull request into a Git repository by running
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/329
TS-4003 CID 1338381 & 1022062: in traffic_cop
Fix unchecked `rename()` return for renaming an inaccessible
traffic.out file
Refactor a bit of _correct_ code to please Cove
Github user danobi closed the pull request at:
https://github.com/apache/trafficserver/pull/320
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/325
TS-4000 Extraneous `setvbuf()` in Diags.cc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-4000
Alternatively
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/320#issuecomment-153824370
Looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/320
Log rotation fixes
Fixed coverity & clang-analyzer issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-130400177
Thanks for all the input, I appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36889035
--- Diff: proxy/Makefile.am ---
@@ -46,7 +46,7 @@ AM_CPPFLAGS = \
-I$(top_srcdir)/mgmt \
-I$(top_srcdir)/mgmt/utils \
-I
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36885521
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,578 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36807553
--- Diff: iocore/net/test_certlookup.cc ---
@@ -206,7 +206,8 @@ SSLReleaseContext(SSL_CTX *ctx)
int
main(int argc, const char **argv
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36794702
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36781403
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36778052
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36776891
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772358
--- Diff: cmd/traffic_cop/traffic_cop.cc ---
@@ -767,6 +767,26 @@ spawn_manager()
exit(1);
}
+ // Move any traffic.out that
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36770248
--- Diff: cmd/traffic_crashlog/Makefile.am ---
@@ -20,6 +20,7 @@ bin_PROGRAMS = traffic_crashlog
AM_CPPFLAGS = \
$(iocore_include_dirs
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-129969889
There are a few reasons:
- It makes sense from the user perspective, since they can already control
rotation from records.config of the access & error
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/274
TS-306 Enable log rotation for diags.log & traffic.out
- The commit message contains an architectural overview of this feature
- 'make test' and './traffic_server -R 1&
Github user danobi closed the pull request at:
https://github.com/apache/trafficserver/pull/231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user danobi closed the pull request at:
https://github.com/apache/trafficserver/pull/248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/248
TS-3757 Update documentation to include periodic_tasks_interval
TS-3435 added the new config variable.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user danobi closed the pull request at:
https://github.com/apache/trafficserver/pull/247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/247#issuecomment-120466390
Oops, wrong issue number
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/247
TS-3537 Update documentation to include periodic_tasks_interval
TS-3435 added the new config variable.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/243#issuecomment-120055508
I didn't have any specific reason. It seemed like it wouldn't cause any
problems, so I just added it in.
---
If your project is set up for it, you ca
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/243
TS-3435 Make Log.cc:PERIODIC_TASKS_INTERVAL configurable
Allow interval between periodic tasks in Log.cc to be configured
via records.config. This allows for finer granularity when
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/239
TS-3718 Remove unused member variables/functions
read_metadata() and m_size_bytes are not used anywhere
in the code base.
You can merge this pull request into a Git repository by running
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/231#issuecomment-113644090
Packed a little more. Now down to 4056B.
pahole results [here](http://pastebin.com/rutZmEN7)
---
If your project is set up for it, you can reply to this
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/231#issuecomment-113575571
pahole results for [unpacked](http://pastebin.com/WwLFSrrG)
pahole results for [packed](http://pastebin.com/Cr6jtZac)
Although it looks like there&#
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/231#issuecomment-113320662
Further testing with pahole may be done later, when I get a vm setup with a
supported OS.
---
If your project is set up for it, you can reply to this email and
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/231
TS-2978 Reorder member variables in HttpSM State
Reduce padding by grouping non four byte aligned variables together.
Packing was done by hand, and pretty much only touched bools and chars
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/227
TS-3694: Fix outdated Log::error documentation
Comment for function did not reflect code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/185#issuecomment-11123
Fixed the merge conflicts. Also updated any other uses of ink_get_hrtime()
/ ink_get_based_hrtime() that occurred during the life of this PR.
There&#
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/185#issuecomment-110504046
Fixed. However, I am unsure how to handle all the merge conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/185
TS-1774 Moved gethrtime functions into Thread class
Moved ink_get_hrtime() and ink_get_based_hrtime() into the Thread.cc class
as opposed to them being an extern function in P_Thread.h. Also
62 matches
Mail list logo
