Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-130400177
Thanks for all the input, I appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-130386828
That's all my comments for now, looking much better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36889035
--- Diff: proxy/Makefile.am ---
@@ -46,7 +46,7 @@ AM_CPPFLAGS = \
-I$(top_srcdir)/mgmt \
-I$(top_srcdir)/mgmt/utils \
-I$(top_srcdir
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36888489
--- Diff: proxy/Makefile.am ---
@@ -46,7 +46,7 @@ AM_CPPFLAGS = \
-I$(top_srcdir)/mgmt \
-I$(top_srcdir)/mgmt/utils \
-I$(t
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36887236
--- Diff: lib/ts/Diags.h ---
@@ -36,12 +36,14 @@
#define __DIAGS_H___
#include
-#include "ts/ink_error.h"
-#include "ts
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36885521
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,578 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license L
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36883442
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,578 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36883269
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,578 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36881681
--- Diff: iocore/eventsystem/test_Buffer.cc ---
@@ -91,23 +91,13 @@ reconfigure_diags()
static void
init_diags(const char *bdt, const
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36881282
--- Diff: doc/reference/configuration/records.config.en.rst ---
@@ -214,6 +214,28 @@ A value of ``0`` means no signal will be sent.
The
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36807553
--- Diff: iocore/net/test_certlookup.cc ---
@@ -206,7 +206,8 @@ SSLReleaseContext(SSL_CTX *ctx)
int
main(int argc, const char **argv)
{
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36800085
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36794702
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license L
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36782875
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36781478
--- Diff: proxy/logging/LogFile.cc ---
@@ -754,115 +585,33 @@ LogFile::display(FILE *fd)
fprintf(fd, "Logfile: %s, %s\n", get_name(), (is
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36781403
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license L
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36780749
--- Diff: cmd/traffic_crashlog/Makefile.am ---
@@ -20,6 +20,7 @@ bin_PROGRAMS = traffic_crashlog
AM_CPPFLAGS = \
$(iocore_include_di
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36778052
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license L
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-129997435
jpeach;
I know this has been discussed quite a bit and I've always heard about
doing the rotation for `traffic.out` and `diags.log` (as in the ori
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36777148
--- Diff: proxy/logging/Makefile.am ---
@@ -27,7 +28,7 @@ AM_CPPFLAGS = \
-I$(top_srcdir)/proxy/hdrs \
-I$(top_srcdir)/proxy/share
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36777072
--- Diff: proxy/logging/LogFile.h ---
@@ -177,7 +92,12 @@ class LogFile : public LogBufferSink, public RefCountObj
off_t
get_size_
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36776891
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license L
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36776865
--- Diff: proxy/logging/LogFile.h ---
@@ -168,8 +85,6 @@ class LogFile : public LogBufferSink, public RefCountObj
static int write_
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36776263
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772493
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772358
--- Diff: cmd/traffic_cop/traffic_cop.cc ---
@@ -767,6 +767,26 @@ spawn_manager()
exit(1);
}
+ // Move any traffic.out that we
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772290
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772110
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771917
--- Diff: cmd/traffic_manager/traffic_manager.cc ---
@@ -565,6 +612,25 @@ main(int argc, const char **argv)
lmgmt->proxy_options = tsAr
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771572
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771629
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771496
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36770431
--- Diff: iocore/net/test_certlookup.cc ---
@@ -206,7 +206,8 @@ SSLReleaseContext(SSL_CTX *ctx)
int
main(int argc, const char **argv)
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36770248
--- Diff: cmd/traffic_crashlog/Makefile.am ---
@@ -20,6 +20,7 @@ bin_PROGRAMS = traffic_crashlog
AM_CPPFLAGS = \
$(iocore_include_dirs) \
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-129969889
There are a few reasons:
- It makes sense from the user perspective, since they can already control
rotation from records.config of the access & error logs
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36769922
--- Diff: iocore/eventsystem/test_Event.cc ---
@@ -91,23 +91,13 @@ reconfigure_diags()
static void
init_diags(const char *bdt, const c
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-129955776
Can you explain why we need this, rather than adding better support for
something like log rotate?
---
If your project is set up for it, you can reply to this ema
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36764670
--- Diff: cmd/traffic_crashlog/traffic_crashlog.cc ---
@@ -91,7 +92,8 @@ main(int /* argc ATS_UNUSED */, const char **argv)
crashlog_targ
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36765118
--- Diff: cmd/traffic_crashlog/Makefile.am ---
@@ -20,6 +20,7 @@ bin_PROGRAMS = traffic_crashlog
AM_CPPFLAGS = \
$(iocore_include_di
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36763807
--- Diff: cmd/traffic_cop/traffic_cop.cc ---
@@ -767,6 +767,26 @@ spawn_manager()
exit(1);
}
+ // Move any traffic.ou
Github user bellofreedom commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36656961
--- Diff: proxy/shared/Makefile.am ---
@@ -26,6 +26,8 @@ noinst_LIBRARIES = \
AM_CPPFLAGS = \
$(iocore_include_dirs) \
-I$(top_s
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/274
TS-306 Enable log rotation for diags.log & traffic.out
- The commit message contains an architectural overview of this feature
- 'make test' and './traffic_server -R 1' all pass right now
43 matches
Mail list logo
