Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/628
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/628#discussion_r63227912
--- Diff: mgmt/api/CoreAPI.h ---
@@ -45,10 +45,11 @@ TSProxyStateT ProxyStateGet();
TSMgmtError ProxyStateSet(TSProxyStateT state, TSCacheC
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/628#discussion_r63054437
--- Diff: mgmt/api/CoreAPI.h ---
@@ -45,10 +45,11 @@ TSProxyStateT ProxyStateGet();
TSMgmtError ProxyStateSet(TSProxyStateT state, TSCacheClearT cle
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/628#discussion_r63054174
--- Diff: mgmt/api/CoreAPI.h ---
@@ -45,10 +45,11 @@ TSProxyStateT ProxyStateGet();
TSMgmtError ProxyStateSet(TSProxyStateT state, TSCacheClearT clea
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/628#discussion_r63054150
--- Diff: proxy/Main.cc ---
@@ -1972,6 +1974,31 @@ mgmt_storage_device_cmd_callback(void *data, char
*arg, int len)
return NULL;
}
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/628#discussion_r63053644
--- Diff: mgmt/api/CoreAPI.h ---
@@ -45,10 +45,11 @@ TSProxyStateT ProxyStateGet();
TSMgmtError ProxyStateSet(TSProxyStateT state, TSCacheClearT cle
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/628#issuecomment-218617861
Linux (CentOS7) build finished successfully. Details on
https://ci.trafficserver.apache.org/job/Github-Linux/19/
---
If your project is set up for it, you c
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/628#issuecomment-218616131
Ok, I fixed the build issue I think (out of memory), kicking off a new
build. [approve ci]
---
If your project is set up for it, you can reply to this email and ha
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/628#issuecomment-218615012
Linux (CentOS7) build failed! Details on
https://ci.trafficserver.apache.org/job/Github-Linux/18/
---
If your project is set up for it, you can reply to thi
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/628#issuecomment-218614105
Sigh, the build terminated with the Jenkins agent taking a dive it seems...
Try again. [approve ci]
---
If your project is set up for it, you can reply to this ema
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/628#issuecomment-218613456
Linux (CentOS7) build failed! Details on
https://ci.trafficserver.apache.org/job/Github-Linux/16/
---
If your project is set up for it, you can reply to thi
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/628
TS-4032: Enable command line based message passing to plugins.
This is the second round after PR-343. I made the RPC unpacking changes HRP
recommended. Why they didn't compile before
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-218612497
I changed the RPC unpacking to use the standard mechanism. I don't know why
it didn't compile before and I don't the energy to figure it out.
---
If your
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-187814680
@SolidWallOfCode and @dragon512 are going to take ownership of this.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-161019315
Message marshaling works just fine, see #301 for an example of exactly what
you want to do here. If you can show me the problem then I can try to help.
---
If you
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-160998970
I need to work on the documentation a bit more before I send it out for
formal API review. I would also like to build better example / use case code.
It m
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-160998361
I hand marshall the message from `traffic_manager` to `traffic_server`
because the technique you suggest did not work for me. What I did was pass the
raw
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-160858064
Looks nice. You don't need to hand-marshall the local manager message. Just
use ```mgmt_message_length()``` and ```mgmt_message_marshall()``` to marshall
into a bu
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-160667524
I have updated the PR with several changes.
* "Alert" is now "Message"
* Messaging is a privileged operation.
* Messages have a tag and pay
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-159670541
That seems fine, but this mechanism doesn't provide channels or any ability
for plugins to subscribe to messages. There's no reason to think that all
plugins will
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-159647608
I thought quite a bit about broadcast vs. targeted messages and decided I
prefer this style. It's based on my previous experience with message bus style
m
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-159467097
I think this is something that will be incredibly useful, thanks for
working on it.
---
If your project is set up for it, you can reply to this email and have your
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-159090606
> I thought I saw a comment from James but it doesn't seem to be there now.
I think I made them on the JIRA.
> 1) I'm open to using a term other th
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-159058332
I thought I saw a comment from James but it doesn't seem to be there now.
1) I'm open to using a term other than "alert", if there are any specific
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/343
TS-4032: Enable command line based message passing to plugins.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/tr
26 matches
Mail list logo
