Re: why __thread thread_id()

2013-06-04 Thread Yunkai Zhang
I have submitted a path: https://issues.apache.org/jira/browse/TS-1938 On Wed, Jun 5, 2013 at 10:56 AM, Yunkai Zhang wrote: > On Wed, Jun 5, 2013 at 10:44 AM, John Plevyak wrote: > >> pthread_self() on x86 accesses a register on CPU, so it is quite fast >> (i.e. >> no syscall). >> > > Yes, Le

Re: why __thread thread_id()

2013-06-04 Thread Yunkai Zhang
On Wed, Jun 5, 2013 at 10:44 AM, John Plevyak wrote: > pthread_self() on x86 accesses a register on CPU, so it is quite fast (i.e. > no syscall). > Yes, Let's give a patch to drop this wrapper. > > john > > > On Thu, May 23, 2013 at 11:22 PM, Yunkai Zhang > wrote: > > > Oh, I read the impleme

Re: why __thread thread_id()

2013-06-04 Thread John Plevyak
pthread_self() on x86 accesses a register on CPU, so it is quite fast (i.e. no syscall). john On Thu, May 23, 2013 at 11:22 PM, Yunkai Zhang wrote: > Oh, I read the implementation of pthread_self() in glibc just now, It's > simple then I guessed, > > It seems an overkill optimization. I think

Re: why __thread thread_id()

2013-05-23 Thread Yunkai Zhang
Oh, I read the implementation of pthread_self() in glibc just now, It's simple then I guessed, It seems an overkill optimization. I think we should drop this wrapper. On Fri, May 24, 2013 at 2:14 PM, Yunkai Zhang wrote: > > > > On Fri, May 24, 2013 at 1:41 AM, James Peach wrote: > >> Hi Yunk

Re: why __thread thread_id()

2013-05-23 Thread Yunkai Zhang
On Fri, May 24, 2013 at 1:41 AM, James Peach wrote: > Hi Yunkai, > > I'm looking at the reclaimable freelist code, and this jumped out at me: > > static inline pthread_t thread_id(void) > { > static __thread pthread_t tid; > > return tid?tid:(tid = pthread_self

why __thread thread_id()

2013-05-23 Thread James Peach
Hi Yunkai, I'm looking at the reclaimable freelist code, and this jumped out at me: static inline pthread_t thread_id(void) { static __thread pthread_t tid; return tid?tid:(tid = pthread_self()); } Why does this need to cache the thread ID in thread l