Re: [E] TS API Review: New HTTP/2 stream id and priority getters

2020-09-02 Thread Brian Neradt
Correct, a regular C struct. On Wed, Sep 2, 2020 at 11:28 AM Leif Hedstrom wrote: > > > > On Sep 1, 2020, at 3:11 PM, Alan Carroll > wrote: > > > > Sorry for chiming in late - > > > > Note this is extremely similar to IP addresses and I recommend we use the > > same solution. That is, there is

Re: [E] TS API Review: New HTTP/2 stream id and priority getters

2020-09-02 Thread Leif Hedstrom
> On Sep 1, 2020, at 3:11 PM, Alan Carroll > wrote: > > Sorry for chiming in late - > > Note this is extremely similar to IP addresses and I recommend we use the > same solution. That is, there is a class HttpPriority which has just a > type/style/family value and possibly a length. This is

Re: [E] Re: TS API Review: New HTTP/2 stream id and priority getters

2020-09-02 Thread Alan Carroll
Some notes: maskit - we can just add another enum value. You're right that it should probably not be "ProtocolType" because it may be unrelated. "PriorityType" would probably be better as a name. There shouldn't be a "0_9" - I thought we had agreed to not support that at all anymore. There

Re: [E] TS API Review: New HTTP/2 stream id and priority getters

2020-09-02 Thread Brian Neradt
Considering this input: - I changed the TSHttpTxnClientStreamIdGet to return a uint64_t. - I removed 0_9 from the protocol type list and added HTTP_PROTOCOL_TYPE_HTTP_UNSPECIFIED. - I renamed TSHttpProtocolType to TSHttpPriorityType. The API functions now look like: tsapi

Problem with build with 8.1.x?

2020-09-02 Thread Chou, Peter
Hi, I noticed that after I compiled the 8.1.x branch that the compilation process modified a file tracked by git. This does not seem right to me? pebc@piplup2:~/git/github/apache-trafficserver$ git status On branch 8.1.x Your branch is up to date with 'origin/8.1.x'. Changes not staged for