Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/199#issuecomment-101371701
Re: [trafficserver] UUID Proposal (#199)
I'll take a look. Can you close out PR 106, since this supercedes that? I
don't want t
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/204#discussion_r31177159
--- Diff: plugins/experimental/ts_lua/ts_lua_http_config.c ---
@@ -81,7 +81,8 @@ typedef enum
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/204#discussion_r31177284
--- Diff: proxy/http/HttpConfig.h ---
@@ -554,8 +554,8 @@ struct OverridableHttpConfigParams {
MgmtInt flow_low_water_mark; ///< F
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/204#discussion_r31177349
--- Diff: proxy/http/HttpConfig.h ---
@@ -708,7 +708,7 @@ struct HttpConfigParams : public ConfigInfo {
// Error Reporting
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/204#issuecomment-106066389
Looks good overall but needs a bit of cleanup. In general the "// !@#"
comments need to be removed.
---
If your project is set up for it, you
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/206
TS-3650: Track configuration variable source.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107638211
The chat concensus seemed to be to change this to NULL, DEFAULT, EXPLICIT,
ENV. I'll change "SRC" to "SOURCE" as well - I was tem
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31773400
--- Diff: lib/atscppapi/examples/globalhook/GlobalHookPlugin.cc ---
@@ -19,24 +19,30 @@
#include
#include
#include
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31773434
--- Diff: lib/atscppapi/examples/globalhook/GlobalHookPlugin.cc ---
@@ -19,24 +19,30 @@
#include
#include
#include
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31773527
--- Diff: lib/atscppapi/examples/helloworld/HelloWorldPlugin.cc ---
@@ -20,16 +20,23 @@
#include
#include
#include
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31773507
--- Diff: lib/atscppapi/examples/globalhook/GlobalHookPlugin.cc ---
@@ -19,24 +19,30 @@
#include
#include
#include
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31773629
--- Diff: lib/atscppapi/src/Transaction.cc ---
@@ -98,6 +97,46 @@ Transaction::~Transaction()
delete state_;
}
+bool
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31773706
--- Diff: lib/atscppapi/src/Transaction.cc ---
@@ -98,6 +97,46 @@ Transaction::~Transaction()
delete state_;
}
+bool
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31773748
--- Diff: lib/atscppapi/src/include/atscppapi/PluginInit.h ---
@@ -37,10 +38,10 @@ extern "C" {
*/
void TSPluginInit(int a
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/213#issuecomment-109078777
To clarify James' comment, it looks like you have TS-3560 mixed in with
this as well. You'll want to have multiple branches, one per ticket
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31782182
--- Diff: lib/atscppapi/src/Transaction.cc ---
@@ -98,6 +97,46 @@ Transaction::~Transaction()
delete state_;
}
+bool
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31829055
--- Diff: lib/atscppapi/examples/helloworld/HelloWorldPlugin.cc ---
@@ -20,16 +20,23 @@
#include
#include
#include
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/213#discussion_r31840546
--- Diff: lib/atscppapi/examples/helloworld/HelloWorldPlugin.cc ---
@@ -20,16 +20,23 @@
#include
#include
#include
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/214#discussion_r32019443
--- Diff: lib/atscppapi/src/include/atscppapi/Transaction.h ---
@@ -30,7 +30,7 @@
#include "atscppapi/shared_ptr.h"
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/185#issuecomment-110553260
I think the most likely cause is the code base was reformatted and you're
being hit by that. You need to reformat you code base to match before tryi
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/215#issuecomment-112147592
It's not really feasible to ask the user agent to change behavior. In my
view the bottom line is that ATS does this, it's an incompatible cha
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/215#issuecomment-112159037
My understanding is it is a plugin that enables redirection following for
the request but the request is from a user agent. I am aware this is not
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/214#discussion_r32853430
--- Diff: lib/atscppapi/examples/async_http_fetch/AsyncHttpFetch.cc ---
@@ -214,6 +214,7 @@ void
TSPluginInit(int argc ATSCPPAPI_UNUSED
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33060076
--- Diff: proxy/StatSystem.h ---
@@ -49,69 +49,75 @@
class TransactionMilestones
{
public:
+ // Used for array indexes
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33060139
--- Diff: proxy/StatSystem.h ---
@@ -49,69 +49,75 @@
class TransactionMilestones
{
public:
+ // Used for array indexes
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33060322
--- Diff: proxy/http/HttpSM.cc ---
@@ -6662,48 +6668,61 @@ HttpSM::update_stats()
}
char client_ip[INET6_ADDRSTRLEN
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33060489
--- Diff: proxy/http/HttpTransact.cc ---
@@ -8856,75 +8856,100 @@ HttpTransact::update_size_and_time_stats(State *s,
ink_hrtime total_time
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33062665
--- Diff: proxy/logging/LogField.cc ---
@@ -212,6 +269,51 @@ LogField::~LogField()
ats_free(m_symbol
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33062790
--- Diff: proxy/logging/LogField.cc ---
@@ -212,6 +269,51 @@ LogField::~LogField()
ats_free(m_symbol
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/229#issuecomment-114571019
I think the use of `std::map` is problematic because of its secondary
effects, most importantly having to duplicate a string just to do a look up is
a
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/182#issuecomment-114736912
This looks basically OK but I think we might want to change `dst` and `src`
to `local` and `remote`. I think that's less ambiguous. I can do that as
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r33196590
--- Diff: proxy/http/HttpSM.cc ---
@@ -4622,16 +4623,16 @@ HttpSM::do_http_server_open(bool raw)
ink_assert(pending_action == NULL
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33297453
--- Diff: proxy/logging/LogField.cc ---
@@ -132,6 +168,13 @@ LogField::LogField(const char *name, const char
*symbol, Type type, MarshalFunc
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/229#issuecomment-115379759
Looking much better. I think the `std::map` use is acceptable - it's not
modified on the critical path and so there are no allocations which shou
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/234#discussion_r33326221
--- Diff: iocore/hostdb/I_HostDBProcessor.h ---
@@ -254,6 +254,41 @@ struct HostDBInfo {
uint64_t md5_high
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/229#issuecomment-115738793
Ready to ship. The only tweak I'd recommend now is to put a reference to
`TSHttpTxnMilestoneGet` in the documentation update so there's a l
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/218#discussion_r33428474
--- Diff: doc/admin/event-logging-formats.en.rst ---
@@ -170,6 +170,24 @@ The following list describes Traffic Server custom
logging fields
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/218#discussion_r33428565
--- Diff: doc/reference/api/TSNetVConnSSLCachedHitSet.en.rst ---
@@ -0,0 +1,32 @@
+.. Licensed to the Apache Software Foundation (ASF
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/218#issuecomment-116361206
Overall I think the log tags are useful in ways aggregate statistics are
not and I support adding those tags.
---
If your project is set up for it, you
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/229#issuecomment-116773852
I discussed this with Bryan and Susan and we think the least worst option
is to put two milestone indices in the `LogField` class. The code in
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/236
TS-3642: Make server session sharing configuration work as documented.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33810635
--- Diff: iocore/hostdb/P_HostDBProcessor.h ---
@@ -190,6 +190,14 @@ extern RecRawStatBlock *hostdb_rsb;
#define
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33810813
--- Diff: iocore/hostdb/P_HostDBProcessor.h ---
@@ -190,6 +190,14 @@ extern RecRawStatBlock *hostdb_rsb;
#define
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33811033
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -659,6 +660,20 @@ db_mark_for(IpAddr const &ip)
HostDBInfo *
probe(ProxyMutex *m
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33813578
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2833,15 +2650,8 @@ ParseHostFile(char const *path)
}
}
- if
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33820528
--- Diff: iocore/hostdb/P_HostDBProcessor.h ---
@@ -190,6 +190,14 @@ extern RecRawStatBlock *hostdb_rsb;
#define
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33820620
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -659,6 +660,21 @@ db_mark_for(IpAddr const &ip)
HostDBInfo *
probe(ProxyMutex *m
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33820816
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2565,18 +2568,9 @@ int HostDBFileUpdateActive = 0;
// Contents of the host file. We keep this
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33824514
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2771,11 +2586,14 @@ ParseHostLine(char *l)
int n_elts = elts.Initialize(l, SHARE_TOKS
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33935287
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2833,15 +2650,8 @@ ParseHostFile(char const *path)
}
}
- if
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/244#issuecomment-119953440
Looks reasonable as a stopgap to me. Hopefully we can in the near future do
better through restructuring the underlying protocol handling structure as in
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/245#discussion_r34371142
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -1037,6 +1037,33 @@ HostDBProcessor::getbyname_imm(Continuation *cont,
process_hostdb_info_pfn proce
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/245#discussion_r34371196
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -1801,6 +1828,39 @@ HostDBContinuation::do_put_response(ClusterMachine
*m, HostDBInfo *r, Continuati
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/254#issuecomment-122602554
Whether the verification is per origin is up to the administrator, via his
configuration. The remap issue is a distraction, since the underlying issue is
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/260
TS-3774: Fix memory leak issue in host file parsing for HostDB.
This implements the file double buffering and works in my tests.
You can merge this pull request into a Git repository
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/262#issuecomment-125246959
Looks fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/262#issuecomment-125252626
Perhaps what we should do is allow the configuration to specify the empty
string for revolv.conf to mean "don't use resolv.conf". I think
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/253#issuecomment-125773588
Looks reasonable, except master is frozen until we clean up 6.0.0,
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/259#discussion_r35712793
--- Diff: mgmt/Alarms.cc ---
@@ -413,6 +413,7 @@ Alarms::constructAlarmMessage(const AppVersionInfo
&version, char *ip, char
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/272
API: Proposal for additional IO buffer and body template API.
This is not intended to be merge immediately because it describes API that
has not yet been written. Comments should be
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/272#issuecomment-128797783
I added the new function `TSIOBufferReaderIsAvailAtLeast` because this has
proved handy in the core and (since it's an existing method) this will be
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36763807
--- Diff: cmd/traffic_cop/traffic_cop.cc ---
@@ -767,6 +767,26 @@ spawn_manager()
exit(1);
}
+ // Move any
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36765118
--- Diff: cmd/traffic_crashlog/Makefile.am ---
@@ -20,6 +20,7 @@ bin_PROGRAMS = traffic_crashlog
AM_CPPFLAGS
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36764670
--- Diff: cmd/traffic_crashlog/traffic_crashlog.cc ---
@@ -91,7 +92,8 @@ main(int /* argc ATS_UNUSED */, const char **argv
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36769922
--- Diff: iocore/eventsystem/test_Event.cc ---
@@ -91,23 +91,13 @@ reconfigure_diags()
static void
init_diags(const char *bdt, const
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36770431
--- Diff: iocore/net/test_certlookup.cc ---
@@ -206,7 +206,8 @@ SSLReleaseContext(SSL_CTX *ctx)
int
main(int argc, const char **argv
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771496
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771629
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771572
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36771917
--- Diff: cmd/traffic_manager/traffic_manager.cc ---
@@ -565,6 +612,25 @@ main(int argc, const char **argv)
lmgmt->proxy_opti
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772110
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772290
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36772493
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36776263
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36776865
--- Diff: proxy/logging/LogFile.h ---
@@ -168,8 +85,6 @@ class LogFile : public LogBufferSink, public RefCountObj
static int
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36777072
--- Diff: proxy/logging/LogFile.h ---
@@ -177,7 +92,12 @@ class LogFile : public LogBufferSink, public RefCountObj
off_t
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36777148
--- Diff: proxy/logging/Makefile.am ---
@@ -27,7 +28,7 @@ AM_CPPFLAGS = \
-I$(top_srcdir)/proxy/hdrs \
-I$(top_srcdir)/proxy
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-129997435
jpeach;
I know this has been discussed quite a bit and I've always heard about
doing the rotation for `traffic.out` and `diags.log` (as i
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36780749
--- Diff: cmd/traffic_crashlog/Makefile.am ---
@@ -20,6 +20,7 @@ bin_PROGRAMS = traffic_crashlog
AM_CPPFLAGS
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36781478
--- Diff: proxy/logging/LogFile.cc ---
@@ -754,115 +585,33 @@ LogFile::display(FILE *fd)
fprintf(fd, "Logfile: %s, %s\n"
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36782875
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36800085
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,571 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36881282
--- Diff: doc/reference/configuration/records.config.en.rst ---
@@ -214,6 +214,28 @@ A value of ``0`` means no signal will be sent.
The
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36881681
--- Diff: iocore/eventsystem/test_Buffer.cc ---
@@ -91,23 +91,13 @@ reconfigure_diags()
static void
init_diags(const char *bdt, const
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36883269
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,578 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36883442
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,578 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36887236
--- Diff: lib/ts/Diags.h ---
@@ -36,12 +36,14 @@
#define __DIAGS_H___
#include
-#include "ts/ink_error.h"
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36888489
--- Diff: proxy/Makefile.am ---
@@ -46,7 +46,7 @@ AM_CPPFLAGS = \
-I$(top_srcdir)/mgmt \
-I$(top_srcdir)/mgmt/utils \
-I
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-130386828
That's all my comments for now, looking much better.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130400491
I'm going to side with Uri on this one as well. Adding those to the core
HTTP method list seems wrong to me. As I understand, the real goal here is
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/280#issuecomment-134467459
While I think that using the `cache.http` override for transaction level
caching control is bad design, it is nonetheless the current design and I must
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/280#issuecomment-135156602
I think you should read "patch" as "commit". A co-op commit would just
change documentation or formatting.
---
If your project is se
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/282#issuecomment-136780619
Testing results, empty `storage.config` and `wait_for_cache`
0) ATS starts up with cache disabled. Cache lifecycle hook not called.
1) ATS
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/282#issuecomment-136795398
Talked with @jpeach and he says this should be testable with multiple file
system cache spans. You need to either use multiple distinct directories or use
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/286#discussion_r38668014
--- Diff: lib/ts/Vec.h ---
@@ -964,41 +965,71 @@ qsort_Vec(C *left, C *right, bool (*lt)(C, C))
}
}
} else
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/286#discussion_r38672458
--- Diff: lib/ts/Vec.h ---
@@ -964,41 +965,71 @@ qsort_Vec(C *left, C *right, bool (*lt)(C, C))
}
}
} else
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
1 - 100 of 238 matches
Mail list logo
